[GitHub] [rocketmq] areyouok commented on a diff in pull request #4338: [ISSUE #4226] Message length exceeds the maximum length when sendback

[GitBox <gi...@apache.org>]

areyouok commented on code in PR #4338:
URL: https://github.com/apache/rocketmq/pull/4338#discussion_r877040004


##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -87,8 +87,8 @@ public class MessageStoreConfig {
     private int fileReservedTime = 72;
     // Flow control for ConsumeQueue
     private int putMsgIndexHightWater = 600000;
-    // The maximum size of message,default is 4M
-    private int maxMessageSize = 1024 * 1024 * 4;
+    // The maximum size of message body,default is 4M,4M only for body length,not include others.
+    private int maxMessageBodySize = 1024 * 1024 * 4;

Review Comment:
   Rename this field and it's getter/setter cause incompatibility. Can we keep it's name and just use it as the limitation of body size?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org