You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/01/07 10:20:20 UTC
[GitHub] [dubbo-go] codecov-io commented on issue #278: ftr: Metric
support Part1: metric filter, method count, method rt
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/278?src=pr&el=h1) Report
> Merging [#278](https://codecov.io/gh/apache/dubbo-go/pull/278?src=pr&el=desc) into [feature/metrics](https://codecov.io/gh/apache/dubbo-go/commit/3fe96d35d3afc3a7d6a24c88285c9bd252d52736?src=pr&el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `80.89%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/278?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/metrics #278 +/- ##
===================================================
+ Coverage 66.39% 66.58% +0.18%
===================================================
Files 111 112 +1
Lines 7062 7182 +120
===================================================
+ Hits 4689 4782 +93
- Misses 1914 1934 +20
- Partials 459 466 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/278?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.54% <ø> (ø)` | :arrow_up: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `50% <ø> (ø)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.73% <0%> (-1.83%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `97.75% <0%> (-2.25%)` | :arrow_down: |
| [filter/impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZ2VuZXJpY19maWx0ZXIuZ28=) | `67.69% <0%> (+2.02%)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `69.28% <100%> (+0.3%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.39% <100%> (-0.41%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.73% <100%> (+0.36%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `60.86% <100%> (-1.64%)` | :arrow_down: |
| [...ter/impl/tps/impl/tps\_limit\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvdHBzL2ltcGwvdHBzX2xpbWl0X2ZpeF93aW5kb3dfc3RyYXRlZ3kuZ28=) | `100% <100%> (ø)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/dubbo-go/pull/278/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/278?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/278?src=pr&el=footer). Last update [3fe96d3...f82e6bd](https://codecov.io/gh/apache/dubbo-go/pull/278?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/278 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org