You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2023/04/28 22:37:20 UTC

[GitHub] [superset] eschutho commented on pull request #21535: fix(parsedquery): resolve conflict when aliases and tables have the same name

eschutho commented on PR #21535:
URL: https://github.com/apache/superset/pull/21535#issuecomment-1528163516

   > Hi @eschutho would you be able to weigh in on the above?
   
   HI @giftig, thanks for the PR. I didn't read through it thoroughly so excuse me if I missed anything in the implementation, but at first glance, I do know that [we added rls support to subqueries](https://github.com/apache/superset/blob/ca408a71594b0c394159c776c0f2669479897e5b/superset/models/helpers.py#L142) in 2.1.0. What version are you currently on?
   
   Also I agree on the suggestion to connect with @rusackas on contributing back and working more closely with the team here. Evan will be a great resource for getting you plugged in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org