You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/11/14 20:20:27 UTC
Review Request: Added new test fixture to properly setup and teardown slave
working directory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
Diffs
-----
src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6
src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
Diff: https://reviews.apache.org/r/8055/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 15, 2012, 11:10 p.m., Ben Mahler wrote:
> > src/tests/allocator_tests.cpp, line 85
> > <https://reviews.apache.org/r/8055/diff/1/?file=189896#file189896line85>
> >
> > Let's still call this AllocatorTest?
> > Looking at the primer that seems to be the convention: http://code.google.com/p/googletest/wiki/Primer
changed this to DRFAllocatorTest
> On Nov. 15, 2012, 11:10 p.m., Ben Mahler wrote:
> > src/tests/master_tests.cpp, line 1012
> > <https://reviews.apache.org/r/8055/diff/1/?file=189901#file189901line1012>
> >
> > ditto fixture name:
> >
> > s/WhitelistFixture/MasterWhitelistTest?
Changed it to WhiteListTest
> On Nov. 15, 2012, 11:10 p.m., Ben Mahler wrote:
> > src/tests/resource_offers_tests.cpp, line 519
> > <https://reviews.apache.org/r/8055/diff/1/?file=189902#file189902line519>
> >
> > s/ResourceOffersTestFixture/ResourceOffersTest
calling it MultipleExecutorsTest.
> On Nov. 15, 2012, 11:10 p.m., Ben Mahler wrote:
> > src/tests/utils.hpp, line 103
> > <https://reviews.apache.org/r/8055/diff/1/?file=189903#file189903line103>
> >
> > Too bad my CHECK_SOME is not submitted ;)
some day.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/#review13438
-----------------------------------------------------------
On Nov. 14, 2012, 7:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8055/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2012, 7:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
> src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
> src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
> src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
> src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
> src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
> src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
> src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6
> src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
> src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
>
> Diff: https://reviews.apache.org/r/8055/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/#review13438
-----------------------------------------------------------
Ship it!
modulo fixture naming
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/8055/#comment28955>
Let's still call this AllocatorTest?
Looking at the primer that seems to be the convention: http://code.google.com/p/googletest/wiki/Primer
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/8055/#comment28956>
Hm.. so what's the difference between this AllocatorTest fixture and the AllocatorTestFixture fixture? Maybe name the tests appropriately to show the difference?
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/8055/#comment28958>
src/tests/master_tests.cpp
<https://reviews.apache.org/r/8055/#comment28959>
ditto fixture name:
s/WhitelistFixture/MasterWhitelistTest?
src/tests/resource_offers_tests.cpp
<https://reviews.apache.org/r/8055/#comment28960>
s/ResourceOffersTestFixture/ResourceOffersTest
src/tests/utils.hpp
<https://reviews.apache.org/r/8055/#comment28796>
Too bad my CHECK_SOME is not submitted ;)
- Ben Mahler
On Nov. 14, 2012, 7:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8055/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2012, 7:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
> src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
> src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
> src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
> src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
> src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
> src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
> src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6
> src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
> src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
>
> Diff: https://reviews.apache.org/r/8055/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/#review16793
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 16, 2013, 2:40 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8055/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 2:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
> src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
> src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
> src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
> src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
> src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
> src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
> src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45
> src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
> src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
>
> Diff: https://reviews.apache.org/r/8055/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 7:44 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased off trunk.
no need for review, just for posterity.
Description
-------
I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
Diffs (updated)
-----
src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
src/tests/fault_tolerance_tests.cpp 44eef03aedd89ddfce8491add73918d8f453a0f2
src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
src/tests/master_tests.cpp e140f409bf6e651cc365b5fb8d064ceae1cd8ed8
src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45
src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
Diff: https://reviews.apache.org/r/8055/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/
-----------------------------------------------------------
(Updated Jan. 16, 2013, 2:40 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added launcher flag and MESOS_SOURCE_DIR env variable for properly locating mesos-executor and killtree.sh
Description
-------
I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
Diffs (updated)
-----
src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45
src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
Diff: https://reviews.apache.org/r/8055/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/
-----------------------------------------------------------
(Updated Jan. 3, 2013, 11:48 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's comments and rebased off trunk
Description
-------
I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
Diffs (updated)
-----
src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666
src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45
src/tests/utils.cpp 3e01dc98f56f35141c793fc52fc7ea19f2e22135
src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
third_party/libprocess/include/stout/strings.hpp 47b0d6d454c8ced541910e2ceec8a812556df7dd
Diff: https://reviews.apache.org/r/8055/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Vinod Kone <vi...@gmail.com>.
> On Dec. 11, 2012, 11:47 p.m., Benjamin Hindman wrote:
> > src/tests/utils.hpp, line 95
> > <https://reviews.apache.org/r/8055/diff/2/?file=190537#file190537line95>
> >
> > s/MesosSetup/MesosTest/
sed -i '' 's/MesosSetup/MesosTest/g' *
:)
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/#review14330
-----------------------------------------------------------
On Nov. 15, 2012, 11:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8055/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2012, 11:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
> src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
> src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
> src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
> src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
> src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
> src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
> src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6
> src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
> src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
>
> Diff: https://reviews.apache.org/r/8055/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/#review14330
-----------------------------------------------------------
src/tests/utils.hpp
<https://reviews.apache.org/r/8055/#comment30513>
s/MesosSetup/MesosTest/
src/tests/utils.hpp
<https://reviews.apache.org/r/8055/#comment30514>
s/= d/= d/
- Benjamin Hindman
On Nov. 15, 2012, 11:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8055/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2012, 11:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
> src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
> src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
> src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
> src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
> src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
> src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
> src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6
> src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
> src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
>
> Diff: https://reviews.apache.org/r/8055/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added new test fixture to properly setup and teardown
slave working directory
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/
-----------------------------------------------------------
(Updated Nov. 15, 2012, 11:42 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
BenM's comments
Description
-------
I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
Diffs (updated)
-----
src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503
src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392
src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5
src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df
src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226
src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6
src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6
src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13
src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0
Diff: https://reviews.apache.org/r/8055/diff/
Testing
-------
make check
Thanks,
Vinod Kone