[GitHub] john-bodley edited a comment on issue #6942: [SQL Lab] Removing display limit

[GitBox <gi...@apache.org>]

john-bodley edited a comment on issue #6942: [SQL Lab] Removing display limit
URL: https://github.com/apache/incubator-superset/pull/6942#issuecomment-467278697
 
 
   @mistercrunch thanks for the context. I think there may be a few issues with the `DISPLAY_MAX_ROW`: 
   
   1. It's not apparent to the user that the display is potentially showing only a preview (there's no verbiage in the UI to inform the user of this). This can be problematic if a user is searching/ordering the preview expecting to see a certain value and/or is mislead regarding the cardinality of a specific column. 
   2. It's not apparent that the preview/export to CSV could return different row counts. 
   3. How does a user override the display limit, i.e., say they want to see more than the configured `DISPLAY_MAX_ROW` and don't want to export the results to a CSV file.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org