You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/06/05 00:54:10 UTC

Review Request 35091: Update libprocess gmock to use synchronized.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35091/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Bernd Mathiske.


Bugs: MESOS-2805
    https://issues.apache.org/jira/browse/MESOS-2805


Repository: mesos


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/include/process/gmock.hpp 6adc034daf8976e3dc6df46f9adf8ab73eaf2af8 

Diff: https://reviews.apache.org/r/35091/diff/


Testing
-------


Thanks,

Joris Van Remoortere

Re: Review Request 35091: Update libprocess gmock to use synchronized.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35091/#review87815
-----------------------------------------------------------

Ship it!


With MPark's refactor we can kill the 'UNREACHABLE()'! I'll do that for you now! AWESOME!

- Benjamin Hindman


On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35091/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 10:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2805
>     https://issues.apache.org/jira/browse/MESOS-2805
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gmock.hpp 6adc034daf8976e3dc6df46f9adf8ab73eaf2af8 
> 
> Diff: https://reviews.apache.org/r/35091/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>