You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2020/01/18 20:10:36 UTC
[maven-project-info-reports-plugin] 01/02: [MPIR-385] Avoid adding
mailto: prefix twice
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-project-info-reports-plugin.git
commit c7acb571ac57de67ba966183ff5816a063ebb96a
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Fri Jan 17 22:52:11 2020 +0100
[MPIR-385] Avoid adding mailto: prefix twice
---
.../java/org/apache/maven/report/projectinfo/MailingListsReport.java | 3 ++-
.../org/apache/maven/report/projectinfo/MailingListsReportTest.java | 2 +-
src/test/resources/plugin-configs/mailing-lists-plugin-config.xml | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/main/java/org/apache/maven/report/projectinfo/MailingListsReport.java b/src/main/java/org/apache/maven/report/projectinfo/MailingListsReport.java
index 39b415f..1e516cc 100644
--- a/src/main/java/org/apache/maven/report/projectinfo/MailingListsReport.java
+++ b/src/main/java/org/apache/maven/report/projectinfo/MailingListsReport.java
@@ -247,7 +247,8 @@ public class MailingListsReport
{
return createLinkPatternedText( text, defaultHref );
}
- return createLinkPatternedText( text, "mailto:" + href );
+ return createLinkPatternedText( text,
+ href.toLowerCase( Locale.ENGLISH ).startsWith( "mailto:" ) ? href : "mailto:" + href );
}
/**
diff --git a/src/test/java/org/apache/maven/report/projectinfo/MailingListsReportTest.java b/src/test/java/org/apache/maven/report/projectinfo/MailingListsReportTest.java
index 112eb06..2c47857 100644
--- a/src/test/java/org/apache/maven/report/projectinfo/MailingListsReportTest.java
+++ b/src/test/java/org/apache/maven/report/projectinfo/MailingListsReportTest.java
@@ -81,7 +81,7 @@ public class MailingListsReportTest
String post = getString("report.mailing-lists.column.post");
assertEquals( "mailto:test@maven.apache.org", response.getLinkWith( post ).getAttribute( "href" ) );
String subscribe = getString("report.mailing-lists.column.subscribe");
- assertEquals( "mailto:test-subscribe@maven.apache.org", response.getLinkWith( subscribe ).getAttribute( "href" ) );
+ assertEquals( "MAILTO:test-subscribe@maven.apache.org", response.getLinkWith( subscribe ).getAttribute( "href" ) );
String unsubscribe = getString("report.mailing-lists.column.unsubscribe");
assertNull( response.getLinkWith( unsubscribe ) );
}
diff --git a/src/test/resources/plugin-configs/mailing-lists-plugin-config.xml b/src/test/resources/plugin-configs/mailing-lists-plugin-config.xml
index 7d833c6..036a99a 100644
--- a/src/test/resources/plugin-configs/mailing-lists-plugin-config.xml
+++ b/src/test/resources/plugin-configs/mailing-lists-plugin-config.xml
@@ -36,7 +36,7 @@ under the License.
<mailingList>
<name>Test List</name>
<post>test@maven.apache.org</post>
- <subscribe>test-subscribe@maven.apache.org</subscribe>
+ <subscribe>MAILTO:test-subscribe@maven.apache.org</subscribe>
</mailingList>
</mailingLists>
<build>