You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sa...@gmail.com> on 2023/02/08 01:56:36 UTC
Re: Github actions - Integration tests
Integration tests pass consistently after configuring the
`--max-workers=12` and by not setting the `testMaxParallelForks` (so it
defaults to max-workers/4), except for one test[1] which is a test called
ConcurrentTestRunnerTest to test the ConcurrentTestRunner.
This test is expected to fail when an atomic int is modified in parallel
threads. This ensures ConcurrentTestRunner is running in parallel, but
unfortunately, Github actions may be running with a single core
(availableProcessors = 2). The logs are available in the summary section
and saved for up to 5 days.
Though the available processors are 2 and it seems the atomic int is never
got executed in parallel. Any thoughts?
@Dan Tagging you as you were the original author to little bit understand
about this test.
Available processors: 2
Available processors: 2
Available processors: 2
Available processors: 2
[1] https://github.com/apache/geode/actions/runs/4119919022
On Mon, 23 Jan 2023 at 11:05, Sai Boorlagadda <sa...@gmail.com>
wrote:
> After working through unit tests and the builds are passing. I am working
> on adding an integration step to the build pipeline.
>
> Looks like there are a few (4 tests) failing[1] on the integration suite.
> Let me know if anyone interested to look into them. It would really good to
> get integration tests enabled on develop.
>
> Below 4 tests needs to be analyzed and fixed:
> 1) LocatorLauncherJmxSerialFilterPropertyBlankIntegrationTest >
> startDoesNotConfigureJmxSerialFilter_whenPropertyIsBlank_onJava8
> 2) LocatorLauncherGlobalSerialFilterPropertyEmptyIntegrationTest >
> startDoesNotConfigureGlobalSerialFilter_whenPropertyIsEmpty
> 3) VersionCommandJUnitTest > initializationError
> 4) LoadClusterConfigFromDirInt > canStartWithDeployedJarInClusterConfig
>
> 1. https://github.com/apache/geode/actions/runs/3983609395/jobs/6829148633
>
> Sai
>
Re: Github actions - Integration tests
Posted by Sai Boorlagadda <sa...@gmail.com>.
Thanks Dan. I choose to remove the test for now.
Here is the PR that enables integration tests on linux platform.
https://github.com/apache/geode/pull/7872
On Wed, 8 Feb 2023 at 08:34, Dan Smith <da...@vmware.com.invalid> wrote:
> That ConcurrentTestRunnerTest is testing a test utility to see if it can
> catch race conditions. We didn't end up using that utility as much as I
> thought we might. You could consider just ignoring/deleting that test.
>
> -Dan
> ________________________________
> From: Sai Boorlagadda <sa...@gmail.com>
> Sent: Tuesday, February 7, 2023 5:56 PM
> To: dev@geode.apache.org <de...@geode.apache.org>
> Subject: Re: Github actions - Integration tests
>
> !! External Email
>
> Integration tests pass consistently after configuring the
> `--max-workers=12` and by not setting the `testMaxParallelForks` (so it
> defaults to max-workers/4), except for one test[1] which is a test called
> ConcurrentTestRunnerTest to test the ConcurrentTestRunner.
>
> This test is expected to fail when an atomic int is modified in parallel
> threads. This ensures ConcurrentTestRunner is running in parallel, but
> unfortunately, Github actions may be running with a single core
> (availableProcessors = 2). The logs are available in the summary section
> and saved for up to 5 days.
>
> Though the available processors are 2 and it seems the atomic int is never
> got executed in parallel. Any thoughts?
>
> @Dan Tagging you as you were the original author to little bit understand
> about this test.
>
> Available processors: 2
> Available processors: 2
> Available processors: 2
> Available processors: 2
>
>
> [1]
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Factions%2Fruns%2F4119919022&data=05%7C01%7Cdasmith%40vmware.com%7C7b2cf42318694513e67208db0977c63d%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638114182273485483%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=unVvHQh5KW2a9ELRAduFXhGS%2B3ahspCpq1NGP9IFAq8%3D&reserved=0
>
>
>
> On Mon, 23 Jan 2023 at 11:05, Sai Boorlagadda <sa...@gmail.com>
> wrote:
>
> > After working through unit tests and the builds are passing. I am working
> > on adding an integration step to the build pipeline.
> >
> > Looks like there are a few (4 tests) failing[1] on the integration suite.
> > Let me know if anyone interested to look into them. It would really good
> to
> > get integration tests enabled on develop.
> >
> > Below 4 tests needs to be analyzed and fixed:
> > 1) LocatorLauncherJmxSerialFilterPropertyBlankIntegrationTest >
> > startDoesNotConfigureJmxSerialFilter_whenPropertyIsBlank_onJava8
> > 2) LocatorLauncherGlobalSerialFilterPropertyEmptyIntegrationTest >
> > startDoesNotConfigureGlobalSerialFilter_whenPropertyIsEmpty
> > 3) VersionCommandJUnitTest > initializationError
> > 4) LoadClusterConfigFromDirInt > canStartWithDeployedJarInClusterConfig
> >
> > 1.
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Factions%2Fruns%2F3983609395%2Fjobs%2F6829148633&data=05%7C01%7Cdasmith%40vmware.com%7C7b2cf42318694513e67208db0977c63d%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638114182273485483%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jIvQuxFsYNFyXEyUuuMVHPdrodXymM9IGYaw4lWIZ2k%3D&reserved=0
> >
> > Sai
> >
>
> !! External Email: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender.
>
Re: Github actions - Integration tests
Posted by Dan Smith <da...@vmware.com.INVALID>.
That ConcurrentTestRunnerTest is testing a test utility to see if it can catch race conditions. We didn't end up using that utility as much as I thought we might. You could consider just ignoring/deleting that test.
-Dan
________________________________
From: Sai Boorlagadda <sa...@gmail.com>
Sent: Tuesday, February 7, 2023 5:56 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: Github actions - Integration tests
!! External Email
Integration tests pass consistently after configuring the
`--max-workers=12` and by not setting the `testMaxParallelForks` (so it
defaults to max-workers/4), except for one test[1] which is a test called
ConcurrentTestRunnerTest to test the ConcurrentTestRunner.
This test is expected to fail when an atomic int is modified in parallel
threads. This ensures ConcurrentTestRunner is running in parallel, but
unfortunately, Github actions may be running with a single core
(availableProcessors = 2). The logs are available in the summary section
and saved for up to 5 days.
Though the available processors are 2 and it seems the atomic int is never
got executed in parallel. Any thoughts?
@Dan Tagging you as you were the original author to little bit understand
about this test.
Available processors: 2
Available processors: 2
Available processors: 2
Available processors: 2
[1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Factions%2Fruns%2F4119919022&data=05%7C01%7Cdasmith%40vmware.com%7C7b2cf42318694513e67208db0977c63d%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638114182273485483%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=unVvHQh5KW2a9ELRAduFXhGS%2B3ahspCpq1NGP9IFAq8%3D&reserved=0
On Mon, 23 Jan 2023 at 11:05, Sai Boorlagadda <sa...@gmail.com>
wrote:
> After working through unit tests and the builds are passing. I am working
> on adding an integration step to the build pipeline.
>
> Looks like there are a few (4 tests) failing[1] on the integration suite.
> Let me know if anyone interested to look into them. It would really good to
> get integration tests enabled on develop.
>
> Below 4 tests needs to be analyzed and fixed:
> 1) LocatorLauncherJmxSerialFilterPropertyBlankIntegrationTest >
> startDoesNotConfigureJmxSerialFilter_whenPropertyIsBlank_onJava8
> 2) LocatorLauncherGlobalSerialFilterPropertyEmptyIntegrationTest >
> startDoesNotConfigureGlobalSerialFilter_whenPropertyIsEmpty
> 3) VersionCommandJUnitTest > initializationError
> 4) LoadClusterConfigFromDirInt > canStartWithDeployedJarInClusterConfig
>
> 1. https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Factions%2Fruns%2F3983609395%2Fjobs%2F6829148633&data=05%7C01%7Cdasmith%40vmware.com%7C7b2cf42318694513e67208db0977c63d%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638114182273485483%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jIvQuxFsYNFyXEyUuuMVHPdrodXymM9IGYaw4lWIZ2k%3D&reserved=0
>
> Sai
>
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.