[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5159: socket: extend socket_storage for rpmsg_socket addrinfo

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#discussion_r778168069



##########
File path: include/sys/socket.h
##########
@@ -284,23 +284,13 @@
  * aligned at an appropriate boundary so that pointers to it can be cast
  * as pointers to protocol-specific address structures and used to access
  * the fields of those structures without alignment problems.
- *
- * REVISIT: sizeof(struct sockaddr_storge) should be 128 bytes.
  */
 
-#ifdef CONFIG_NET_IPv6
 struct sockaddr_storage
 {
   sa_family_t ss_family;       /* Address family */
-  char        ss_data[26];     /* 26-bytes of address data */
+  char        ss_data[126];    /* 126-bytes of address data */

Review comment:
       Since sockaddr_un is 110 bytes:
   ```
   #define UNIX_PATH_MAX  108
   
   struct sockaddr_un
   {
     sa_family_t sun_family;        /* AF_UNIX */
     char sun_path[UNIX_PATH_MAX];  /* pathname */
   };
   ```
   Per the spec, we have to extend to 110 which is close to 128 anyway.:(




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org