You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/09/28 12:32:47 UTC
Review Request 62662: Fix invalid code and logic for BaseDao class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62662/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1815
https://issues.apache.org/jira/browse/RANGER-1815
Repository: ranger
Description
-------
Fix invalid code and logic for BaseDao class
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/dao/BaseDao.java 75593d2f
Diff: https://reviews.apache.org/r/62662/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 62662: Fix invalid code and error logic for the
BaseDao class
Posted by pengjianhua <pe...@zte.com.cn>.
> On 九月 28, 2017, 6:31 p.m., Alejandro Fernandez wrote:
> > Any testing done on this?
Yes. I tested this issue. Thanks!
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62662/#review186594
-----------------------------------------------------------
On 九月 28, 2017, 12:38 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62662/
> -----------------------------------------------------------
>
> (Updated 九月 28, 2017, 12:38 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1815
> https://issues.apache.org/jira/browse/RANGER-1815
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix invalid code and error logic for the BaseDao class
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/dao/BaseDao.java 75593d2f
>
>
> Diff: https://reviews.apache.org/r/62662/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 62662: Fix invalid code and error logic for the
BaseDao class
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62662/#review186594
-----------------------------------------------------------
Any testing done on this?
- Alejandro Fernandez
On Sept. 28, 2017, 12:38 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62662/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 12:38 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1815
> https://issues.apache.org/jira/browse/RANGER-1815
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix invalid code and error logic for the BaseDao class
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/dao/BaseDao.java 75593d2f
>
>
> Diff: https://reviews.apache.org/r/62662/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 62662: Fix invalid code and error logic for the
BaseDao class
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62662/#review186645
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On Sept. 28, 2017, 12:38 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62662/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 12:38 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1815
> https://issues.apache.org/jira/browse/RANGER-1815
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix invalid code and error logic for the BaseDao class
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/dao/BaseDao.java 75593d2f
>
>
> Diff: https://reviews.apache.org/r/62662/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 62662: Fix invalid code and error logic for the
BaseDao class
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62662/
-----------------------------------------------------------
(Updated 九月 28, 2017, 12:38 p.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Summary (updated)
-----------------
Fix invalid code and error logic for the BaseDao class
Bugs: RANGER-1815
https://issues.apache.org/jira/browse/RANGER-1815
Repository: ranger
Description (updated)
-------
Fix invalid code and error logic for the BaseDao class
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/dao/BaseDao.java 75593d2f
Diff: https://reviews.apache.org/r/62662/diff/1/
Testing
-------
Thanks,
pengjianhua