You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by er...@apache.org on 2021/01/08 10:33:44 UTC

[cordova-electron] branch master updated: feat: forward electron's process stdio to terminal (#184)

This is an automated email from the ASF dual-hosted git repository.

erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-electron.git


The following commit(s) were added to refs/heads/master by this push:
     new 3074071  feat: forward electron's process stdio to terminal (#184)
3074071 is described below

commit 307407173dcc9197453c33d2211b8e620b01370e
Author: Zoltán Mihályi <zo...@webvalto.hu>
AuthorDate: Fri Jan 8 11:33:36 2021 +0100

    feat: forward electron's process stdio to terminal (#184)
---
 lib/run.js                      | 2 +-
 tests/spec/unit/lib/run.spec.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/run.js b/lib/run.js
index 4c6a6b5..eba0860 100644
--- a/lib/run.js
+++ b/lib/run.js
@@ -29,7 +29,7 @@ module.exports.run = function (args = {}) {
         path.join(this.locations.www, 'cdv-electron-main.js')
     );
 
-    const child = execa(electron, electonArgs, { windowsHide: false });
+    const child = execa(electron, electonArgs, { windowsHide: false, stdio: 'inherit' });
 
     child.on('close', (code) => {
         process.exit(code);
diff --git a/tests/spec/unit/lib/run.spec.js b/tests/spec/unit/lib/run.spec.js
index 3898039..9ee027f 100644
--- a/tests/spec/unit/lib/run.spec.js
+++ b/tests/spec/unit/lib/run.spec.js
@@ -27,7 +27,7 @@ const apiStub = Object.freeze({
 });
 
 const expectedPathToMain = path.join(apiStub.locations.www, 'cdv-electron-main.js');
-const expectedExecaOptions = { windowsHide: false };
+const expectedExecaOptions = { windowsHide: false, stdio: 'inherit' };
 
 const run = rewire(path.join(rootDir, 'lib/run'));
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org