You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/31 22:27:03 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4767: Introduce a
mode in the server to disable queries
codecov-io commented on issue #4767: Introduce a mode in the server to disable queries
URL: https://github.com/apache/incubator-pinot/pull/4767#issuecomment-548593899
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4767?src=pr&el=h1) Report
> Merging [#4767](https://codecov.io/gh/apache/incubator-pinot/pull/4767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/5439e77f60d6f7efb78acc928a58ba64eca87fee?src=pr&el=desc) will **increase** coverage by `7.84%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4767 +/- ##
============================================
+ Coverage 49.95% 57.79% +7.84%
Complexity 4 4
============================================
Files 1209 1209
Lines 64938 64947 +9
Branches 9458 9460 +2
============================================
+ Hits 32437 37539 +5102
+ Misses 29942 24551 -5391
- Partials 2559 2857 +298
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4767?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `32.69% <ø> (+7.69%)` | `0 <0> (ø)` | :arrow_down: |
| [...er/routing/builder/RoutingTableInstancePruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL1JvdXRpbmdUYWJsZUluc3RhbmNlUHJ1bmVyLmphdmE=) | `86.95% <100%> (+2.74%)` | `0 <0> (ø)` | :arrow_down: |
| [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `90.79% <66.66%> (+42.82%)` | `0 <0> (ø)` | :arrow_down: |
| [...inot/transport/netty/NettyTCPClientConnection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvTmV0dHlUQ1BDbGllbnRDb25uZWN0aW9uLmphdmE=) | `81.45% <0%> (-3.32%)` | `0% <0%> (ø)` | |
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `70.21% <0%> (+0.42%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `88.8% <0%> (+0.72%)` | `0% <0%> (ø)` | :arrow_down: |
| [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `89.71% <0%> (+0.82%)` | `0% <0%> (ø)` | :arrow_down: |
| [...e/io/writer/impl/MutableOffHeapByteArrayStore.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NdXRhYmxlT2ZmSGVhcEJ5dGVBcnJheVN0b3JlLmphdmE=) | `85.71% <0%> (+1.09%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../pinot/core/segment/index/SegmentMetadataImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L1NlZ21lbnRNZXRhZGF0YUltcGwuamF2YQ==) | `80.97% <0%> (+1.21%)` | `0% <0%> (ø)` | :arrow_down: |
| [...pinot/core/operator/docvalsets/SingleValueSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxzZXRzL1NpbmdsZVZhbHVlU2V0LmphdmE=) | `90.41% <0%> (+1.36%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [286 more](https://codecov.io/gh/apache/incubator-pinot/pull/4767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4767?src=pr&el=footer). Last update [5439e77...7387778](https://codecov.io/gh/apache/incubator-pinot/pull/4767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org