You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Merryle Wang via Review Board <no...@reviews.apache.org> on 2019/07/01 18:10:18 UTC
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 1, 2019, 6:10 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Checks for the dynamic attribute refered to in options not existing (null case)
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 254eee4c9d18ab87a8862ce479fc2274227c7c29
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
Diff: https://reviews.apache.org/r/70913/diff/7/
Changes: https://reviews.apache.org/r/70913/diff/6-7/
Testing
-------
Added unit test
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Aadarsh Jajodia <aa...@gmail.com>.
> On July 2, 2019, 3:50 p.m., Ashutosh Mestry wrote:
> > This an edge case: When temporary tables are created, their qualifiedName gets suffixed with GUID, how will this scheme handle that?
Hi Ashutosh, Thats a good point you mentioned. Right now we don't have a way in the templates to refer to a system attribute(we might need this as you mentioned for a temp table). We can take that up later.
- Aadarsh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216308
-----------------------------------------------------------
On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 6:10 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 254eee4c9d18ab87a8862ce479fc2274227c7c29
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
>
>
> Diff: https://reviews.apache.org/r/70913/diff/7/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
> On July 2, 2019, 3:50 p.m., Ashutosh Mestry wrote:
> > This an edge case: When temporary tables are created, their qualifiedName gets suffixed with GUID, how will this scheme handle that?
>
> Aadarsh Jajodia wrote:
> Hi Ashutosh, Thats a good point you mentioned. Right now we don't have a way in the templates to refer to a system attribute(we might need this as you mentioned for a temp table). We can take that up later.
See this: AtlasHiveHookContext
public String getQualifiedName(Table table) {
String tableName = table.getTableName();
if (table.isTemporary()) {
if (SessionState.get() != null && SessionState.get().getSessionId() != null) {
tableName = tableName + TEMP_TABLE_PREFIX + SessionState.get().getSessionId();
} else {
tableName = tableName + TEMP_TABLE_PREFIX + RandomStringUtils.random(10);
}
}
return (table.getDbName() + QNAME_SEP_ENTITY_NAME + tableName + QNAME_SEP_CLUSTER_NAME).toLowerCase() + getClusterName();
}
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216308
-----------------------------------------------------------
On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 6:10 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 254eee4c9d18ab87a8862ce479fc2274227c7c29
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
>
>
> Diff: https://reviews.apache.org/r/70913/diff/7/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216308
-----------------------------------------------------------
This an edge case: When temporary tables are created, their qualifiedName gets suffixed with GUID, how will this scheme handle that?
- Ashutosh Mestry
On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 6:10 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 254eee4c9d18ab87a8862ce479fc2274227c7c29
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
>
>
> Diff: https://reviews.apache.org/r/70913/diff/7/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216618
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 15, 2019, 2:20 a.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 2:20 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
>
>
> Diff: https://reviews.apache.org/r/70913/diff/11/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Aadarsh Jajodia <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216630
-----------------------------------------------------------
Ship it!
Ship It!
- Aadarsh Jajodia
On July 15, 2019, 11:09 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 11:09 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
>
>
> Diff: https://reviews.apache.org/r/70913/diff/13/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216629
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On July 15, 2019, 4:09 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 4:09 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
>
>
> Diff: https://reviews.apache.org/r/70913/diff/13/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Aadarsh Jajodia <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216632
-----------------------------------------------------------
Ship it!
Thanks for uploading the model file. We can have that as a reference.
- Aadarsh Jajodia
On July 16, 2019, 12:12 a.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 16, 2019, 12:12 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
>
>
> Diff: https://reviews.apache.org/r/70913/diff/14/
>
>
> Testing
> -------
>
> Added unit test
>
>
> File Attachments
> ----------------
>
> Hive Model with dynAttributes
> https://reviews.apache.org/media/uploaded/files/2019/07/16/1f7bed33-0509-4aee-acbf-7ed1b0616c84__1030-hive_model.json
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 16, 2019, 12:12 a.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Reverted Hive model file to not include dynAttributes.
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
Diff: https://reviews.apache.org/r/70913/diff/14/
Changes: https://reviews.apache.org/r/70913/diff/13-14/
Testing
-------
Added unit test
File Attachments (updated)
----------------
Hive Model with dynAttributes
https://reviews.apache.org/media/uploaded/files/2019/07/16/1f7bed33-0509-4aee-acbf-7ed1b0616c84__1030-hive_model.json
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 15, 2019, 11:09 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Forgot to change the variable at 1 place, fixed now.
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
Diff: https://reviews.apache.org/r/70913/diff/13/
Changes: https://reviews.apache.org/r/70913/diff/12-13/
Testing
-------
Added unit test
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 15, 2019, 11:06 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Renamed splitPath variable in DependentToken.java to objectPath
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
Diff: https://reviews.apache.org/r/70913/diff/12/
Changes: https://reviews.apache.org/r/70913/diff/11-12/
Testing
-------
Added unit test
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 15, 2019, 2:20 a.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
I fixed up some outdated tests that involved the hive_db only using the dbname as the qualifiedName. Also when the attribute required for the evaluation of a dynAttribute is not present, the attribute is not generated and it does not get set for that entity.
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java bf7e182429d00ca668cbbd41277291ecc5d457e0
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java edb45687712c7bb8941bc894e73423a463739a42
Diff: https://reviews.apache.org/r/70913/diff/11/
Changes: https://reviews.apache.org/r/70913/diff/10-11/
Testing
-------
Added unit test
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Aadarsh Jajodia <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216494
-----------------------------------------------------------
Ship it!
Looks good to me Merryle. Just a point to mention here, make sure to update the dependentToken class once we have more clarity on how to handle relationships
- Aadarsh Jajodia
On July 9, 2019, 11:55 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 9, 2019, 11:55 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
>
>
> Diff: https://reviews.apache.org/r/70913/diff/10/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
> On July 12, 2019, 3:06 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/AttributeToken.java
> > Lines 35 (patched)
> > <https://reviews.apache.org/r/70913/diff/10/?file=2154142#file2154142line35>
> >
> > UNKNOWN_ATTRIBUTE doesn't seem right error here. The attribute value is not prsent in the entity. I suggest to return null from here and have the caller deal with the desired action.
How should the caller deal with the null case. Should it just throw an error just like here?
> On July 12, 2019, 3:06 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/DependentToken.java
> > Lines 37 (patched)
> > <https://reviews.apache.org/r/70913/diff/10/?file=2154144#file2154144line37>
> >
> > Is the last entry the attrName? For example, consider token '{table.db.name}' for hive_column.qualifiedName. 'table' would be the attribute name, which is the first entry. Please review.
Well the structure I'm using is that, the last entry is the actual attribute--not for the hive_column--but for the db. While table is also an attributename, it's part of the sequence of relationship attributes to get to the final entity where we read its attribute.
- Merryle
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216543
-----------------------------------------------------------
On July 9, 2019, 11:55 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 9, 2019, 11:55 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
>
>
> Diff: https://reviews.apache.org/r/70913/diff/10/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Madhan Neethiraj <ma...@apache.org>.
> On July 12, 2019, 3:06 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/AttributeToken.java
> > Lines 35 (patched)
> > <https://reviews.apache.org/r/70913/diff/10/?file=2154142#file2154142line35>
> >
> > UNKNOWN_ATTRIBUTE doesn't seem right error here. The attribute value is not prsent in the entity. I suggest to return null from here and have the caller deal with the desired action.
>
> Merryle Wang wrote:
> How should the caller deal with the null case. Should it just throw an error just like here?
Few options:
1. set token value to empty string or 'null'
2. abort dynamic evaluation for this attribute, with a warn log, and set attribute value to null
I suggest we go with option #2.
> On July 12, 2019, 3:06 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/DependentToken.java
> > Lines 37 (patched)
> > <https://reviews.apache.org/r/70913/diff/10/?file=2154144#file2154144line37>
> >
> > Is the last entry the attrName? For example, consider token '{table.db.name}' for hive_column.qualifiedName. 'table' would be the attribute name, which is the first entry. Please review.
>
> Merryle Wang wrote:
> Well the structure I'm using is that, the last entry is the actual attribute--not for the hive_column--but for the db. While table is also an attributename, it's part of the sequence of relationship attributes to get to the final entity where we read its attribute.
ok. Given the context is 'hive_column' entity, I assumed attrName will be a relationship-attribute in 'hive_column' type - which will be used to find entity related via this attribute. Since that functionalty will be added only in a subsequent patch, it is probably not important in this patch.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216543
-----------------------------------------------------------
On July 9, 2019, 11:55 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 9, 2019, 11:55 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
>
>
> Diff: https://reviews.apache.org/r/70913/diff/10/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216543
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 754 (patched)
<https://reviews.apache.org/r/70913/#comment303755>
Consider simplifying with the following alternate:
StringBuilder token = new StringBuilder();
bool isInAttrName = false;
for (int i = 0; i < template.length(); i++) {
char c = template.charAt(i);
switch (c) {
case DYN_ATTRIBUTE_OPEN_DELIM: {
isInAttrName = true;
if (token.length() > 0) {
ret.add(new ConstantToken(token.toString());
token.setLength(0);
}
}
break;
case DYN_ATTRIBUTE_CLOSE_DELIM:
if (isInAttrName) {
isInAttrName = false;
if (token.length() > 0) {
String attrName = token.toString();
if (attrName.indexOf(DYN_ATTRIBUTE_NAME_SEPARATOR) != -1) {
ret.add(new DependentToken(token.toString()));
} else {
ret.add(new AttributeToken(token.toString());
}
token.setLength(0);
}
} else {
token.append(c);
}
break;
default:
token.append(c);
break;
}
}
intg/src/main/java/org/apache/atlas/type/AttributeToken.java
Lines 25 (patched)
<https://reviews.apache.org/r/70913/#comment303758>
Consider marking as 'final' as this member is not updated after initialization.
Same for members of ConstantToken and DependentToken.
intg/src/main/java/org/apache/atlas/type/AttributeToken.java
Lines 35 (patched)
<https://reviews.apache.org/r/70913/#comment303756>
UNKNOWN_ATTRIBUTE doesn't seem right error here. The attribute value is not prsent in the entity. I suggest to return null from here and have the caller deal with the desired action.
intg/src/main/java/org/apache/atlas/type/DependentToken.java
Lines 37 (patched)
<https://reviews.apache.org/r/70913/#comment303757>
Is the last entry the attrName? For example, consider token '{table.db.name}' for hive_column.qualifiedName. 'table' would be the attribute name, which is the first entry. Please review.
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
Lines 132 (patched)
<https://reviews.apache.org/r/70913/#comment303759>
- dynamicAttributeGenerator() => processDynanicAttributes()
- move 'private' method to end of the class, after all public methods.
- Madhan Neethiraj
On July 9, 2019, 11:55 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 9, 2019, 11:55 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
> intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
>
>
> Diff: https://reviews.apache.org/r/70913/diff/10/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 9, 2019, 11:55 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
The code now takes the hook generated dynAttribute if there isn't a template for a given Entity in the models file.
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
Diff: https://reviews.apache.org/r/70913/diff/10/
Changes: https://reviews.apache.org/r/70913/diff/9-10/
Testing
-------
Added unit test
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 9, 2019, 12:13 a.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Moved the tokens classes into the type directory and edited their functions as well. Added functionality to generate dynAttributes for entities whose templates only depend on themselves. Only Hive_db has a dynAttribute as of now.
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0fe47bdcbe84c06545c517fec3177ef7e6487a6c
intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 4ff4206471bb8b2b4997c00dca3b4433626ae392
Diff: https://reviews.apache.org/r/70913/diff/9/
Changes: https://reviews.apache.org/r/70913/diff/8-9/
Testing
-------
Added unit test
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Merryle Wang via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
-----------------------------------------------------------
(Updated July 3, 2019, 12:13 a.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Added 1 interface and 3 subclasses to keep track of the type of each part of the template. The classes can either be constant, an attribute, or one that's dependent on it's relationship attributes. I changed also the logic in AtlasEntityType because saving the split parts of the template simplifies the code in AtlasEntityType.
Repository: atlas
Description
-------
ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
Diffs (updated)
-----
addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
intg/src/main/java/org/apache/atlas/model/AttributeToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/ConstantToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/DependentToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/model/TemplateToken.java PRE-CREATION
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 254eee4c9d18ab87a8862ce479fc2274227c7c29
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
Diff: https://reviews.apache.org/r/70913/diff/8/
Changes: https://reviews.apache.org/r/70913/diff/7-8/
Testing
-------
Added unit test
Thanks,
Merryle Wang
Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute
flags for AtlasAttributes
Posted by Le Ma <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216285
-----------------------------------------------------------
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java
Lines 168 (patched)
<https://reviews.apache.org/r/70913/#comment303430>
Please make sure you've run pre-commit job before committing the code.
- Le Ma
On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 6:10 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
>
>
> Diffs
> -----
>
> addons/models/1000-Hadoop/1030-hive_model.json 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d9ae9e36773146fad652a1e28fc8822bae5c8557
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 254eee4c9d18ab87a8862ce479fc2274227c7c29
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02b48747515217c9327c98209a48ee84237
>
>
> Diff: https://reviews.apache.org/r/70913/diff/7/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Merryle Wang
>
>