[GitHub] [incubator-doris] chaoyli commented on a change in pull request #933: Optimize rowset usage

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #933: Optimize rowset usage
URL: https://github.com/apache/incubator-doris/pull/933#discussion_r275714513
 
 

 ##########
 File path: be/src/olap/storage_engine.cpp
 ##########
 @@ -677,17 +675,19 @@ OLAPStatus StorageEngine::_do_sweep(
 
 void StorageEngine::start_delete_unused_rowset() {
     _gc_mutex.lock();
-
-    auto it = _unused_rowsets.begin();
-    for (; it != _unused_rowsets.end();) { 
-        if (it->second->in_use()) {
+    LOG(INFO) << "start to delete unused rowset.";
 
 Review comment:
   Log is non-sense when has no unused rowset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org