You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by joshvote <no...@github.com> on 2013/09/10 10:32:41 UTC
[jclouds] Made Image descriptions nullable (#146)
org.jclouds.compute.domain.Image has "name" and "description" properties. "name" is Nullable but "description" isn't. This seems to be a little inconsistent, why should an Image description String be so strict about its contents if the name is completely ambivalent?
While this seems to be a pretty trivial matter the "openstack-nova" provider has no concept of an Image description, only a name. This is worked around by assigning the "openstack-nova" name to both the JClouds Image name and description. I'm experiencing an issue when the "openstack-nova" has a null name and tries to assign it to the currently NOT nullable description.
I hope this makes sense :)
You can merge this Pull Request by running:
git pull https://github.com/joshvote/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/146
-- Commit Summary --
* Made the description in org.jclouds.compute.domain.Image nullable
-- File Changes --
M compute/src/main/java/org/jclouds/compute/domain/Image.java (2)
M compute/src/main/java/org/jclouds/compute/domain/ImageBuilder.java (4)
M compute/src/main/java/org/jclouds/compute/domain/internal/ImageImpl.java (4)
A compute/src/test/java/org/jclouds/compute/domain/ImageBuilderTest.java (42)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/146.patch
https://github.com/jclouds/jclouds/pull/146.diff
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;h=1fc5806). Thanks, @joshvote!
@everett-toews, @abayer: do we want to apply this to 1.6.x also?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24494223
Re: [jclouds] Made Image descriptions nullable (#146)
Posted by Everett Toews <no...@github.com>.
The reasoning is certainly sound.
@abayer recently worked on adding an image extension for CloudStack https://issues.apache.org/jira/browse/JCLOUDS-138 We should get his opinion here too.
@joshvote Can you please copy the description of this PR into a JIRA issue, remove the description here, and replace it with a link to the JIRA issue?
I've added you to the jclouds Contributors list in JIRA so you'll have more permissions there.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24171915
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #684](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/684/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24487031
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by Andrew Bayer <no...@github.com>.
Should be fine, yeah.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24479812
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #223](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/223/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24486996
Re: [jclouds] Made Image descriptions nullable (#146)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #670](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/670/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24144700
Re: [jclouds] Made Image descriptions nullable (#146)
Posted by Andrew Phillips <no...@github.com>.
Change itself looks good to me. @zack-shoylev @everett-toews Any comments about how this affects the domain model?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24145831
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by Andrew Phillips <no...@github.com>.
> Sure
Also committed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;a=commit;h=d6bb789efb29e411c58d7f9c099260009c32f163)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24518969
Re: [jclouds] Made Image descriptions nullable (#146)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #209](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/209/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24144800
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by Andrew Phillips <no...@github.com>.
@everett-toews: Looks like the issue changes have been made.
@abayer: You good to go on this one?
The only thing we would need to address for the merge is to change the commit message to start with `JCLOUDS-277:`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24473997
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #224](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/224/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24487062
Re: [jclouds] JCLOUDS-277 - Made Image descriptions nullable (#146)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #685](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/685/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/146#issuecomment-24487092