[GitHub] [flink-kubernetes-operator] wangyang0918 edited a comment on pull request #1: [FLINK-26078] Kubernetes Operator Prototype

[GitBox <gi...@apache.org>]

wangyang0918 edited a comment on pull request #1:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1#issuecomment-1040188011


   > @wangyang0918 The problem with `flink-kubernetes` is that it is not a proper maven dependency but we release a fatjar, this means we cannot really exclude the fabric8 from it because its simply part of the jar.
   > 
   > This is something we should resolve on the Flink side because it doesnt make too much sense the way it is now. What we could do as a temporary workaround is that we repackage it in a new module and remove / relocate the shaded classes so that it does not conflict with the proper fabric8 deps accidentally
   
   @gyfora You are right. The overlapping classes issue need to be fixed in the upstream project Flink. I just remember kubernetes client won't work normally if we shaded `io.fabric8` classes. I am also not sure whether the kubernetes client could work with different `jackson` `okhttp3` `okio` dependencies. That's why `flink-kubernetes` is compiled to a fat jar.
   
   Anyway, this is not a blocker for the this PR to be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org