[GitHub] [solr] janhoy commented on a diff in pull request #1419: Update io.prometheus:* to v0.16.0

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on code in PR #1419:
URL: https://github.com/apache/solr/pull/1419#discussion_r1122420058


##########
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java:
##########
@@ -58,7 +58,7 @@ public void solrExporterDurationMetric() throws Exception {
     assertTrue(durationHistogram.get("solr_exporter_duration_seconds_sum") > 0);
 
     // 17 = (15 buckets in the histogram) + (count metric) + (sum metric)
-    assertEquals(17, durationHistogram.size());
+    assertEquals(18, durationHistogram.size());

Review Comment:
   I have no idea why this histogram has one more entry, anyone familiar with this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org