You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by Tibor Digana <ti...@apache.org> on 2020/05/03 21:44:29 UTC

[VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Hi,

We solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1572/
https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip

Source release checksum(s):

surefire-2.22.3-source-release.zip sha512::
c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
surefire-2.22.3-source-release.zip sha1:
2db957105d2929911927482c8d2198bd6ef718a7


Staging site:
N/A - we do not want to override new site with old versions 2.22.x

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

-- 
Cheers
Tibor

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Christian Stein <so...@gmail.com>.

On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Le lun. 4 mai 2020 à 17:06, Stephane Nicoll <st...@gmail.com> a
> écrit :
>
> > Thanks but that doesn't really answer my question. That version is picked
> > up by dependency management of the project as far as I can tell. If a
> > project does provide an older junit engine version the build will break.
> >
> > If you meant to "force" a single version then I'd argue that you
> shouldn't
> > resolve the one provided in dependency management for the project. I also
> > find this change quite suspicious in a maintenance release.
> >
> >
> Long story short the first jupiter integration contributed by junit team
> was supporting a single version.
> This is what is in 2.x of surefire.
> This maintenance release just upgraded the version as requested in a ticket
> IIRC but didn't change the way it is loaded (which is done on master).
>
>
As the author of the commit in question, I checked the compatibility with
all latest JUnit Platform dot-releases (1.0.3 to 1.6.1) here: [0] -- with
simple
projects that e.g. don't require Spring Boot or any other library/framework.

To me, those successful checks made be think, that this internal detail,
the JUnit Platform version Surefire runs on, would not impact external
projects.

Having said that, if we don't find a working solution (including a new
test-case) for most parties involved, I'm open to revert that change
and let only the SB-found-and-fixed commit ship with Surefire 2.22.3.

Cheers,
Christian


[0]:
https://github.com/apache/maven-surefire/blob/7d5cbc230b181f83b24c8cb669d45c20ffbdcb2f/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java#L59-L65

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Tibor Digana <ti...@apache.org>.

I wanted to copy paste that part of AbstractSurefireMojo which solves
this problem in this release but i was too lazy to do it.
I can do it and we can collaborate on the GitHub in a pullrequest -
the resolver's call will be different, that's the only thing, but
doable.
The code is more simple now, see this PR
https://github.com/apache/maven-surefire/pull/290 and it has more
features than before, so the users would be happy I would say.

On Tue, May 5, 2020 at 9:52 AM Stephane Nicoll
<st...@gmail.com> wrote:
>
> I don't see releasing Surefire 3.0 as fixing this problem. Users having an
> upgrade policy in place would still not be able to upgrade to 3.0 anyway.
> We are talking about a backward incompatible change in a maintenance
> release of the Surefire plugin. As much as I welcome 3.0 to be GA, that
> won't change anything to what we're discussing here IMO.
>
> Cheers,
> S.
>
>
> On Tue, May 5, 2020 at 8:07 AM Enrico Olivelli <eo...@gmail.com> wrote:
>
> > I would go with option 'release surefire 3.0.0'
> >
> >
> > Enrico
> >
> > Il Mar 5 Mag 2020, 07:59 Romain Manni-Bucau <rm...@gmail.com> ha
> > scritto:
> >
> > > Hmm, this particular one is quite hard cause (from my window which is not
> > > 100% of users indeed) I see more users willing 1.6 (actually I should
> > > phrase it "upgrade to last junit5 when upgrading surefire") than other
> > > cases.
> > > Concretely, older versions will not upgrade surefire generally.
> > > I think we are "just" in a case where you encounter a bug with a release
> > > policy preventing to go to 3.x and this is why you want this particular
> > > case.
> > > Anyone has another view of users? (point being: if we downgrade and break
> > > all users not using spring boot parent we are exactly at the same point
> > so
> > > let's try to avoid that).
> > >
> > > So question for me is:
> > >
> > > 1. Do we stick to that strategy and if so which version do we pick for
> > > 2.22.x and do we freeze this version?
> > > 1.a. junit 5.6
> > > 1.b. junit 5.3
> > > 1.c junit 5.5 (aka spring-boot current one AFAIK)
> > > 2. Do we backport 3.x strategy (or an enhanced flavor we do in 3.x and
> > > 2.22.x)?
> > > 3. Do we (just) document junit-platform* must be explicitly set in
> > project
> > > dependencies for 2.22? (side note there: doc/website of 2.22 seems no
> > more
> > > directly accessible online, is it intended since here the config is
> > > different?)
> > > 4. Do we just do a 3.0.0? (M4 is proven quite stable now so we could
> > > mitigate coming changes which are not testing provider related I think)
> > >
> > > I'd be for 1 (whatever version works) or 3 since it is the least
> > investment
> > > very short term and enables to go with 4 as soon as ready.
> > >
> > > Hope it makes sense.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le lun. 4 mai 2020 à 20:42, Stephane Nicoll <st...@gmail.com>
> > a
> > > écrit :
> > >
> > > > OK. With that in mind, I think the surefire plugin shouldn't require a
> > > > newer version of JUnit in a maintenance release that way. I understand
> > > it's
> > > > fixed and can lead to problem anyway but there will be less problems if
> > > you
> > > > rely on an older version and backward compatiblity if a newer version
> > is
> > > > around. I think we need to weigh what that change brings vs. the impact
> > > on
> > > > existing users upgrading to 2.22.3
> > > >
> > > > On Mon, May 4, 2020 at 7:36 PM Romain Manni-Bucau <
> > rmannibucau@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Yes but with transitive game it is not well positionned in the
> > > classpath
> > > > > (once again not saying it is "right", just the way it was done
> > > > originally)
> > > > > and surefire provider dependencies win so it must be redefined to be
> > > used
> > > > > in 2.x.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > > <
> > > > >
> > > >
> > >
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > > >
> > > > > Le lun. 4 mai 2020 à 18:52, Christian Stein <so...@gmail.com> a
> > > > écrit :
> > > > >
> > > > > > On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <
> > > > rmannibucau@gmail.com
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <
> > > > stephane.nicoll@gmail.com
> > > > > >
> > > > > > a
> > > > > > > écrit :
> > > > > > >
> > > > > > > ...
> > > > > >
> > > > > > > OK. Why is our build failing with that error if we're importing
> > the
> > > > > JUnit
> > > > > > > > 5.5.2 bom and it does not fail if we're importing the JUnit
> > 5.6.2
> > > > > bom?
> > > > > > > Our
> > > > > > > > test dependencies have "junit-jupiter" in test scope which
> > brings
> > > > the
> > > > > > > > engine.
> > > > > > > >
> > > > > > > > That looks like Surefire is using the user version to me.
> > Anyway,
> > > > if
> > > > > it
> > > > > > > > wasn't we wouldn't have the error above, wouldn't we?
> > > > > > > >
> > > > > > >
> > > > > > > AFAIK you don't import junit-platform-launcher in 1.5.2 so it
> > > fails.
> > > > > > > So surefire uses user version but misses one dep which takes in
> > its
> > > > own
> > > > > > > pom.
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom
> > > > > >
> > > > > >
> > > > > > contains
> > > > > >
> > > > > > <dependency>
> > > > > > <groupId>org.junit.platform</groupId>
> > > > > > <artifactId>junit-platform-launcher</artifactId>
> > > > > > <version>1.5.2</version>
> > > > > > </dependency>
> > > > > >
> > > > >
> > > >
> > >
> >



-- 
Cheers
Tibor

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Stephane Nicoll <st...@gmail.com>.

I don't see releasing Surefire 3.0 as fixing this problem. Users having an
upgrade policy in place would still not be able to upgrade to 3.0 anyway.
We are talking about a backward incompatible change in a maintenance
release of the Surefire plugin. As much as I welcome 3.0 to be GA, that
won't change anything to what we're discussing here IMO.

Cheers,
S.


On Tue, May 5, 2020 at 8:07 AM Enrico Olivelli <eo...@gmail.com> wrote:

> I would go with option 'release surefire 3.0.0'
>
>
> Enrico
>
> Il Mar 5 Mag 2020, 07:59 Romain Manni-Bucau <rm...@gmail.com> ha
> scritto:
>
> > Hmm, this particular one is quite hard cause (from my window which is not
> > 100% of users indeed) I see more users willing 1.6 (actually I should
> > phrase it "upgrade to last junit5 when upgrading surefire") than other
> > cases.
> > Concretely, older versions will not upgrade surefire generally.
> > I think we are "just" in a case where you encounter a bug with a release
> > policy preventing to go to 3.x and this is why you want this particular
> > case.
> > Anyone has another view of users? (point being: if we downgrade and break
> > all users not using spring boot parent we are exactly at the same point
> so
> > let's try to avoid that).
> >
> > So question for me is:
> >
> > 1. Do we stick to that strategy and if so which version do we pick for
> > 2.22.x and do we freeze this version?
> > 1.a. junit 5.6
> > 1.b. junit 5.3
> > 1.c junit 5.5 (aka spring-boot current one AFAIK)
> > 2. Do we backport 3.x strategy (or an enhanced flavor we do in 3.x and
> > 2.22.x)?
> > 3. Do we (just) document junit-platform* must be explicitly set in
> project
> > dependencies for 2.22? (side note there: doc/website of 2.22 seems no
> more
> > directly accessible online, is it intended since here the config is
> > different?)
> > 4. Do we just do a 3.0.0? (M4 is proven quite stable now so we could
> > mitigate coming changes which are not testing provider related I think)
> >
> > I'd be for 1 (whatever version works) or 3 since it is the least
> investment
> > very short term and enables to go with 4 as soon as ready.
> >
> > Hope it makes sense.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le lun. 4 mai 2020 à 20:42, Stephane Nicoll <st...@gmail.com>
> a
> > écrit :
> >
> > > OK. With that in mind, I think the surefire plugin shouldn't require a
> > > newer version of JUnit in a maintenance release that way. I understand
> > it's
> > > fixed and can lead to problem anyway but there will be less problems if
> > you
> > > rely on an older version and backward compatiblity if a newer version
> is
> > > around. I think we need to weigh what that change brings vs. the impact
> > on
> > > existing users upgrading to 2.22.3
> > >
> > > On Mon, May 4, 2020 at 7:36 PM Romain Manni-Bucau <
> rmannibucau@gmail.com
> > >
> > > wrote:
> > >
> > > > Yes but with transitive game it is not well positionned in the
> > classpath
> > > > (once again not saying it is "right", just the way it was done
> > > originally)
> > > > and surefire provider dependencies win so it must be redefined to be
> > used
> > > > in 2.x.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le lun. 4 mai 2020 à 18:52, Christian Stein <so...@gmail.com> a
> > > écrit :
> > > >
> > > > > On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <
> > > rmannibucau@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <
> > > stephane.nicoll@gmail.com
> > > > >
> > > > > a
> > > > > > écrit :
> > > > > >
> > > > > > ...
> > > > >
> > > > > > OK. Why is our build failing with that error if we're importing
> the
> > > > JUnit
> > > > > > > 5.5.2 bom and it does not fail if we're importing the JUnit
> 5.6.2
> > > > bom?
> > > > > > Our
> > > > > > > test dependencies have "junit-jupiter" in test scope which
> brings
> > > the
> > > > > > > engine.
> > > > > > >
> > > > > > > That looks like Surefire is using the user version to me.
> Anyway,
> > > if
> > > > it
> > > > > > > wasn't we wouldn't have the error above, wouldn't we?
> > > > > > >
> > > > > >
> > > > > > AFAIK you don't import junit-platform-launcher in 1.5.2 so it
> > fails.
> > > > > > So surefire uses user version but misses one dep which takes in
> its
> > > own
> > > > > > pom.
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom
> > > > >
> > > > >
> > > > > contains
> > > > >
> > > > > <dependency>
> > > > > <groupId>org.junit.platform</groupId>
> > > > > <artifactId>junit-platform-launcher</artifactId>
> > > > > <version>1.5.2</version>
> > > > > </dependency>
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Tibor Digana <ti...@apache.org>.

I would go to the original question. How important is the issue [1]
for the user?
If it is not important, then we can cut the release with one fix SUREFIRE-1679.

If it is important, which does not seem so yet, then we can backport
smart resolver from the master.
Technically possible!

[1]: https://github.com/junit-team/junit5/issues/1909

On Tue, May 5, 2020 at 8:07 AM Enrico Olivelli <eo...@gmail.com> wrote:
>
> I would go with option 'release surefire 3.0.0'
>
>
> Enrico
>
> Il Mar 5 Mag 2020, 07:59 Romain Manni-Bucau <rm...@gmail.com> ha
> scritto:
>
> > Hmm, this particular one is quite hard cause (from my window which is not
> > 100% of users indeed) I see more users willing 1.6 (actually I should
> > phrase it "upgrade to last junit5 when upgrading surefire") than other
> > cases.
> > Concretely, older versions will not upgrade surefire generally.
> > I think we are "just" in a case where you encounter a bug with a release
> > policy preventing to go to 3.x and this is why you want this particular
> > case.
> > Anyone has another view of users? (point being: if we downgrade and break
> > all users not using spring boot parent we are exactly at the same point so
> > let's try to avoid that).
> >
> > So question for me is:
> >
> > 1. Do we stick to that strategy and if so which version do we pick for
> > 2.22.x and do we freeze this version?
> > 1.a. junit 5.6
> > 1.b. junit 5.3
> > 1.c junit 5.5 (aka spring-boot current one AFAIK)
> > 2. Do we backport 3.x strategy (or an enhanced flavor we do in 3.x and
> > 2.22.x)?
> > 3. Do we (just) document junit-platform* must be explicitly set in project
> > dependencies for 2.22? (side note there: doc/website of 2.22 seems no more
> > directly accessible online, is it intended since here the config is
> > different?)
> > 4. Do we just do a 3.0.0? (M4 is proven quite stable now so we could
> > mitigate coming changes which are not testing provider related I think)
> >
> > I'd be for 1 (whatever version works) or 3 since it is the least investment
> > very short term and enables to go with 4 as soon as ready.
> >
> > Hope it makes sense.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le lun. 4 mai 2020 à 20:42, Stephane Nicoll <st...@gmail.com> a
> > écrit :
> >
> > > OK. With that in mind, I think the surefire plugin shouldn't require a
> > > newer version of JUnit in a maintenance release that way. I understand
> > it's
> > > fixed and can lead to problem anyway but there will be less problems if
> > you
> > > rely on an older version and backward compatiblity if a newer version is
> > > around. I think we need to weigh what that change brings vs. the impact
> > on
> > > existing users upgrading to 2.22.3
> > >
> > > On Mon, May 4, 2020 at 7:36 PM Romain Manni-Bucau <rmannibucau@gmail.com
> > >
> > > wrote:
> > >
> > > > Yes but with transitive game it is not well positionned in the
> > classpath
> > > > (once again not saying it is "right", just the way it was done
> > > originally)
> > > > and surefire provider dependencies win so it must be redefined to be
> > used
> > > > in 2.x.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > <
> > > >
> > >
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le lun. 4 mai 2020 à 18:52, Christian Stein <so...@gmail.com> a
> > > écrit :
> > > >
> > > > > On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <
> > > rmannibucau@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <
> > > stephane.nicoll@gmail.com
> > > > >
> > > > > a
> > > > > > écrit :
> > > > > >
> > > > > > ...
> > > > >
> > > > > > OK. Why is our build failing with that error if we're importing the
> > > > JUnit
> > > > > > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2
> > > > bom?
> > > > > > Our
> > > > > > > test dependencies have "junit-jupiter" in test scope which brings
> > > the
> > > > > > > engine.
> > > > > > >
> > > > > > > That looks like Surefire is using the user version to me. Anyway,
> > > if
> > > > it
> > > > > > > wasn't we wouldn't have the error above, wouldn't we?
> > > > > > >
> > > > > >
> > > > > > AFAIK you don't import junit-platform-launcher in 1.5.2 so it
> > fails.
> > > > > > So surefire uses user version but misses one dep which takes in its
> > > own
> > > > > > pom.
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> > https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom
> > > > >
> > > > >
> > > > > contains
> > > > >
> > > > > <dependency>
> > > > > <groupId>org.junit.platform</groupId>
> > > > > <artifactId>junit-platform-launcher</artifactId>
> > > > > <version>1.5.2</version>
> > > > > </dependency>
> > > > >
> > > >
> > >
> >



-- 
Cheers
Tibor

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Enrico Olivelli <eo...@gmail.com>.

I would go with option 'release surefire 3.0.0'


Enrico

Il Mar 5 Mag 2020, 07:59 Romain Manni-Bucau <rm...@gmail.com> ha
scritto:

> Hmm, this particular one is quite hard cause (from my window which is not
> 100% of users indeed) I see more users willing 1.6 (actually I should
> phrase it "upgrade to last junit5 when upgrading surefire") than other
> cases.
> Concretely, older versions will not upgrade surefire generally.
> I think we are "just" in a case where you encounter a bug with a release
> policy preventing to go to 3.x and this is why you want this particular
> case.
> Anyone has another view of users? (point being: if we downgrade and break
> all users not using spring boot parent we are exactly at the same point so
> let's try to avoid that).
>
> So question for me is:
>
> 1. Do we stick to that strategy and if so which version do we pick for
> 2.22.x and do we freeze this version?
> 1.a. junit 5.6
> 1.b. junit 5.3
> 1.c junit 5.5 (aka spring-boot current one AFAIK)
> 2. Do we backport 3.x strategy (or an enhanced flavor we do in 3.x and
> 2.22.x)?
> 3. Do we (just) document junit-platform* must be explicitly set in project
> dependencies for 2.22? (side note there: doc/website of 2.22 seems no more
> directly accessible online, is it intended since here the config is
> different?)
> 4. Do we just do a 3.0.0? (M4 is proven quite stable now so we could
> mitigate coming changes which are not testing provider related I think)
>
> I'd be for 1 (whatever version works) or 3 since it is the least investment
> very short term and enables to go with 4 as soon as ready.
>
> Hope it makes sense.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 4 mai 2020 à 20:42, Stephane Nicoll <st...@gmail.com> a
> écrit :
>
> > OK. With that in mind, I think the surefire plugin shouldn't require a
> > newer version of JUnit in a maintenance release that way. I understand
> it's
> > fixed and can lead to problem anyway but there will be less problems if
> you
> > rely on an older version and backward compatiblity if a newer version is
> > around. I think we need to weigh what that change brings vs. the impact
> on
> > existing users upgrading to 2.22.3
> >
> > On Mon, May 4, 2020 at 7:36 PM Romain Manni-Bucau <rmannibucau@gmail.com
> >
> > wrote:
> >
> > > Yes but with transitive game it is not well positionned in the
> classpath
> > > (once again not saying it is "right", just the way it was done
> > originally)
> > > and surefire provider dependencies win so it must be redefined to be
> used
> > > in 2.x.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le lun. 4 mai 2020 à 18:52, Christian Stein <so...@gmail.com> a
> > écrit :
> > >
> > > > On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <
> > rmannibucau@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <
> > stephane.nicoll@gmail.com
> > > >
> > > > a
> > > > > écrit :
> > > > >
> > > > > ...
> > > >
> > > > > OK. Why is our build failing with that error if we're importing the
> > > JUnit
> > > > > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2
> > > bom?
> > > > > Our
> > > > > > test dependencies have "junit-jupiter" in test scope which brings
> > the
> > > > > > engine.
> > > > > >
> > > > > > That looks like Surefire is using the user version to me. Anyway,
> > if
> > > it
> > > > > > wasn't we wouldn't have the error above, wouldn't we?
> > > > > >
> > > > >
> > > > > AFAIK you don't import junit-platform-launcher in 1.5.2 so it
> fails.
> > > > > So surefire uses user version but misses one dep which takes in its
> > own
> > > > > pom.
> > > > >
> > > > >
> > > >
> > > >
> > >
> >
> https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom
> > > >
> > > >
> > > > contains
> > > >
> > > > <dependency>
> > > > <groupId>org.junit.platform</groupId>
> > > > <artifactId>junit-platform-launcher</artifactId>
> > > > <version>1.5.2</version>
> > > > </dependency>
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Romain Manni-Bucau <rm...@gmail.com>.

Hmm, this particular one is quite hard cause (from my window which is not
100% of users indeed) I see more users willing 1.6 (actually I should
phrase it "upgrade to last junit5 when upgrading surefire") than other
cases.
Concretely, older versions will not upgrade surefire generally.
I think we are "just" in a case where you encounter a bug with a release
policy preventing to go to 3.x and this is why you want this particular
case.
Anyone has another view of users? (point being: if we downgrade and break
all users not using spring boot parent we are exactly at the same point so
let's try to avoid that).

So question for me is:

1. Do we stick to that strategy and if so which version do we pick for
2.22.x and do we freeze this version?
1.a. junit 5.6
1.b. junit 5.3
1.c junit 5.5 (aka spring-boot current one AFAIK)
2. Do we backport 3.x strategy (or an enhanced flavor we do in 3.x and
2.22.x)?
3. Do we (just) document junit-platform* must be explicitly set in project
dependencies for 2.22? (side note there: doc/website of 2.22 seems no more
directly accessible online, is it intended since here the config is
different?)
4. Do we just do a 3.0.0? (M4 is proven quite stable now so we could
mitigate coming changes which are not testing provider related I think)

I'd be for 1 (whatever version works) or 3 since it is the least investment
very short term and enables to go with 4 as soon as ready.

Hope it makes sense.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>

Le lun. 4 mai 2020 à 20:42, Stephane Nicoll <st...@gmail.com> a
écrit :

> OK. With that in mind, I think the surefire plugin shouldn't require a
> newer version of JUnit in a maintenance release that way. I understand it's
> fixed and can lead to problem anyway but there will be less problems if you
> rely on an older version and backward compatiblity if a newer version is
> around. I think we need to weigh what that change brings vs. the impact on
> existing users upgrading to 2.22.3
>
> On Mon, May 4, 2020 at 7:36 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Yes but with transitive game it is not well positionned in the classpath
> > (once again not saying it is "right", just the way it was done
> originally)
> > and surefire provider dependencies win so it must be redefined to be used
> > in 2.x.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le lun. 4 mai 2020 à 18:52, Christian Stein <so...@gmail.com> a
> écrit :
> >
> > > On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <
> rmannibucau@gmail.com
> > >
> > > wrote:
> > >
> > > > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <
> stephane.nicoll@gmail.com
> > >
> > > a
> > > > écrit :
> > > >
> > > > ...
> > >
> > > > OK. Why is our build failing with that error if we're importing the
> > JUnit
> > > > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2
> > bom?
> > > > Our
> > > > > test dependencies have "junit-jupiter" in test scope which brings
> the
> > > > > engine.
> > > > >
> > > > > That looks like Surefire is using the user version to me. Anyway,
> if
> > it
> > > > > wasn't we wouldn't have the error above, wouldn't we?
> > > > >
> > > >
> > > > AFAIK you don't import junit-platform-launcher in 1.5.2 so it fails.
> > > > So surefire uses user version but misses one dep which takes in its
> own
> > > > pom.
> > > >
> > > >
> > >
> > >
> >
> https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom
> > >
> > >
> > > contains
> > >
> > > <dependency>
> > > <groupId>org.junit.platform</groupId>
> > > <artifactId>junit-platform-launcher</artifactId>
> > > <version>1.5.2</version>
> > > </dependency>
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Stephane Nicoll <st...@gmail.com>.

OK. With that in mind, I think the surefire plugin shouldn't require a
newer version of JUnit in a maintenance release that way. I understand it's
fixed and can lead to problem anyway but there will be less problems if you
rely on an older version and backward compatiblity if a newer version is
around. I think we need to weigh what that change brings vs. the impact on
existing users upgrading to 2.22.3

On Mon, May 4, 2020 at 7:36 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Yes but with transitive game it is not well positionned in the classpath
> (once again not saying it is "right", just the way it was done originally)
> and surefire provider dependencies win so it must be redefined to be used
> in 2.x.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 4 mai 2020 à 18:52, Christian Stein <so...@gmail.com> a écrit :
>
> > On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <rmannibucau@gmail.com
> >
> > wrote:
> >
> > > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <stephane.nicoll@gmail.com
> >
> > a
> > > écrit :
> > >
> > > ...
> >
> > > OK. Why is our build failing with that error if we're importing the
> JUnit
> > > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2
> bom?
> > > Our
> > > > test dependencies have "junit-jupiter" in test scope which brings the
> > > > engine.
> > > >
> > > > That looks like Surefire is using the user version to me. Anyway, if
> it
> > > > wasn't we wouldn't have the error above, wouldn't we?
> > > >
> > >
> > > AFAIK you don't import junit-platform-launcher in 1.5.2 so it fails.
> > > So surefire uses user version but misses one dep which takes in its own
> > > pom.
> > >
> > >
> >
> >
> https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom
> >
> >
> > contains
> >
> > <dependency>
> > <groupId>org.junit.platform</groupId>
> > <artifactId>junit-platform-launcher</artifactId>
> > <version>1.5.2</version>
> > </dependency>
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Romain Manni-Bucau <rm...@gmail.com>.

Yes but with transitive game it is not well positionned in the classpath
(once again not saying it is "right", just the way it was done originally)
and surefire provider dependencies win so it must be redefined to be used
in 2.x.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 4 mai 2020 à 18:52, Christian Stein <so...@gmail.com> a écrit :

> On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <st...@gmail.com>
> a
> > écrit :
> >
> > ...
>
> > OK. Why is our build failing with that error if we're importing the JUnit
> > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2 bom?
> > Our
> > > test dependencies have "junit-jupiter" in test scope which brings the
> > > engine.
> > >
> > > That looks like Surefire is using the user version to me. Anyway, if it
> > > wasn't we wouldn't have the error above, wouldn't we?
> > >
> >
> > AFAIK you don't import junit-platform-launcher in 1.5.2 so it fails.
> > So surefire uses user version but misses one dep which takes in its own
> > pom.
> >
> >
>
> https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom
>
>
> contains
>
> <dependency>
> <groupId>org.junit.platform</groupId>
> <artifactId>junit-platform-launcher</artifactId>
> <version>1.5.2</version>
> </dependency>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Christian Stein <so...@gmail.com>.

On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <st...@gmail.com> a
> écrit :
>
> ...

> OK. Why is our build failing with that error if we're importing the JUnit
> > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2 bom?
> Our
> > test dependencies have "junit-jupiter" in test scope which brings the
> > engine.
> >
> > That looks like Surefire is using the user version to me. Anyway, if it
> > wasn't we wouldn't have the error above, wouldn't we?
> >
>
> AFAIK you don't import junit-platform-launcher in 1.5.2 so it fails.
> So surefire uses user version but misses one dep which takes in its own
> pom.
>
>
https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom


contains

<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-launcher</artifactId>
<version>1.5.2</version>
</dependency>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Romain Manni-Bucau <rm...@gmail.com>.

Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <st...@gmail.com> a
écrit :

> On Mon, May 4, 2020 at 5:55 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Le lun. 4 mai 2020 à 17:23, Stephane Nicoll <st...@gmail.com>
> a
> > écrit :
> >
> > > On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau <
> rmannibucau@gmail.com
> > >
> > > wrote:
> > >
> > > > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll <
> stephane.nicoll@gmail.com
> > >
> > > a
> > > > écrit :
> > > >
> > > > > Thanks but that doesn't really answer my question. That version is
> > > picked
> > > > > up by dependency management of the project as far as I can tell.
> If a
> > > > > project does provide an older junit engine version the build will
> > > break.
> > > > >
> > > > > If you meant to "force" a single version then I'd argue that you
> > > > shouldn't
> > > > > resolve the one provided in dependency management for the project.
> I
> > > also
> > > > > find this change quite suspicious in a maintenance release.
> > > > >
> > > > >
> > > > Long story short the first jupiter integration contributed by junit
> > team
> > > > was supporting a single version.
> > > > This is what is in 2.x of surefire.
> > > > This maintenance release just upgraded the version as requested in a
> > > ticket
> > > > IIRC but didn't change the way it is loaded (which is done on
> master).
> > > >
> > >
> > > It is changing things in a non backward compatible way as you are now
> > > required to use  a more recent JUnit version in a maintenance release
> of
> > > the plugin. And given that the plugin loads the version from dependency
> > > management, you are not forcing the version that you require. If the
> > > project uses the junit bom (as it should be) and it does not match the
> > > requirement, the build fails with a NoClassDefFoundError. Surely that
> > can't
> > > be right?
> > >
> >
> > I - and all I guess - agree with you that this implementation is not the
> > expected one from an user perspective, this is why it got fixed on 3.x,
> > but it didn't change in 2.x, only the supported version and we likely
> > missed 1.5/1.6.1 were not compatible (think spring is using 1.6.0 btw).
> > Using user version was not a feature and is still not in 2.x.
> >
>
>
> OK. Why is our build failing with that error if we're importing the JUnit
> 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2 bom? Our
> test dependencies have "junit-jupiter" in test scope which brings the
> engine.
>
> That looks like Surefire is using the user version to me. Anyway, if it
> wasn't we wouldn't have the error above, wouldn't we?
>

AFAIK you don't import junit-platform-launcher in 1.5.2 so it fails.
So surefire uses user version but misses one dep which takes in its own pom.


>
>
>
> >
> >
> > >
> > > Just to make sure I understood your point. You are OK if users
> upgrading
> > to
> > > a maintenance release of this plugin are also forced to upgrade the
> JUnit
> > > version they are using? This is going to break pretty much all Spring
> > Boot
> > > users in 2.2.x as our policy is not upgrade to a new feature release of
> > > JUnit in a maintenance release of Spring Boot.
> > >
> >
> > Not exactly, I'm saying that it was the compromise selected for this
> > release - once again we can revise it.
> >
> > The workaround for 2.x is to add the junit platform in the test
> > dependencies and I guess it is this one for several pre-3 versions
> (recall
> > having done it for 1.3):
> >
> > <dependency>
> >   <groupId>org.junit.platform</groupId>
> >   <artifactId>junit-platform-launcher</artifactId>
> >   <version>1.5.2</version>
> > </dependency>
> > <dependency>
> >   <groupId>org.junit.platform</groupId>
> >   <artifactId>junit-platform-engine</artifactId>
> >   <version>1.5.2</version>
> > </dependency>
> >
> >
> >
> >
> > >
> > > Suffice to say, I don't think we can upgrade to this plugin. Have I
> > missed
> > > something?
> > >
> >
> > Once again if you want to do a PR or even handle the dev/test/merge
> > lifecycle since you are a committer, it would be welcomed and I would be
> > happy to help you.
> > I just wanted to highlight there is no structural change there and the
> > downside of supporting a single version is still there and users wanting
> to
> > use 1.6 will have the opposite issue than yours.
> >
> > @Tibor: if you read these lines, how far are we to do a 3.0.0, it is
> proven
> > pretty stable and saw the tcp work almost done, maybe we should estimate
> > when we can make it out if we want to reduce the load on 2.x. Wdyt?
> >
> >
> > >
> > >
> > >
> > > >
> > > >
> > > > >
> > > > >
> > > > > On Mon, May 4, 2020 at 5:03 PM Romain Manni-Bucau <
> > > rmannibucau@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Stephane,
> > > > > >
> > > > > > AFAIK the choice with 2.22 maintenance for now was to keep using
> a
> > > > single
> > > > > > junit5 version as originally and if only support more flexibility
> > > with
> > > > > 3.x.
> > > > > > Think it makes sense for now but if you want to PR 2.22 to
> backport
> > > 3.x
> > > > > > work I guess it can be discussed too in another thread.
> > > > > >
> > > > > > Romain Manni-Bucau
> > > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > > https://github.com/rmannibucau> |
> > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > >
> > > > > >
> > > > > >
> > > > > > Le lun. 4 mai 2020 à 16:35, Stephane Nicoll <
> > > stephane.nicoll@gmail.com
> > > > >
> > > > > a
> > > > > > écrit :
> > > > > >
> > > > > > > An update. This may be the other fixed issue in that release
> > > actually
> > > > > > > (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What
> > happens
> > > > for
> > > > > > > projects that are using an older JUnit version?
> > > > > > >
> > > > > > > On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <
> > > > > > stephane.nicoll@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > I am not sure that SUREFIRE-1679 is fixed. I've ran the
> Spring
> > > Boot
> > > > > > build
> > > > > > > > with 2.22.2 and reproduced the error there. Upgrading to this
> > > > > candidate
> > > > > > > > release and I got this error.
> > > > > > > >
> > > > > > > > [ERROR] Failed to execute goal
> > > > > > > > org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test
> > > > > > (default-test)
> > > > > > > > on project spring-boot-configuration-metadata: There are test
> > > > > failures.
> > > > > > > > [ERROR]
> > > > > > > > [ERROR] Please refer to
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> > > > > > > > for the individual test results.
> > > > > > > > [ERROR] Please refer to dump files (if any exist)
> [date].dump,
> > > > > > > > [date]-jvmRun[N].dump and [date].dumpstream.
> > > > > > > > [ERROR] There was an error in the forked process
> > > > > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > > > > [ERROR]
> > > > org.apache.maven.surefire.booter.SurefireBooterForkException:
> > > > > > > > There was an error in the forked process
> > > > > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > > > > [ERROR] at
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> > > > > > > > [ERROR] at
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> > > > > > > > [ERROR] at
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> > > > > > > > [ERROR] at
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> > > > > > > > [ERROR] at
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> > > > > > > > [ERROR] at
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
> > > > > > > >
> > > > > > > > See
> > https://github.com/spring-projects/spring-boot/issues/19631
> > > > > > > >
> > > > > > > > On Sun, May 3, 2020 at 11:44 PM Tibor Digana <
> > > > tibordigana@apache.org
> > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > >> Hi,
> > > > > > > >>
> > > > > > > >> We solved 2 issues:
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> > > > > > > >>
> > > > > > > >> There are still a couple of issues left in JIRA:
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > > > > > > >>
> > > > > > > >> Staging repo:
> > > > > > > >>
> > https://repository.apache.org/content/repositories/maven-1572/
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> > > > > > > >>
> > > > > > > >> Source release checksum(s):
> > > > > > > >>
> > > > > > > >> surefire-2.22.3-source-release.zip sha512::
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> > > > > > > >> surefire-2.22.3-source-release.zip sha1:
> > > > > > > >> 2db957105d2929911927482c8d2198bd6ef718a7
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> Staging site:
> > > > > > > >> N/A - we do not want to override new site with old versions
> > > 2.22.x
> > > > > > > >>
> > > > > > > >> Guide to testing staged releases:
> > > > > > > >>
> > > > > >
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > > > > > > >>
> > > > > > > >> Vote open for 72 hours.
> > > > > > > >>
> > > > > > > >> [ ] +1
> > > > > > > >> [ ] +0
> > > > > > > >> [ ] -1
> > > > > > > >>
> > > > > > > >> --
> > > > > > > >> Cheers
> > > > > > > >> Tibor
> > > > > > > >>
> > > > > > > >>
> > > > >
> ---------------------------------------------------------------------
> > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Stephane Nicoll <st...@gmail.com>.

On Mon, May 4, 2020 at 5:55 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Le lun. 4 mai 2020 à 17:23, Stephane Nicoll <st...@gmail.com> a
> écrit :
>
> > On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau <rmannibucau@gmail.com
> >
> > wrote:
> >
> > > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll <stephane.nicoll@gmail.com
> >
> > a
> > > écrit :
> > >
> > > > Thanks but that doesn't really answer my question. That version is
> > picked
> > > > up by dependency management of the project as far as I can tell. If a
> > > > project does provide an older junit engine version the build will
> > break.
> > > >
> > > > If you meant to "force" a single version then I'd argue that you
> > > shouldn't
> > > > resolve the one provided in dependency management for the project. I
> > also
> > > > find this change quite suspicious in a maintenance release.
> > > >
> > > >
> > > Long story short the first jupiter integration contributed by junit
> team
> > > was supporting a single version.
> > > This is what is in 2.x of surefire.
> > > This maintenance release just upgraded the version as requested in a
> > ticket
> > > IIRC but didn't change the way it is loaded (which is done on master).
> > >
> >
> > It is changing things in a non backward compatible way as you are now
> > required to use  a more recent JUnit version in a maintenance release of
> > the plugin. And given that the plugin loads the version from dependency
> > management, you are not forcing the version that you require. If the
> > project uses the junit bom (as it should be) and it does not match the
> > requirement, the build fails with a NoClassDefFoundError. Surely that
> can't
> > be right?
> >
>
> I - and all I guess - agree with you that this implementation is not the
> expected one from an user perspective, this is why it got fixed on 3.x,
> but it didn't change in 2.x, only the supported version and we likely
> missed 1.5/1.6.1 were not compatible (think spring is using 1.6.0 btw).
> Using user version was not a feature and is still not in 2.x.
>


OK. Why is our build failing with that error if we're importing the JUnit
5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2 bom? Our
test dependencies have "junit-jupiter" in test scope which brings the
engine.

That looks like Surefire is using the user version to me. Anyway, if it
wasn't we wouldn't have the error above, wouldn't we?



>
>
> >
> > Just to make sure I understood your point. You are OK if users upgrading
> to
> > a maintenance release of this plugin are also forced to upgrade the JUnit
> > version they are using? This is going to break pretty much all Spring
> Boot
> > users in 2.2.x as our policy is not upgrade to a new feature release of
> > JUnit in a maintenance release of Spring Boot.
> >
>
> Not exactly, I'm saying that it was the compromise selected for this
> release - once again we can revise it.
>
> The workaround for 2.x is to add the junit platform in the test
> dependencies and I guess it is this one for several pre-3 versions (recall
> having done it for 1.3):
>
> <dependency>
>   <groupId>org.junit.platform</groupId>
>   <artifactId>junit-platform-launcher</artifactId>
>   <version>1.5.2</version>
> </dependency>
> <dependency>
>   <groupId>org.junit.platform</groupId>
>   <artifactId>junit-platform-engine</artifactId>
>   <version>1.5.2</version>
> </dependency>
>
>
>
>
> >
> > Suffice to say, I don't think we can upgrade to this plugin. Have I
> missed
> > something?
> >
>
> Once again if you want to do a PR or even handle the dev/test/merge
> lifecycle since you are a committer, it would be welcomed and I would be
> happy to help you.
> I just wanted to highlight there is no structural change there and the
> downside of supporting a single version is still there and users wanting to
> use 1.6 will have the opposite issue than yours.
>
> @Tibor: if you read these lines, how far are we to do a 3.0.0, it is proven
> pretty stable and saw the tcp work almost done, maybe we should estimate
> when we can make it out if we want to reduce the load on 2.x. Wdyt?
>
>
> >
> >
> >
> > >
> > >
> > > >
> > > >
> > > > On Mon, May 4, 2020 at 5:03 PM Romain Manni-Bucau <
> > rmannibucau@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi Stephane,
> > > > >
> > > > > AFAIK the choice with 2.22 maintenance for now was to keep using a
> > > single
> > > > > junit5 version as originally and if only support more flexibility
> > with
> > > > 3.x.
> > > > > Think it makes sense for now but if you want to PR 2.22 to backport
> > 3.x
> > > > > work I guess it can be discussed too in another thread.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > > <
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > > >
> > > > > Le lun. 4 mai 2020 à 16:35, Stephane Nicoll <
> > stephane.nicoll@gmail.com
> > > >
> > > > a
> > > > > écrit :
> > > > >
> > > > > > An update. This may be the other fixed issue in that release
> > actually
> > > > > > (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What
> happens
> > > for
> > > > > > projects that are using an older JUnit version?
> > > > > >
> > > > > > On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <
> > > > > stephane.nicoll@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring
> > Boot
> > > > > build
> > > > > > > with 2.22.2 and reproduced the error there. Upgrading to this
> > > > candidate
> > > > > > > release and I got this error.
> > > > > > >
> > > > > > > [ERROR] Failed to execute goal
> > > > > > > org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test
> > > > > (default-test)
> > > > > > > on project spring-boot-configuration-metadata: There are test
> > > > failures.
> > > > > > > [ERROR]
> > > > > > > [ERROR] Please refer to
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> > > > > > > for the individual test results.
> > > > > > > [ERROR] Please refer to dump files (if any exist) [date].dump,
> > > > > > > [date]-jvmRun[N].dump and [date].dumpstream.
> > > > > > > [ERROR] There was an error in the forked process
> > > > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > > > [ERROR]
> > > org.apache.maven.surefire.booter.SurefireBooterForkException:
> > > > > > > There was an error in the forked process
> > > > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > > > [ERROR] at
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> > > > > > > [ERROR] at
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> > > > > > > [ERROR] at
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> > > > > > > [ERROR] at
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> > > > > > > [ERROR] at
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> > > > > > > [ERROR] at
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
> > > > > > >
> > > > > > > See
> https://github.com/spring-projects/spring-boot/issues/19631
> > > > > > >
> > > > > > > On Sun, May 3, 2020 at 11:44 PM Tibor Digana <
> > > tibordigana@apache.org
> > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Hi,
> > > > > > >>
> > > > > > >> We solved 2 issues:
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> > > > > > >>
> > > > > > >> There are still a couple of issues left in JIRA:
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > > > > > >>
> > > > > > >> Staging repo:
> > > > > > >>
> https://repository.apache.org/content/repositories/maven-1572/
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> > > > > > >>
> > > > > > >> Source release checksum(s):
> > > > > > >>
> > > > > > >> surefire-2.22.3-source-release.zip sha512::
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> > > > > > >> surefire-2.22.3-source-release.zip sha1:
> > > > > > >> 2db957105d2929911927482c8d2198bd6ef718a7
> > > > > > >>
> > > > > > >>
> > > > > > >> Staging site:
> > > > > > >> N/A - we do not want to override new site with old versions
> > 2.22.x
> > > > > > >>
> > > > > > >> Guide to testing staged releases:
> > > > > > >>
> > > > >
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> > > > > > >>
> > > > > > >> Vote open for 72 hours.
> > > > > > >>
> > > > > > >> [ ] +1
> > > > > > >> [ ] +0
> > > > > > >> [ ] -1
> > > > > > >>
> > > > > > >> --
> > > > > > >> Cheers
> > > > > > >> Tibor
> > > > > > >>
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Romain Manni-Bucau <rm...@gmail.com>.

Le lun. 4 mai 2020 à 17:23, Stephane Nicoll <st...@gmail.com> a
écrit :

> On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll <st...@gmail.com>
> a
> > écrit :
> >
> > > Thanks but that doesn't really answer my question. That version is
> picked
> > > up by dependency management of the project as far as I can tell. If a
> > > project does provide an older junit engine version the build will
> break.
> > >
> > > If you meant to "force" a single version then I'd argue that you
> > shouldn't
> > > resolve the one provided in dependency management for the project. I
> also
> > > find this change quite suspicious in a maintenance release.
> > >
> > >
> > Long story short the first jupiter integration contributed by junit team
> > was supporting a single version.
> > This is what is in 2.x of surefire.
> > This maintenance release just upgraded the version as requested in a
> ticket
> > IIRC but didn't change the way it is loaded (which is done on master).
> >
>
> It is changing things in a non backward compatible way as you are now
> required to use  a more recent JUnit version in a maintenance release of
> the plugin. And given that the plugin loads the version from dependency
> management, you are not forcing the version that you require. If the
> project uses the junit bom (as it should be) and it does not match the
> requirement, the build fails with a NoClassDefFoundError. Surely that can't
> be right?
>

I - and all I guess - agree with you that this implementation is not the
expected one from an user perspective, this is why it got fixed on 3.x,
but it didn't change in 2.x, only the supported version and we likely
missed 1.5/1.6.1 were not compatible (think spring is using 1.6.0 btw).
Using user version was not a feature and is still not in 2.x.


>
> Just to make sure I understood your point. You are OK if users upgrading to
> a maintenance release of this plugin are also forced to upgrade the JUnit
> version they are using? This is going to break pretty much all Spring Boot
> users in 2.2.x as our policy is not upgrade to a new feature release of
> JUnit in a maintenance release of Spring Boot.
>

Not exactly, I'm saying that it was the compromise selected for this
release - once again we can revise it.

The workaround for 2.x is to add the junit platform in the test
dependencies and I guess it is this one for several pre-3 versions (recall
having done it for 1.3):

<dependency>
  <groupId>org.junit.platform</groupId>
  <artifactId>junit-platform-launcher</artifactId>
  <version>1.5.2</version>
</dependency>
<dependency>
  <groupId>org.junit.platform</groupId>
  <artifactId>junit-platform-engine</artifactId>
  <version>1.5.2</version>
</dependency>




>
> Suffice to say, I don't think we can upgrade to this plugin. Have I missed
> something?
>

Once again if you want to do a PR or even handle the dev/test/merge
lifecycle since you are a committer, it would be welcomed and I would be
happy to help you.
I just wanted to highlight there is no structural change there and the
downside of supporting a single version is still there and users wanting to
use 1.6 will have the opposite issue than yours.

@Tibor: if you read these lines, how far are we to do a 3.0.0, it is proven
pretty stable and saw the tcp work almost done, maybe we should estimate
when we can make it out if we want to reduce the load on 2.x. Wdyt?


>
>
>
> >
> >
> > >
> > >
> > > On Mon, May 4, 2020 at 5:03 PM Romain Manni-Bucau <
> rmannibucau@gmail.com
> > >
> > > wrote:
> > >
> > > > Hi Stephane,
> > > >
> > > > AFAIK the choice with 2.22 maintenance for now was to keep using a
> > single
> > > > junit5 version as originally and if only support more flexibility
> with
> > > 3.x.
> > > > Think it makes sense for now but if you want to PR 2.22 to backport
> 3.x
> > > > work I guess it can be discussed too in another thread.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le lun. 4 mai 2020 à 16:35, Stephane Nicoll <
> stephane.nicoll@gmail.com
> > >
> > > a
> > > > écrit :
> > > >
> > > > > An update. This may be the other fixed issue in that release
> actually
> > > > > (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What happens
> > for
> > > > > projects that are using an older JUnit version?
> > > > >
> > > > > On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <
> > > > stephane.nicoll@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring
> Boot
> > > > build
> > > > > > with 2.22.2 and reproduced the error there. Upgrading to this
> > > candidate
> > > > > > release and I got this error.
> > > > > >
> > > > > > [ERROR] Failed to execute goal
> > > > > > org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test
> > > > (default-test)
> > > > > > on project spring-boot-configuration-metadata: There are test
> > > failures.
> > > > > > [ERROR]
> > > > > > [ERROR] Please refer to
> > > > > >
> > > > >
> > > >
> > >
> >
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> > > > > > for the individual test results.
> > > > > > [ERROR] Please refer to dump files (if any exist) [date].dump,
> > > > > > [date]-jvmRun[N].dump and [date].dumpstream.
> > > > > > [ERROR] There was an error in the forked process
> > > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > > [ERROR]
> > org.apache.maven.surefire.booter.SurefireBooterForkException:
> > > > > > There was an error in the forked process
> > > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > > [ERROR] at
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> > > > > > [ERROR] at
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> > > > > > [ERROR] at
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> > > > > > [ERROR] at
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> > > > > > [ERROR] at
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> > > > > > [ERROR] at
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
> > > > > >
> > > > > > See https://github.com/spring-projects/spring-boot/issues/19631
> > > > > >
> > > > > > On Sun, May 3, 2020 at 11:44 PM Tibor Digana <
> > tibordigana@apache.org
> > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Hi,
> > > > > >>
> > > > > >> We solved 2 issues:
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> > > > > >>
> > > > > >> There are still a couple of issues left in JIRA:
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > > > > >>
> > > > > >> Staging repo:
> > > > > >> https://repository.apache.org/content/repositories/maven-1572/
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> > > > > >>
> > > > > >> Source release checksum(s):
> > > > > >>
> > > > > >> surefire-2.22.3-source-release.zip sha512::
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> > > > > >> surefire-2.22.3-source-release.zip sha1:
> > > > > >> 2db957105d2929911927482c8d2198bd6ef718a7
> > > > > >>
> > > > > >>
> > > > > >> Staging site:
> > > > > >> N/A - we do not want to override new site with old versions
> 2.22.x
> > > > > >>
> > > > > >> Guide to testing staged releases:
> > > > > >>
> > > >
> http://maven.apache.org/guides/development/guide-testing-releases.html
> > > > > >>
> > > > > >> Vote open for 72 hours.
> > > > > >>
> > > > > >> [ ] +1
> > > > > >> [ ] +0
> > > > > >> [ ] -1
> > > > > >>
> > > > > >> --
> > > > > >> Cheers
> > > > > >> Tibor
> > > > > >>
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Stephane Nicoll <st...@gmail.com>.

On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Le lun. 4 mai 2020 à 17:06, Stephane Nicoll <st...@gmail.com> a
> écrit :
>
> > Thanks but that doesn't really answer my question. That version is picked
> > up by dependency management of the project as far as I can tell. If a
> > project does provide an older junit engine version the build will break.
> >
> > If you meant to "force" a single version then I'd argue that you
> shouldn't
> > resolve the one provided in dependency management for the project. I also
> > find this change quite suspicious in a maintenance release.
> >
> >
> Long story short the first jupiter integration contributed by junit team
> was supporting a single version.
> This is what is in 2.x of surefire.
> This maintenance release just upgraded the version as requested in a ticket
> IIRC but didn't change the way it is loaded (which is done on master).
>

It is changing things in a non backward compatible way as you are now
required to use  a more recent JUnit version in a maintenance release of
the plugin. And given that the plugin loads the version from dependency
management, you are not forcing the version that you require. If the
project uses the junit bom (as it should be) and it does not match the
requirement, the build fails with a NoClassDefFoundError. Surely that can't
be right?

Just to make sure I understood your point. You are OK if users upgrading to
a maintenance release of this plugin are also forced to upgrade the JUnit
version they are using? This is going to break pretty much all Spring Boot
users in 2.2.x as our policy is not upgrade to a new feature release of
JUnit in a maintenance release of Spring Boot.

Suffice to say, I don't think we can upgrade to this plugin. Have I missed
something?



>
>
> >
> >
> > On Mon, May 4, 2020 at 5:03 PM Romain Manni-Bucau <rmannibucau@gmail.com
> >
> > wrote:
> >
> > > Hi Stephane,
> > >
> > > AFAIK the choice with 2.22 maintenance for now was to keep using a
> single
> > > junit5 version as originally and if only support more flexibility with
> > 3.x.
> > > Think it makes sense for now but if you want to PR 2.22 to backport 3.x
> > > work I guess it can be discussed too in another thread.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le lun. 4 mai 2020 à 16:35, Stephane Nicoll <stephane.nicoll@gmail.com
> >
> > a
> > > écrit :
> > >
> > > > An update. This may be the other fixed issue in that release actually
> > > > (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What happens
> for
> > > > projects that are using an older JUnit version?
> > > >
> > > > On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <
> > > stephane.nicoll@gmail.com>
> > > > wrote:
> > > >
> > > > > I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring Boot
> > > build
> > > > > with 2.22.2 and reproduced the error there. Upgrading to this
> > candidate
> > > > > release and I got this error.
> > > > >
> > > > > [ERROR] Failed to execute goal
> > > > > org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test
> > > (default-test)
> > > > > on project spring-boot-configuration-metadata: There are test
> > failures.
> > > > > [ERROR]
> > > > > [ERROR] Please refer to
> > > > >
> > > >
> > >
> >
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> > > > > for the individual test results.
> > > > > [ERROR] Please refer to dump files (if any exist) [date].dump,
> > > > > [date]-jvmRun[N].dump and [date].dumpstream.
> > > > > [ERROR] There was an error in the forked process
> > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > [ERROR]
> org.apache.maven.surefire.booter.SurefireBooterForkException:
> > > > > There was an error in the forked process
> > > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > > [ERROR] at
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> > > > > [ERROR] at
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> > > > > [ERROR] at
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> > > > > [ERROR] at
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> > > > > [ERROR] at
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> > > > > [ERROR] at
> > > > >
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
> > > > >
> > > > > See https://github.com/spring-projects/spring-boot/issues/19631
> > > > >
> > > > > On Sun, May 3, 2020 at 11:44 PM Tibor Digana <
> tibordigana@apache.org
> > >
> > > > > wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> We solved 2 issues:
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> > > > >>
> > > > >> There are still a couple of issues left in JIRA:
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > > > >>
> > > > >> Staging repo:
> > > > >> https://repository.apache.org/content/repositories/maven-1572/
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> > > > >>
> > > > >> Source release checksum(s):
> > > > >>
> > > > >> surefire-2.22.3-source-release.zip sha512::
> > > > >>
> > > > >>
> > > >
> > >
> >
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> > > > >> surefire-2.22.3-source-release.zip sha1:
> > > > >> 2db957105d2929911927482c8d2198bd6ef718a7
> > > > >>
> > > > >>
> > > > >> Staging site:
> > > > >> N/A - we do not want to override new site with old versions 2.22.x
> > > > >>
> > > > >> Guide to testing staged releases:
> > > > >>
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > > > >>
> > > > >> Vote open for 72 hours.
> > > > >>
> > > > >> [ ] +1
> > > > >> [ ] +0
> > > > >> [ ] -1
> > > > >>
> > > > >> --
> > > > >> Cheers
> > > > >> Tibor
> > > > >>
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > > >>
> > > > >>
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Romain Manni-Bucau <rm...@gmail.com>.

Le lun. 4 mai 2020 à 17:06, Stephane Nicoll <st...@gmail.com> a
écrit :

> Thanks but that doesn't really answer my question. That version is picked
> up by dependency management of the project as far as I can tell. If a
> project does provide an older junit engine version the build will break.
>
> If you meant to "force" a single version then I'd argue that you shouldn't
> resolve the one provided in dependency management for the project. I also
> find this change quite suspicious in a maintenance release.
>
>
Long story short the first jupiter integration contributed by junit team
was supporting a single version.
This is what is in 2.x of surefire.
This maintenance release just upgraded the version as requested in a ticket
IIRC but didn't change the way it is loaded (which is done on master).


>
>
> On Mon, May 4, 2020 at 5:03 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Hi Stephane,
> >
> > AFAIK the choice with 2.22 maintenance for now was to keep using a single
> > junit5 version as originally and if only support more flexibility with
> 3.x.
> > Think it makes sense for now but if you want to PR 2.22 to backport 3.x
> > work I guess it can be discussed too in another thread.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le lun. 4 mai 2020 à 16:35, Stephane Nicoll <st...@gmail.com>
> a
> > écrit :
> >
> > > An update. This may be the other fixed issue in that release actually
> > > (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What happens for
> > > projects that are using an older JUnit version?
> > >
> > > On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <
> > stephane.nicoll@gmail.com>
> > > wrote:
> > >
> > > > I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring Boot
> > build
> > > > with 2.22.2 and reproduced the error there. Upgrading to this
> candidate
> > > > release and I got this error.
> > > >
> > > > [ERROR] Failed to execute goal
> > > > org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test
> > (default-test)
> > > > on project spring-boot-configuration-metadata: There are test
> failures.
> > > > [ERROR]
> > > > [ERROR] Please refer to
> > > >
> > >
> >
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> > > > for the individual test results.
> > > > [ERROR] Please refer to dump files (if any exist) [date].dump,
> > > > [date]-jvmRun[N].dump and [date].dumpstream.
> > > > [ERROR] There was an error in the forked process
> > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> > > > There was an error in the forked process
> > > > [ERROR] java.lang.NoClassDefFoundError:
> > > > org/junit/platform/engine/EngineDiscoveryListener
> > > > [ERROR] at
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> > > > [ERROR] at
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> > > > [ERROR] at
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> > > > [ERROR] at
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> > > > [ERROR] at
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> > > > [ERROR] at
> > > >
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
> > > >
> > > > See https://github.com/spring-projects/spring-boot/issues/19631
> > > >
> > > > On Sun, May 3, 2020 at 11:44 PM Tibor Digana <tibordigana@apache.org
> >
> > > > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> We solved 2 issues:
> > > >>
> > > >>
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> > > >>
> > > >> There are still a couple of issues left in JIRA:
> > > >>
> > > >>
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > > >>
> > > >> Staging repo:
> > > >> https://repository.apache.org/content/repositories/maven-1572/
> > > >>
> > > >>
> > >
> >
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> > > >>
> > > >> Source release checksum(s):
> > > >>
> > > >> surefire-2.22.3-source-release.zip sha512::
> > > >>
> > > >>
> > >
> >
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> > > >> surefire-2.22.3-source-release.zip sha1:
> > > >> 2db957105d2929911927482c8d2198bd6ef718a7
> > > >>
> > > >>
> > > >> Staging site:
> > > >> N/A - we do not want to override new site with old versions 2.22.x
> > > >>
> > > >> Guide to testing staged releases:
> > > >>
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> > > >>
> > > >> Vote open for 72 hours.
> > > >>
> > > >> [ ] +1
> > > >> [ ] +0
> > > >> [ ] -1
> > > >>
> > > >> --
> > > >> Cheers
> > > >> Tibor
> > > >>
> > > >>
> ---------------------------------------------------------------------
> > > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>
> > > >>
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Stephane Nicoll <st...@gmail.com>.

Thanks but that doesn't really answer my question. That version is picked
up by dependency management of the project as far as I can tell. If a
project does provide an older junit engine version the build will break.

If you meant to "force" a single version then I'd argue that you shouldn't
resolve the one provided in dependency management for the project. I also
find this change quite suspicious in a maintenance release.



On Mon, May 4, 2020 at 5:03 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Hi Stephane,
>
> AFAIK the choice with 2.22 maintenance for now was to keep using a single
> junit5 version as originally and if only support more flexibility with 3.x.
> Think it makes sense for now but if you want to PR 2.22 to backport 3.x
> work I guess it can be discussed too in another thread.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 4 mai 2020 à 16:35, Stephane Nicoll <st...@gmail.com> a
> écrit :
>
> > An update. This may be the other fixed issue in that release actually
> > (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What happens for
> > projects that are using an older JUnit version?
> >
> > On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <
> stephane.nicoll@gmail.com>
> > wrote:
> >
> > > I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring Boot
> build
> > > with 2.22.2 and reproduced the error there. Upgrading to this candidate
> > > release and I got this error.
> > >
> > > [ERROR] Failed to execute goal
> > > org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test
> (default-test)
> > > on project spring-boot-configuration-metadata: There are test failures.
> > > [ERROR]
> > > [ERROR] Please refer to
> > >
> >
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> > > for the individual test results.
> > > [ERROR] Please refer to dump files (if any exist) [date].dump,
> > > [date]-jvmRun[N].dump and [date].dumpstream.
> > > [ERROR] There was an error in the forked process
> > > [ERROR] java.lang.NoClassDefFoundError:
> > > org/junit/platform/engine/EngineDiscoveryListener
> > > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> > > There was an error in the forked process
> > > [ERROR] java.lang.NoClassDefFoundError:
> > > org/junit/platform/engine/EngineDiscoveryListener
> > > [ERROR] at
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> > > [ERROR] at
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> > > [ERROR] at
> > >
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> > > [ERROR] at
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> > > [ERROR] at
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> > > [ERROR] at
> > >
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
> > >
> > > See https://github.com/spring-projects/spring-boot/issues/19631
> > >
> > > On Sun, May 3, 2020 at 11:44 PM Tibor Digana <ti...@apache.org>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> We solved 2 issues:
> > >>
> > >>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> > >>
> > >> There are still a couple of issues left in JIRA:
> > >>
> > >>
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> > >>
> > >> Staging repo:
> > >> https://repository.apache.org/content/repositories/maven-1572/
> > >>
> > >>
> >
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> > >>
> > >> Source release checksum(s):
> > >>
> > >> surefire-2.22.3-source-release.zip sha512::
> > >>
> > >>
> >
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> > >> surefire-2.22.3-source-release.zip sha1:
> > >> 2db957105d2929911927482c8d2198bd6ef718a7
> > >>
> > >>
> > >> Staging site:
> > >> N/A - we do not want to override new site with old versions 2.22.x
> > >>
> > >> Guide to testing staged releases:
> > >>
> http://maven.apache.org/guides/development/guide-testing-releases.html
> > >>
> > >> Vote open for 72 hours.
> > >>
> > >> [ ] +1
> > >> [ ] +0
> > >> [ ] -1
> > >>
> > >> --
> > >> Cheers
> > >> Tibor
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >>
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Romain Manni-Bucau <rm...@gmail.com>.

Hi Stephane,

AFAIK the choice with 2.22 maintenance for now was to keep using a single
junit5 version as originally and if only support more flexibility with 3.x.
Think it makes sense for now but if you want to PR 2.22 to backport 3.x
work I guess it can be discussed too in another thread.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 4 mai 2020 à 16:35, Stephane Nicoll <st...@gmail.com> a
écrit :

> An update. This may be the other fixed issue in that release actually
> (SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What happens for
> projects that are using an older JUnit version?
>
> On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <st...@gmail.com>
> wrote:
>
> > I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring Boot build
> > with 2.22.2 and reproduced the error there. Upgrading to this candidate
> > release and I got this error.
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test (default-test)
> > on project spring-boot-configuration-metadata: There are test failures.
> > [ERROR]
> > [ERROR] Please refer to
> >
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> > for the individual test results.
> > [ERROR] Please refer to dump files (if any exist) [date].dump,
> > [date]-jvmRun[N].dump and [date].dumpstream.
> > [ERROR] There was an error in the forked process
> > [ERROR] java.lang.NoClassDefFoundError:
> > org/junit/platform/engine/EngineDiscoveryListener
> > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> > There was an error in the forked process
> > [ERROR] java.lang.NoClassDefFoundError:
> > org/junit/platform/engine/EngineDiscoveryListener
> > [ERROR] at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> > [ERROR] at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> > [ERROR] at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> > [ERROR] at
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> > [ERROR] at
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> > [ERROR] at
> >
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
> >
> > See https://github.com/spring-projects/spring-boot/issues/19631
> >
> > On Sun, May 3, 2020 at 11:44 PM Tibor Digana <ti...@apache.org>
> > wrote:
> >
> >> Hi,
> >>
> >> We solved 2 issues:
> >>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> >>
> >> There are still a couple of issues left in JIRA:
> >>
> >>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1572/
> >>
> >>
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> >>
> >> Source release checksum(s):
> >>
> >> surefire-2.22.3-source-release.zip sha512::
> >>
> >>
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> >> surefire-2.22.3-source-release.zip sha1:
> >> 2db957105d2929911927482c8d2198bd6ef718a7
> >>
> >>
> >> Staging site:
> >> N/A - we do not want to override new site with old versions 2.22.x
> >>
> >> Guide to testing staged releases:
> >> http://maven.apache.org/guides/development/guide-testing-releases.html
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> --
> >> Cheers
> >> Tibor
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Stephane Nicoll <st...@gmail.com>.

An update. This may be the other fixed issue in that release actually
(SUREFIRE-1764). Is JUnit engine 1.6.1 now mandatory? What happens for
projects that are using an older JUnit version?

On Mon, May 4, 2020 at 3:59 PM Stephane Nicoll <st...@gmail.com>
wrote:

> I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring Boot build
> with 2.22.2 and reproduced the error there. Upgrading to this candidate
> release and I got this error.
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test (default-test)
> on project spring-boot-configuration-metadata: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
> for the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] There was an error in the forked process
> [ERROR] java.lang.NoClassDefFoundError:
> org/junit/platform/engine/EngineDiscoveryListener
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> There was an error in the forked process
> [ERROR] java.lang.NoClassDefFoundError:
> org/junit/platform/engine/EngineDiscoveryListener
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)
>
> See https://github.com/spring-projects/spring-boot/issues/19631
>
> On Sun, May 3, 2020 at 11:44 PM Tibor Digana <ti...@apache.org>
> wrote:
>
>> Hi,
>>
>> We solved 2 issues:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
>>
>> There are still a couple of issues left in JIRA:
>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1572/
>>
>> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
>>
>> Source release checksum(s):
>>
>> surefire-2.22.3-source-release.zip sha512::
>>
>> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
>> surefire-2.22.3-source-release.zip sha1:
>> 2db957105d2929911927482c8d2198bd6ef718a7
>>
>>
>> Staging site:
>> N/A - we do not want to override new site with old versions 2.22.x
>>
>> Guide to testing staged releases:
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> --
>> Cheers
>> Tibor
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Stephane Nicoll <st...@gmail.com>.

I am not sure that SUREFIRE-1679 is fixed. I've ran the Spring Boot build
with 2.22.2 and reproduced the error there. Upgrading to this candidate
release and I got this error.

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.22.3:test (default-test)
on project spring-boot-configuration-metadata: There are test failures.
[ERROR]
[ERROR] Please refer to
/Users/snicoll/workspace/work/spring-boot/2.2.x/spring-boot-project/spring-boot-tools/spring-boot-configuration-metadata/target/surefire-reports
for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump,
[date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] There was an error in the forked process
[ERROR] java.lang.NoClassDefFoundError:
org/junit/platform/engine/EngineDiscoveryListener
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There
was an error in the forked process
[ERROR] java.lang.NoClassDefFoundError:
org/junit/platform/engine/EngineDiscoveryListener
[ERROR] at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
[ERROR] at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
[ERROR] at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
[ERROR] at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1186)
[ERROR] at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1014)
[ERROR] at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:860)

See https://github.com/spring-projects/spring-boot/issues/19631

On Sun, May 3, 2020 at 11:44 PM Tibor Digana <ti...@apache.org> wrote:

> Hi,
>
> We solved 2 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1572/
>
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
>
> Source release checksum(s):
>
> surefire-2.22.3-source-release.zip sha512::
>
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> surefire-2.22.3-source-release.zip sha1:
> 2db957105d2929911927482c8d2198bd6ef718a7
>
>
> Staging site:
> N/A - we do not want to override new site with old versions 2.22.x
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> --
> Cheers
> Tibor
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Tibor Digana <ti...@apache.org>.

Thank you for participating. The Vote is cancelled.

On Sun, May 3, 2020 at 11:44 PM Tibor Digana <ti...@apache.org> wrote:

> Hi,
>
> We solved 2 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1572/
>
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
>
> Source release checksum(s):
>
> surefire-2.22.3-source-release.zip sha512::
>
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> surefire-2.22.3-source-release.zip sha1:
> 2db957105d2929911927482c8d2198bd6ef718a7
>
>
> Staging site:
> N/A - we do not want to override new site with old versions 2.22.x
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> --
> Cheers
> Tibor
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Tibor Digana <ti...@apache.org>.

done ;-)
now it's the major issue.

On Mon, May 4, 2020 at 12:06 AM Elliotte Rusty Harold
<el...@ibiblio.org> wrote:
>
> SUREFIRE-1556 is open and classified as a blocker:
>
> https://issues.apache.org/jira/browse/SUREFIRE-1556?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>
> If it's not truly a blocker, we should downgrade this issue.
>
>
> On Sun, May 3, 2020 at 5:44 PM Tibor Digana <ti...@apache.org> wrote:
> >
> > Hi,
> >
> > We solved 2 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1572/
> > https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
> >
> > Source release checksum(s):
> >
> > surefire-2.22.3-source-release.zip sha512::
> > c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> > surefire-2.22.3-source-release.zip sha1:
> > 2db957105d2929911927482c8d2198bd6ef718a7
> >
> >
> > Staging site:
> > N/A - we do not want to override new site with old versions 2.22.x
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > --
> > Cheers
> > Tibor
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
>
> --
> Elliotte Rusty Harold
> elharo@ibiblio.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


-- 
Cheers
Tibor

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

Posted by Elliotte Rusty Harold <el...@ibiblio.org>.

SUREFIRE-1556 is open and classified as a blocker:

https://issues.apache.org/jira/browse/SUREFIRE-1556?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC

If it's not truly a blocker, we should downgrade this issue.


On Sun, May 3, 2020 at 5:44 PM Tibor Digana <ti...@apache.org> wrote:
>
> Hi,
>
> We solved 2 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12345472
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1572/
> https://repository.apache.org/content/repositories/maven-1572/org/apache/maven/surefire/surefire/2.22.3/surefire-2.22.3-source-release.zip
>
> Source release checksum(s):
>
> surefire-2.22.3-source-release.zip sha512::
> c1533ed45fd3119d028a4914ca7557acfbfea5218b5536bbafeed4b33845486b976f20b39334e2917636e3739240478ca46bd25a0dc011e5fb2aa85033e9e959
> surefire-2.22.3-source-release.zip sha1:
> 2db957105d2929911927482c8d2198bd6ef718a7
>
>
> Staging site:
> N/A - we do not want to override new site with old versions 2.22.x
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> --
> Cheers
> Tibor
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


-- 
Elliotte Rusty Harold
elharo@ibiblio.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org