You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/04 10:12:11 UTC
[jira] [Commented] (CB-11491) Introduce before_deploy hook
[ https://issues.apache.org/jira/browse/CB-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361126#comment-15361126 ]
ASF GitHub Bot commented on CB-11491:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/460#discussion_r69436735
--- Diff: cordova-lib/spec-cordova/emulate.spec.js ---
@@ -82,7 +85,7 @@ describe('emulate command', function() {
cordova.raw.emulate({platforms: ['ios'], options: {optionTastic: true }}).then(function(err) {
expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['ios']}));
expect(getPlatformApi).toHaveBeenCalledWith('ios');
- expect(platformApi.run).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true });
+ expect(platformApi.run).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true, nobuild: true });
--- End diff --
@daserge, could you please add another expectation to check if `build` also had been called and changing the options in `build` does not affect `run` command?
> Introduce before_deploy hook
> ----------------------------
>
> Key: CB-11491
> URL: https://issues.apache.org/jira/browse/CB-11491
> Project: Apache Cordova
> Issue Type: New Feature
> Components: CordovaLib
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org