You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by MichealShin <gi...@git.apache.org> on 2019/01/18 02:57:37 UTC
[GitHub] storm pull request #2940: STORM-3318: Complete information in Class NewKafka...
GitHub user MichealShin opened a pull request:
https://github.com/apache/storm/pull/2940
STORM-3318: Complete information in Class NewKafkaSpoutOffsetQuery
Just complete information in three methods(toString , equals, hashCode).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MichealShin/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2940.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2940
----
commit a4fde2c43cb529197572c9524d0e9800c61bac34
Author: MichealShin <lu...@...>
Date: 2018-01-30T09:42:38Z
STORM-2917: Check the derecated config nimbus.host
There is a situation: the deployer wants to use the new nimbus config(nimbus.seeds), but still leave the blank deprecated config(nimbus.host) in storm.yaml. It will not work.
To avoid this, the program should at least check whether the deprecated config is blank.
commit 59952ef37293196b160d5854ce834c5c5bfc202a
Author: MichealShin <lu...@...>
Date: 2018-01-30T09:44:29Z
Merge pull request #2 from MichealShin/MichealShin-patch-2
STORM-2917: Check the derecated config nimbus.host
commit f5eddafef4fde0de27c2a4033f382d89f17821c5
Author: shichenglong <sh...@...>
Date: 2019-01-18T02:20:07Z
Merge branch 'master' of git://github.com/apache/storm into apache-master
# Conflicts:
# storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java
commit cd5d64b6bb8eb6f34f65044577689871e035877e
Author: MichealShin <sh...@...>
Date: 2019-01-18T02:35:34Z
Merge pull request #3 from apache/master
update
commit afe1b071059c6b3d91ba77187f3ca0d50d85e37e
Author: MichealShin <sh...@...>
Date: 2019-01-18T02:55:36Z
STORM-3318: Complete information in Class NewKafkaSpoutOffsetQuery
Just complete information in three methods(toString , equals, hashCode).
----
---
[GitHub] storm pull request #2940: STORM-3318: Complete information in Class NewKafka...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2940#discussion_r248985594
--- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java ---
@@ -75,8 +77,13 @@ public boolean equals(Object o) {
NewKafkaSpoutOffsetQuery that = (NewKafkaSpoutOffsetQuery) o;
if (topics != null ? !topics.equals(that.topics) : that.topics != null) return false;
- if (consumerGroupId != null ? !consumerGroupId.equals(that.consumerGroupId) : that.consumerGroupId != null) return false;
- return !(bootStrapBrokers != null ? !bootStrapBrokers.equals(that.bootStrapBrokers) : that.bootStrapBrokers != null);
+ if (consumerGroupId != null ? !consumerGroupId.equals(that.consumerGroupId) : that.consumerGroupId != null)
--- End diff --
I realize this was an issue before as well, but please add braces.
---
[GitHub] storm issue #2940: STORM-3318: Complete information in Class NewKafkaSpoutOf...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2940
@MichealShin You don't need to open a new PR. If you push your changes to the branch this PR is pointing at, the PR will get updated automatically.
That said, I think Github gets weird about reopening PRs once they're closed and the source branch has changed, so let's use the new PR. But just for future reference :)
---
[GitHub] storm issue #2940: STORM-3318: Complete information in Class NewKafkaSpoutOf...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2940
Looks good. Please squash to one commit.
---
[GitHub] storm issue #2940: STORM-3318: Complete information in Class NewKafkaSpoutOf...
Posted by MichealShin <gi...@git.apache.org>.
Github user MichealShin commented on the issue:
https://github.com/apache/storm/pull/2940
@srdo Done. See: https://github.com/apache/storm/pull/2941
---
[GitHub] storm pull request #2940: STORM-3318: Complete information in Class NewKafka...
Posted by MichealShin <gi...@git.apache.org>.
Github user MichealShin closed the pull request at:
https://github.com/apache/storm/pull/2940
---