You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/16 09:35:10 UTC

[GitHub] [skywalking-booster-ui] wuwen5 opened a new pull request, #219: fix: Formatted display of json content type

wuwen5 opened a new pull request, #219:
URL: https://github.com/apache/skywalking-booster-ui/pull/219

   The version before 8.8.0 is correct, and there are mistake after 8.8.0.
   
   expect
   ![image](https://user-images.githubusercontent.com/5037807/212642366-61a448d9-cf07-4cb6-80bc-5149cadb14dc.png)
   
   actual
   ![image](https://user-images.githubusercontent.com/5037807/212642660-c5b6958a-4b1b-44cb-9ee8-c9b512c2f43f.png)
   
   https://github.com/apache/skywalking-rocketbot-ui/pull/572
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #219: fix: Formatted display of json content type

Posted by GitBox <gi...@apache.org>.

wu-sheng merged PR #219:
URL: https://github.com/apache/skywalking-booster-ui/pull/219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #219: fix: Formatted display of json content type

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on PR #219:
URL: https://github.com/apache/skywalking-booster-ui/pull/219#issuecomment-1383767434

   What happens if the content us declared as JSON, but actually not a valid JSON? This happened from time to time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-booster-ui] wuwen5 commented on pull request #219: fix: Formatted display of json content type

Posted by GitBox <gi...@apache.org>.

wuwen5 commented on PR #219:
URL: https://github.com/apache/skywalking-booster-ui/pull/219#issuecomment-1383858337

   > What happens if the content is declared as JSON, but actually not a valid JSON? This happened from time to time.
   
   A js error will occur, and the details page will not display normally.
   I added `try`. If there are other ways, please let me know


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org