You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GabrielBrascher <gi...@git.apache.org> on 2015/12/20 14:55:56 UTC
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed “\_” from variables names**: private variables with “\_” at the beginning is common in C++ but not in Java.
**Removed unused methods from ApiServer:**
- com.cloud.api.ApiServer.setPluggableServices(List\<PluggableService\>): this method can be removed and replaced by the annotation @Inject in the variable pluggableServices;
- com.cloud.api.ApiServer.getPluggableServices(): unused method;
- com.cloud.api.ApiServer.setApiAccessCheckers(List\<APIChecker\>): can be replaced by the @Inject in the variable apiAccessCheckers;
- com.cloud.api.ApiServer.getApiAccessCheckers(): unused method.
**Methods and variables access level reviewed:**
- com.cloud.api.ApiServer.handleAsyncJobPublishEvent(String, String ,Object): this method was private but the annotation @MessageHandler requests public methods, as can be seen in org.apache.cloudstack.framework.messagebus.MessageDispatcher.buildHandlerMethodCache(Class\<?\>), which searches methods with the @MessageHandler annotation and changes
it to be accessible (“setAccessible(true)”). Thus, there is no reason for handleAsyncJobPublishEvent be a private method and lead some other dev to wrong conclusions about the use of the method;
- Global variables and methods called just by this class (ApiServer) were changed to private.
**Changed variables and methods from static to non-static (if possible):** as some variables/methods are used just by one object of this class, instantiated by Spring, they were changed to non-static.
With that, calls from com.cloud.api.ApiServlet.ApiServlet() that used static methods from ApiServer, were changed from ApiServer.\<staticMethodName\> to \_apiServer.\<methodName\> that refers to the org.apache.cloudstack.api.ApiServerService interface. Thus, methods com.cloud.api.ApiServer.getJSONContentType() and com.cloud.api.ApiServer.isSecureSessionCookieEnabled() had to be added in the interface (org.apache.cloudstack.api.ApiServerService, interface implemented by class ApiServer).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack lrg-cs-hackday-018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
----
commit b8b09e7abf9c318d774d5dadd3663e2d79107f21
Author: gabrascher <ga...@hotmail.com>
Date: 2015-12-20T11:38:04Z
Removed unused code from com.cloud.api.ApiServer
Removed “_” from variables names, private variables with “_” at the
beginning is common in C++ but not in Java.
Removed unused methods from ApiServer:
- com.cloud.api.ApiServer.setPluggableServices(List<PluggableService>):
This method can be removed and replaced by the annotation @Inject in the
variable pluggableServices (before _pluggableServices.
- com.cloud.api.ApiServer.getPluggableServices(): Unused method.
- com.cloud.api.ApiServer.setApiAccessCheckers(List<APIChecker>): Can be
replaced by the @Inject in the variable apiAccessCheckers (before
_apiAccessCheckers).
- com.cloud.api.ApiServer.getApiAccessCheckers(): Unused method.
Methods and variables access level reviewed:
- com.cloud.api.ApiServer.handleAsyncJobPublishEvent(String, String,
Object): This method was private but the annotation @MessageHandler
requests public methods, as can be seen in
org.apache.cloudstack.framework.messagebus.MessageDispatcher.buildHandlerMethodCache(Class<?>),
which searches methods with the @MessageHandler annotation and changes
it to be accessible (“setAccessible(true)”). Thus, there is no reason
for handleAsyncJobPublishEvent be a private method and lead some other
dev to wrong conclusions about the use of the method.
- Global variables and methods called just by this class (ApiServer)
were changed to private.
Changed variables and methods from static to non-static (if possible):
As some variables/methods are used just by one object of this class,
instantiated by Spring, they were changed to non-static.
With that, calls from com.cloud.api.ApiServlet.ApiServlet() that used
static methods from ApiServer, were changed from
ApiServer.<staticMethodName> to _apiServer.<methodName> that refers to
the org.apache.cloudstack.api.ApiServerService interface. Thus, methods
com.cloud.api.ApiServer.getJSONContentType() and
com.cloud.api.ApiServer.isSecureSessionCookieEnabled() had to be added
in the interface (org.apache.cloudstack.api.ApiServerService, interface
implemented by class ApiServer).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207956609
@GabrielBrascher you could try to close the PR and reopen it. It matters if the queue at builds.apache.org has a full queue or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203492750
@DaanHoogland @rafaelweingartner well noted, I have to remove those ".class" files;
@pdube I am going to verify this checkstyle error.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher closed the pull request at:
https://github.com/apache/cloudstack/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-209009495
@GabrielBrascher thanks, Travis failed again. I'll test this on my env tomorrow (night for me here). Meanwhile, can you build with -T4 -Dnoredist -Dsimulator flags to see if you can reproduce/fix issue at your end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203406148
@GabrielBrascher, it seems that everything is ok with this PR (giving CI), but to push it forward with reviews, can you remove the .class from your commit?
Also, can you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207914050
Seems that `push -f` is not making the Jenkins and Travis to rerun their tests. Is there any workaround for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207989355
@DaanHoogland thanks for the tip.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208956680
@GabrielBrascher can you do a rebase or push -f again so that Travis build can be re-kicked
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-209095939
This one looks like it is ready to go now. I will add it to my next 'ready to merge' batch. Thanks again for all the hard work @GabrielBrascher. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207488773
@pdube removed those uderscores, also I modified the "com.cloud.api.ApiServer.setEncodeApiResponse(boolean)" method to static again. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207084266
@swill what about this one?
The tests were already executed and everything passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-172383741
@GabrielBrascher Nice change. It is always good to keep the good programming practices, especially in a project of this size.
Can you commit it again? It seems that were some timeout problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208535036
@GabrielBrascher yes, this is something that we are trying to work through. We have updated the source to give more verbose logging so we can better understand the source of this problem. Any help troubleshooting this is appreciated as Jenkins and Travis working correctly is required for us to keep things moving...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203396908
@GabrielBrascher you have .class files in your commit according to github. Can you check?
And please repush anyway? thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207112861
Yes, I think this one is ready. I am trying to get two LGTM code reviews on every PR, so can one of @DaanHoogland or @pdube give me a LGTM, I have one from @rafaelweingartner. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
GitHub user GabrielBrascher reopened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed “\_” from variables names**: private variables with “\_” at the beginning is common in C++ but not in Java.
**Removed unused code from ApiServer:**
- com.cloud.api.ApiServer.getPluggableServices(): unused method;
- com.cloud.api.ApiServer.getApiAccessCheckers(): unused method;
**Methods and variables access level reviewed:**
- com.cloud.api.ApiServer.handleAsyncJobPublishEvent(String, String ,Object): this method was private but the annotation @MessageHandler requests public methods, as can be seen in org.apache.cloudstack.framework.messagebus.MessageDispatcher.buildHandlerMethodCache(Class\<?\>), which searches methods with the @MessageHandler annotation and changes
it to be accessible (“setAccessible(true)”). Thus, there is no reason for handleAsyncJobPublishEvent be a private method and lead some other dev to wrong conclusions about the use of the method;
- Global variables and methods called just by this class (ApiServer) were changed to private.
**Changed variables and methods from static to non-static (if possible):** as some variables/methods are used just by one object of this class, instantiated by Spring, they were changed to non-static.
With that, calls from com.cloud.api.ApiServlet.ApiServlet() that used static methods from ApiServer, were changed from ApiServer.\<staticMethodName\> to \_apiServer.\<methodName\> that refers to the org.apache.cloudstack.api.ApiServerService interface. Thus, methods com.cloud.api.ApiServer.getJSONContentType() and com.cloud.api.ApiServer.isSecureSessionCookieEnabled() had to be added in the interface (org.apache.cloudstack.api.ApiServerService, interface implemented by class ApiServer).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack lrg-cs-hackday-018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
----
commit 9ba72a500a141131ad5085028cc1a60b88a3dd0c
Author: gabrascher <ga...@hotmail.com>
Date: 2015-12-20T11:38:04Z
The goal of this PR is to review com.cloud.api.ApiServer class, with the
following actions:
Removed “_” in beginning of global variables names:
Variables was changed from “_<variablename>” to “<variablename>”, as
this convension (private veriables with “_”) is common in C++ but not in
Java.
Removed unused code from ApiServer:
- com.cloud.api.ApiServer.getPluggableServices():
Unused method.
- com.cloud.api.ApiServer.getApiAccessCheckers():
Unused method.
Methods and variables access level reviewed:
- com.cloud.api.ApiServer.handleAsyncJobPublishEvent(String, String,
Object):
This method was private but the annotation @MessageHandler requests
public methods, as can be seen in
org.apache.cloudstack.framework.messagebus.MessageDispatcher.buildHandlerMethodCache(Class<?>),
which searches methods with the @MessageHandler annotation and changes
it to accessible (“setAccessible(true)”). Thus, there is no reason for
handleAsyncJobPublishEvent be a private method.
- Global variables and methods called just by this class (ApiServer)
were changed to private.
Changed variables and methods from static to non static (if possible):
As some variables/methods are used just by one object of this class
(instantiated by springer), they were changed to non static.
With that, calls from com.cloud.api.ApiServlet.ApiServlet() that used
static methods from ApiServer, was changed from
ApiServer.<staticMethodName> to _apiServer.<methodName> that refers to
the org.apache.cloudstack.api.ApiServerService interface. Thus, methods
com.cloud.api.ApiServer.getJSONContentType() and
com.cloud.api.ApiServer.isSecureSessionCookieEnabled() had to be
included in the interface (org.apache.cloudstack.api.ApiServerService,
interface implemented by class ApiServer).
However, com.cloud.api.ApiServer.isEncodeApiResponse() was keept static,
as its call hierarchy would have to be changed (more than planed for
this PR).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59043684
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest req, final HttpServletResp
try {
if (HttpUtils.RESPONSE_TYPE_JSON.equalsIgnoreCase(responseType)) {
- resp.setContentType(ApiServer.getJSONContentType());
+ resp.setContentType(_apiServer.getJSONContentType());
--- End diff --
@pdube you are right, I am removing those undersocres (**_**apiServer and **_**messageBus). Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203434250
Hi @GabrielBrascher
Travis noted:
Failed during checkstyle execution: There are 1 checkstyle errors.
Have you run *mvn validate* on your code?
Thanks,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208330435
@DaanHoogland do you know what is going on with jenkins in this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208332183
can be a polution of the workspace (I'll clean it) or a jenkins having a different git loaded then is on disk. I've seen the last one once before on an internal install of jenkins. I think we need infra in that case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-209084883
I am sorry, but I forgot to update the com.cloud.api.ApiServletTest class, now that those tests are running, all checks have passed.
@bhaisaab @DaanHoogland @swill thanks for your effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-204043787
The code seems ok now. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203392098
### ACS CI BVT Run
**Sumarry:**
Build Number 147
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=0
Skipped=4
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso
**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026874
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest req, final HttpServletResp
try {
if (HttpUtils.RESPONSE_TYPE_JSON.equalsIgnoreCase(responseType)) {
- resp.setContentType(ApiServer.getJSONContentType());
+ resp.setContentType(_apiServer.getJSONContentType());
--- End diff --
Why leave the underscore here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208969926
@bhaisaab force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208533273
Travis keeps with the issue *missing file/directory '/home/travis/build/apache/cloudstack/tools/marvin/dist/Marvin-***.tar.gz*'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026583
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -223,10 +226,7 @@
private static ExecutorService s_executor = new ThreadPoolExecutor(10, 150, 60, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(), new NamedThreadFactory(
"ApiServer"));
@Inject
- MessageBus _messageBus;
-
- public ApiServer() {
- }
+ private MessageBus _messageBus;
--- End diff --
Why leave the underscore here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207490720
Built the package LGTM after review
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [ 1.746 s]
[INFO] Apache CloudStack ................................. SUCCESS [ 2.011 s]
[INFO] Apache CloudStack Maven Conventions Parent ........ SUCCESS [ 0.843 s]
[INFO] Apache CloudStack Framework - Managed Context ..... SUCCESS [ 3.186 s]
[INFO] Apache CloudStack Utils ........................... SUCCESS [ 20.485 s]
[INFO] Apache CloudStack Framework ....................... SUCCESS [ 0.045 s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 7.133 s]
[INFO] Apache CloudStack Framework - Configuration ....... SUCCESS [ 3.534 s]
[INFO] Apache CloudStack API ............................. SUCCESS [ 14.776 s]
[INFO] Apache CloudStack Framework - REST ................ SUCCESS [ 2.349 s]
[INFO] Apache CloudStack Framework - IPC ................. SUCCESS [ 4.402 s]
[INFO] Apache CloudStack Cloud Engine .................... SUCCESS [ 0.041 s]
[INFO] Apache CloudStack Cloud Engine API ................ SUCCESS [ 5.061 s]
[INFO] Apache CloudStack Framework - Security ............ SUCCESS [ 1.998 s]
[INFO] Apache CloudStack Core ............................ SUCCESS [ 25.450 s]
[INFO] Apache CloudStack Agents .......................... SUCCESS [ 7.287 s]
[INFO] Apache CloudStack Framework - Clustering .......... SUCCESS [ 3.947 s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [ 1.373 s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [ 13.294 s]
[INFO] Apache CloudStack Framework - Jobs ................ SUCCESS [ 4.572 s]
[INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [ 2.407 s]
[INFO] Apache CloudStack Server .......................... SUCCESS [ 47.212 s]
[INFO] Apache CloudStack Framework - Quota ............... SUCCESS [ 5.660 s]
[INFO] Apache CloudStack Usage Server .................... SUCCESS [ 6.111 s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [ 7.877 s]
[INFO] Apache CloudStack Cloud Services .................. SUCCESS [ 0.034 s]
[INFO] Apache CloudStack Secondary Storage ............... SUCCESS [ 0.255 s]
[INFO] Apache CloudStack Secondary Storage Service ....... SUCCESS [ 7.772 s]
[INFO] Apache CloudStack Engine Storage Component ........ SUCCESS [ 10.002 s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [ 10.349 s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [ 5.808 s]
[INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [ 6.406 s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [ 5.709 s]
[INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [ 21.328 s]
[INFO] Apache CloudStack Cloud Engine API ................ SUCCESS [ 5.636 s]
[INFO] Apache CloudStack Cloud Engine Service ............ SUCCESS [ 23.990 s]
[INFO] Apache CloudStack Plugin POM ...................... SUCCESS [ 1.642 s]
[INFO] Apache CloudStack Plugin - API Rate Limit ......... SUCCESS [ 19.023 s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [ 6.608 s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [ 10.002 s]
[INFO] Apache CloudStack Plugin - API SolidFire .......... SUCCESS [ 5.005 s]
[INFO] Apache CloudStack Plugin - API Discovery .......... SUCCESS [ 11.298 s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [ 3.553 s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor SUCCESS [ 3.810 s]
[INFO] Apache CloudStack Plugin - Explicit Dedication Processor SUCCESS [ 4.761 s]
[INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner SUCCESS [29:59 min]
[INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner SUCCESS [ 2.585 s]
[INFO] Apache CloudStack Plugin - Implicit Dedication Planner SUCCESS [ 8.700 s]
[INFO] Apache CloudStack Plugin - Skip Heurestics Planner SUCCESS [ 3.693 s]
[INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [ 4.290 s]
[INFO] Apache CloudStack Plugin - Dedicated Resources .... SUCCESS [ 11.395 s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM .... SUCCESS [ 5.675 s]
[INFO] Apache CloudStack Plugin - Open vSwitch ........... SUCCESS [ 7.772 s]
[INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [ 59.741 s]
[INFO] Apache CloudStack Plugin - Hypervisor KVM ......... SUCCESS [ 18.321 s]
[INFO] Apache CloudStack Plugin - RabbitMQ Event Bus ..... SUCCESS [ 3.047 s]
[INFO] Apache CloudStack Plugin - In Memory Event Bus .... SUCCESS [ 5.230 s]
[INFO] Apache CloudStack Plugin - Kafka Event Bus ........ SUCCESS [ 2.650 s]
[INFO] Apache CloudStack Plugin - Hypervisor Baremetal ... SUCCESS [ 6.997 s]
[INFO] Apache CloudStack Plugin - Hypervisor UCS ......... SUCCESS [ 4.979 s]
[INFO] Apache CloudStack Plugin - Hypervisor Hyper-V ..... SUCCESS [ 12.076 s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM3 ... SUCCESS [ 33.398 s]
[INFO] Apache CloudStack Plugin - Network Elastic Load Balancer SUCCESS [ 9.677 s]
[INFO] Apache CloudStack Plugin - Network Internal Load Balancer SUCCESS [ 19.036 s]
[INFO] Apache CloudStack Framework - Spring Life Cycle ... SUCCESS [ 4.489 s]
[INFO] Apache CloudStack Plugin - Network Juniper Contrail SUCCESS [ 25.772 s]
[INFO] Apache CloudStack Plugin - Palo Alto .............. SUCCESS [02:15 min]
[INFO] Apache CloudStack Plugin - Network Netscaler ...... SUCCESS [ 6.568 s]
[INFO] Apache CloudStack Plugin - Network Nicira NVP ..... SUCCESS [ 21.514 s]
[INFO] Apache CloudStack Plugin - BigSwitch Virtual Network Segment SUCCESS [ 11.076 s]
[INFO] Apache CloudStack Plugin - Network Brocade VCS .... SUCCESS [ 11.887 s]
[INFO] Apache CloudStack Plugin - Midokura Midonet ....... SUCCESS [ 9.581 s]
[INFO] Apache CloudStack Plugin - Stratosphere SSP ....... SUCCESS [ 9.795 s]
[INFO] Apache CloudStack Plugin - Network Opendaylight ... SUCCESS [ 6.251 s]
[INFO] Apache CloudStack Plugin - Storage Allocator Random SUCCESS [ 1.830 s]
[INFO] Apache CloudStack Plugin - User Authenticator LDAP SUCCESS [ 3.541 s]
[INFO] Apache CloudStack Plugin - User Authenticator MD5 . SUCCESS [ 3.842 s]
[INFO] Apache CloudStack Plugin - User Authenticator PBKDF2-SHA-256 SUCCESS [ 6.209 s]
[INFO] Apache CloudStack Plugin - User Authenticator Plain Text SUCCESS [ 3.043 s]
[INFO] Apache CloudStack Plugin - User Authenticator SAML2 SUCCESS [ 35.172 s]
[INFO] Apache CloudStack Plugin - User Authenticator SHA256 Salted SUCCESS [ 7.051 s]
[INFO] Apache CloudStack Plugin - Dns Notifier Example ... SUCCESS [ 2.608 s]
[INFO] Apache CloudStack Plugin - Storage Image S3 provider SUCCESS [ 2.851 s]
[INFO] Apache CloudStack Plugin - Storage Image Swift provider SUCCESS [ 3.264 s]
[INFO] Apache CloudStack Plugin - Storage Image default provider SUCCESS [ 2.554 s]
[INFO] Apache CloudStack Plugin - Storage Image sample provider SUCCESS [ 3.243 s]
[INFO] Apache CloudStack Plugin - Storage Volume Nexenta Provider SUCCESS [ 5.697 s]
[INFO] Apache CloudStack Plugin - Storage Volume CloudByte Provider SUCCESS [ 4.266 s]
[INFO] Apache CloudStack Plugin - Storage Volume sample provider SUCCESS [ 2.598 s]
[INFO] Apache CloudStack Plugin - SNMP Alerts ............ SUCCESS [ 5.343 s]
[INFO] Apache CloudStack Plugin - Syslog Alerts .......... SUCCESS [ 5.019 s]
[INFO] Apache CloudStack Plugin - Network VXLAN .......... SUCCESS [ 6.652 s]
[INFO] Apache CloudStack Plugin - GloboDNS ............... SUCCESS [ 9.067 s]
[INFO] Apache CloudStack Plugin - Quota Service .......... SUCCESS [ 8.205 s]
[INFO] Apache CloudStack Framework - Spring Module ....... SUCCESS [ 10.013 s]
[INFO] Apache CloudStack Secondary Storage Controller .... SUCCESS [ 3.524 s]
[INFO] Apache CloudStack Client UI ....................... SUCCESS [ 13.062 s]
[INFO] Apache CloudStack Console Proxy - RDP Client ...... SUCCESS [ 13.081 s]
[INFO] Apache CloudStack Console Proxy ................... SUCCESS [ 0.304 s]
[INFO] Apache CloudStack Console Proxy - Server .......... SUCCESS [ 8.033 s]
[INFO] Apache CloudStack Framework - QuickCloud .......... SUCCESS [ 0.226 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46:29 min
[INFO] Finished at: 2016-04-08T10:43:17-05:00
[INFO] Final Memory: 104M/373M
[INFO] ------------------------------------------------------------------------
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher closed the pull request at:
https://github.com/apache/cloudstack/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203947763
@DaanHoogland @rafaelweingartner @pdube removed those ".class" files, also all checks have passed.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
GitHub user GabrielBrascher reopened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed “\_” from variables names**: private variables with “\_” at the beginning is common in C++ but not in Java.
**Removed unused code from ApiServer:**
- com.cloud.api.ApiServer.getPluggableServices(): unused method;
- com.cloud.api.ApiServer.getApiAccessCheckers(): unused method;
**Methods and variables access level reviewed:**
- com.cloud.api.ApiServer.handleAsyncJobPublishEvent(String, String ,Object): this method was private but the annotation @MessageHandler requests public methods, as can be seen in org.apache.cloudstack.framework.messagebus.MessageDispatcher.buildHandlerMethodCache(Class\<?\>), which searches methods with the @MessageHandler annotation and changes
it to be accessible (“setAccessible(true)”). Thus, there is no reason for handleAsyncJobPublishEvent be a private method and lead some other dev to wrong conclusions about the use of the method;
- Global variables and methods called just by this class (ApiServer) were changed to private.
**Changed variables and methods from static to non-static (if possible):** as some variables/methods are used just by one object of this class, instantiated by Spring, they were changed to non-static.
With that, calls from com.cloud.api.ApiServlet.ApiServlet() that used static methods from ApiServer, were changed from ApiServer.\<staticMethodName\> to \_apiServer.\<methodName\> that refers to the org.apache.cloudstack.api.ApiServerService interface. Thus, methods com.cloud.api.ApiServer.getJSONContentType() and com.cloud.api.ApiServer.isSecureSessionCookieEnabled() had to be added in the interface (org.apache.cloudstack.api.ApiServerService, interface implemented by class ApiServer).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack lrg-cs-hackday-018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
----
commit 9ba72a500a141131ad5085028cc1a60b88a3dd0c
Author: gabrascher <ga...@hotmail.com>
Date: 2015-12-20T11:38:04Z
The goal of this PR is to review com.cloud.api.ApiServer class, with the
following actions:
Removed “_” in beginning of global variables names:
Variables was changed from “_<variablename>” to “<variablename>”, as
this convension (private veriables with “_”) is common in C++ but not in
Java.
Removed unused code from ApiServer:
- com.cloud.api.ApiServer.getPluggableServices():
Unused method.
- com.cloud.api.ApiServer.getApiAccessCheckers():
Unused method.
Methods and variables access level reviewed:
- com.cloud.api.ApiServer.handleAsyncJobPublishEvent(String, String,
Object):
This method was private but the annotation @MessageHandler requests
public methods, as can be seen in
org.apache.cloudstack.framework.messagebus.MessageDispatcher.buildHandlerMethodCache(Class<?>),
which searches methods with the @MessageHandler annotation and changes
it to accessible (“setAccessible(true)”). Thus, there is no reason for
handleAsyncJobPublishEvent be a private method.
- Global variables and methods called just by this class (ApiServer)
were changed to private.
Changed variables and methods from static to non static (if possible):
As some variables/methods are used just by one object of this class
(instantiated by springer), they were changed to non static.
With that, calls from com.cloud.api.ApiServlet.ApiServlet() that used
static methods from ApiServer, was changed from
ApiServer.<staticMethodName> to _apiServer.<methodName> that refers to
the org.apache.cloudstack.api.ApiServerService interface. Thus, methods
com.cloud.api.ApiServer.getJSONContentType() and
com.cloud.api.ApiServer.isSecureSessionCookieEnabled() had to be
included in the interface (org.apache.cloudstack.api.ApiServerService,
interface implemented by class ApiServer).
However, com.cloud.api.ApiServer.isEncodeApiResponse() was keept static,
as its call hierarchy would have to be changed (more than planed for
this PR).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026830
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -1340,37 +1340,31 @@ public String getSerializedApiError(final ServerApiException ex, final Map<Strin
return responseText;
}
- public List<PluggableService> getPluggableServices() {
- return _pluggableServices;
- }
-
@Inject
public void setPluggableServices(final List<PluggableService> pluggableServices) {
- _pluggableServices = pluggableServices;
- }
-
- public List<APIChecker> getApiAccessCheckers() {
- return _apiAccessCheckers;
+ this.pluggableServices = pluggableServices;
}
@Inject
public void setApiAccessCheckers(final List<APIChecker> apiAccessCheckers) {
- _apiAccessCheckers = apiAccessCheckers;
+ this.apiAccessCheckers = apiAccessCheckers;
}
public static boolean isEncodeApiResponse() {
- return encodeApiResponse;
+ return ApiServer.encodeApiResponse;
}
- private static void setEncodeApiResponse(final boolean encodeApiResponse) {
+ private void setEncodeApiResponse(final boolean encodeApiResponse) {
ApiServer.encodeApiResponse = encodeApiResponse;
--- End diff --
What is this for? It seems like a strange thing to do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-172386387
@rodrigo93 This problem is not from the Jenkins. I am aware with the real problem (APIChecker bean) just haven't forced to commit again with the corrections. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208339528
@GabrielBrascher could you please close and re-open this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---