You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/31 13:55:17 UTC

[GitHub] [doris] englefly commented on a diff in pull request #14964: [Fix](Nereids)fix aggregation result error when child is empty relation

englefly commented on code in PR #14964:
URL: https://github.com/apache/doris/pull/14964#discussion_r1059647567


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Avg.java:
##########
@@ -64,13 +67,18 @@ protected List<DataType> intermediateTypes() {
     @Override
     public AggregateFunction withDistinctAndChildren(boolean isDistinct, List<Expression> children) {
         Preconditions.checkArgument(children.size() == 1);
-        return new Avg(isDistinct, children.get(0));
+        return new Avg(isDistinct, isAlwaysNullable, children.get(0));

Review Comment:
   什么情况下 isAlwaysNullable=false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org