[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging …

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging …
URL: https://github.com/apache/qpid-dispatch/pull/676#discussion_r377746563
 
 

 ##########
 File path: python/qpid_dispatch/management/client.py
 ##########
 @@ -76,6 +76,16 @@ def delete(self):
 class Node(object):
     """Client proxy for an AMQP management node"""
 
+    def clean_attrs(self, attrs):
+        BOOL_VALUES = {"yes": 1, "true": 1, "on": 1, "no": 0, "false": 0,
 
 Review comment:
   This is tough question. I think 'Yes' should be invalid, so should 'YES' or 'YEs' or 'NO' or 'No'
   Please let me know what your thoughts on that are.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org