You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/14 02:07:10 UTC
[GitHub] [arrow] westonpace opened a new pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
westonpace opened a new pull request #10719:
URL: https://github.com/apache/arrow/pull/10719
Minor cleanup fix from my earlier fix of this test in #10602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #10719:
URL: https://github.com/apache/arrow/pull/10719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#discussion_r669292380
##########
File path: cpp/src/arrow/testing/gtest_util.cc
##########
@@ -907,7 +910,7 @@ class GatingTask::Impl : public std::enable_shared_from_this<GatingTask::Impl> {
double timeout_seconds_;
Status status_;
bool unlocked_;
- int num_launched_ = 0;
+ std::atomic<int> num_launched_;
Review comment:
Nit: since we don't care about memory order, I think we can change this line to
`std::atomic<int> num_launched_{0}`, and leave all other codes untouched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-879572131
Revision: 3a1f4e47a3c7af582d67e013bed3bd712d87dba8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-594](https://github.com/ursacomputing/crossbow/branches/all?query=actions-594)
|Task|Status|
|----|------|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-594-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-881666980
Is this ok to merge/@westonpace are you planning on making further changes here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-879528937
https://issues.apache.org/jira/browse/ARROW-13332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-881692122
@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-881717194
CI failures unrelated, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-881692515
Revision: bffd265e582b799bd75e6d93e6b6168059c5919b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-609](https://github.com/ursacomputing/crossbow/branches/all?query=actions-609)
|Task|Status|
|----|------|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-609-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-881675405
I'll implement @cyb70289 's suggestion real quick and then merge after CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10719:
URL: https://github.com/apache/arrow/pull/10719#issuecomment-879571834
@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org