You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/07 14:45:22 UTC
[GitHub] [tvm] zhuwenxi opened a new pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
zhuwenxi opened a new pull request #10179:
URL: https://github.com/apache/tvm/pull/10179
RFC: https://github.com/apache/tvm-rfcs/pull/47
This is the first PR in the integration plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10179:
URL: https://github.com/apache/tvm/pull/10179#issuecomment-1039970845
@zhuwenxi please run another job. I can take care of the image update. Note that changing the docker script alone doesn't update the CI environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10179:
URL: https://github.com/apache/tvm/pull/10179#issuecomment-1042307174
ping @zhuwenxi please send another CI job, I want to update the cpu image together with onednn update in https://github.com/apache/tvm/pull/10266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi closed pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
masahi closed pull request #10179:
URL: https://github.com/apache/tvm/pull/10179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10179:
URL: https://github.com/apache/tvm/pull/10179#issuecomment-1039970845
@zhuwenxi please run another job. I can take care of the image update. Note that changing the docker script alone doesn't update the CI environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zhuwenxi commented on pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
zhuwenxi commented on pull request #10179:
URL: https://github.com/apache/tvm/pull/10179#issuecomment-1080386294
> @zhuwenxi please run another job. I can take care of the image update. Note that changing the docker script alone doesn't update the CI environment.
Thank you @masahi for the notice that changing docker script alone is not enough. I'm wondering is there any PR I can refer to fully update the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zhuwenxi commented on pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
zhuwenxi commented on pull request #10179:
URL: https://github.com/apache/tvm/pull/10179#issuecomment-1031545759
@comaniac Could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10179:
URL: https://github.com/apache/tvm/pull/10179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a change in pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #10179:
URL: https://github.com/apache/tvm/pull/10179#discussion_r803227205
##########
File path: docker/install/ubuntu_install_libxsmm.sh
##########
@@ -0,0 +1,32 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+set -u
+set -o pipefail
+
+pushd /usr/local/
+wget -q https://github.com/libxsmm/libxsmm/archive/refs/tags/1.17.tar.gz
+tar -xzf 1.17.tar.gz
+pushd ./libxsmm-1.17/
+make STATIC=0 -j10
Review comment:
better to config the thread number in a more flexible way.
```suggestion
make STATIC=0 -j$(($(nproc) - 1))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10179: [LIBXSMM] Add libxsmm to tvm ci
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10179:
URL: https://github.com/apache/tvm/pull/10179#issuecomment-1080405503
The actual update needs to be done by a committer. I can do that this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org