[GitHub] aherbert opened a new pull request #20: RNG-70: Add new XoShiRo generators

[GitBox <gi...@apache.org>]

aherbert opened a new pull request #20: RNG-70: Add new XoShiRo generators
URL: https://github.com/apache/commons-rng/pull/20
 
 
   Please review.
   
   Generators have been created to match their reference implementation. 
   
   This change incorporates modification of the existing ``XorShift1024Star`` class to enable the slightly different ``XorShift1024StarPhi``to inherit all functionality. That change can be moved to a diffferent PR if required.
   
   The design moves common code for save/restore to abstract classes. However the amount of code is small and the abstract classes could be dropped is favour of code duplication to reduce the number of extra abstract classes.
   
   If a seed is provided with all zeros then the generators are broken. A test asserts that this is allowed.
   
   I have only modified the projects core and simple. Further changes to the other projects to add the extra providers will be required when accepted.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org