You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/18 13:56:44 UTC
[GitHub] [ozone] captainzmc opened a new pull request, #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
captainzmc opened a new pull request, #3855:
URL: https://github.com/apache/ozone/pull/3855
## What changes were proposed in this pull request?
We should update Ratis to 2.4.0 to fix [gRPC memleak](https://github.com/grpc/grpc-java/pull/9415).
After we update ratis to 2.4.0, we will start release ozone 1.3.0.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7149
## How was this patch tested?
UT had been update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on a diff in pull request #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
Posted by GitBox <gi...@apache.org>.
myskov commented on code in PR #3855:
URL: https://github.com/apache/ozone/pull/3855#discussion_r998524193
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -353,8 +353,11 @@ public void notifyConfigurationChanged(long term, long index,
@Override
public void pause() {
- getLifeCycle().transition(LifeCycle.State.PAUSING);
- getLifeCycle().transition(LifeCycle.State.PAUSED);
+ final LifeCycle lc = getLifeCycle();
Review Comment:
Are these changes related to bumping ratis version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #3855:
URL: https://github.com/apache/ozone/pull/3855#issuecomment-1283577967
Thanks @adoroszlai @szetszwo @JacksonYao287 for the review. I will cut branch-1.3 and start the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3855:
URL: https://github.com/apache/ozone/pull/3855#discussion_r998526068
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -353,8 +353,11 @@ public void notifyConfigurationChanged(long term, long index,
@Override
public void pause() {
- getLifeCycle().transition(LifeCycle.State.PAUSING);
- getLifeCycle().transition(LifeCycle.State.PAUSED);
+ final LifeCycle lc = getLifeCycle();
Review Comment:
Yes, the tests are failing otherwise.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3251786711/jobs/5337244145#step:5:3128
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3251786711/jobs/5337244434#step:5:3141
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3251786711/jobs/5337244713#step:6:3310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on a diff in pull request #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
Posted by GitBox <gi...@apache.org>.
myskov commented on code in PR #3855:
URL: https://github.com/apache/ozone/pull/3855#discussion_r998524193
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -353,8 +353,11 @@ public void notifyConfigurationChanged(long term, long index,
@Override
public void pause() {
- getLifeCycle().transition(LifeCycle.State.PAUSING);
- getLifeCycle().transition(LifeCycle.State.PAUSED);
+ final LifeCycle lc = getLifeCycle();
Review Comment:
Are these changes connected to bumping ratis version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3855:
URL: https://github.com/apache/ozone/pull/3855#discussion_r998526068
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -353,8 +353,11 @@ public void notifyConfigurationChanged(long term, long index,
@Override
public void pause() {
- getLifeCycle().transition(LifeCycle.State.PAUSING);
- getLifeCycle().transition(LifeCycle.State.PAUSED);
+ final LifeCycle lc = getLifeCycle();
Review Comment:
Yes, the tests are failing otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #3855:
URL: https://github.com/apache/ozone/pull/3855#issuecomment-1283307460
Hi @szetszwo, Would you take another look？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 merged pull request #3855: HDDS-7149. Update ratis version to 2.4.0 and thirdparty version to 1.0.2.
Posted by GitBox <gi...@apache.org>.
JacksonYao287 merged PR #3855:
URL: https://github.com/apache/ozone/pull/3855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org