[jira] [Commented] (SENTRY-2109) Fix the logic of identifying HMS out of Sync and handle gaps and out-of-sequence notifications.

["Alexander Kolbasov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349502#comment-16349502 ] 

Alexander Kolbasov commented on SENTRY-2109:
--------------------------------------------

Why is it resolved so quickly? I was reviewing this as well and had some earlier comments, you didn't give me a chance to complete review.

> Fix the logic of identifying HMS out of Sync and handle gaps and out-of-sequence notifications.
> -----------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-2109
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2109
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>             Fix For: 2.1.0
>
>         Attachments: SENTRY-2109.001.patch, SENTRY-2109.002.patch, SENTRY-2109.003.patch, SENTRY-2109.004.patch, SENTRY-2109.005.patch, SENTRY-2109.006.patch, SENTRY-2109.007.patch, SENTRY-2109.008.patch, SENTRY-2109.009.patch, SENTRY-2109.010.patch, SENTRY-2109.010.patch, SENTRY-2109.011.patch, SENTRY-2109.012.patch, SENTRY-2109.012.patch, SENTRY-2109.012.patch, Screenshot_HMS_NOTIFICATION_LOG.png
>
>
> Currently HMSFollower proactively checks if sentry is out of sync with HMS and initiates full snapshot, if needed.
> There will be false positives with the current logic if there are gaps in the event-id in the notification log sequence.
> This jira is aimed at making that logic robust.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)