You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/22 07:19:58 UTC

[GitHub] [iotdb] jamber001 opened a new pull request #4010: [IOTDB-1720] client-cpp: enhance Session codes

jamber001 opened a new pull request #4010:
URL: https://github.com/apache/iotdb/pull/4010


   enhance codes in  client-cpp/src/main/Session.cpp and  client-cpp/src/main/Session.h
   
   1)  correct some risk CPP codes
   2)  correct some CPP codes that break basic CPP rule.
   3)  enhance some Inefficient codes for better perfromance 
   4) Accommodate more CPU types (bigEndian and LittleEndian) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4010: [IOTDB-1720] client-cpp: enhance Session codes

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4010:
URL: https://github.com/apache/iotdb/pull/4010#issuecomment-924686599


   
   [![Coverage Status](https://coveralls.io/builds/42987867/badge)](https://coveralls.io/builds/42987867)
   
   Coverage increased (+0.01%) to 67.442% when pulling **62084d492cced1c41ea2c6c0712009c0d44b53dc on jamber001:IOTDB-1720** into **c75a71f76c10a3f79b905df3daeef5429704a7f7 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4010: [IOTDB-1720] client-cpp: enhance Session codes

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4010:
URL: https://github.com/apache/iotdb/pull/4010#issuecomment-924686599


   
   [![Coverage Status](https://coveralls.io/builds/43027377/badge)](https://coveralls.io/builds/43027377)
   
   Coverage decreased (-0.02%) to 67.537% when pulling **e7442cad71c6b3340f355b7980c6f1c38255fcfb on jamber001:IOTDB-1720** into **9dd88f08fcb9205212a0687192d960462b6efdc4 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu merged pull request #4010: [IOTDB-1720] client-cpp: enhance Session codes

Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4010:
URL: https://github.com/apache/iotdb/pull/4010


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4010: [IOTDB-1720] client-cpp: enhance Session codes

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4010:
URL: https://github.com/apache/iotdb/pull/4010#issuecomment-924686599


   
   [![Coverage Status](https://coveralls.io/builds/43027589/badge)](https://coveralls.io/builds/43027589)
   
   Coverage decreased (-0.01%) to 67.542% when pulling **e7442cad71c6b3340f355b7980c6f1c38255fcfb on jamber001:IOTDB-1720** into **9dd88f08fcb9205212a0687192d960462b6efdc4 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jamber001 commented on pull request #4010: [IOTDB-1720] client-cpp: enhance Session codes

Posted by GitBox <gi...@apache.org>.
jamber001 commented on pull request #4010:
URL: https://github.com/apache/iotdb/pull/4010#issuecomment-926280833


   @HTHou   Can this PR be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org