You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2024/01/16 17:32:16 UTC
[PR] Bump SonarSource/sonarcloud-github-action from v1.9 to v2.1.1 [daffodil]
stevedlawrence opened a new pull request, #1146:
URL: https://github.com/apache/daffodil/pull/1146
This updates the docker container used to do the scan and should use the support Java 17 version.
Also uses correct capitalization of "SonarSource", maybe this is why dependabot never updated this for us?
This also enables the scan on pull requests. I'm not sure why we enabled it only when merged to main, but the documentation claims it works on PRs too, so lets do that.
DAFFODIL-2856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump SonarSource/sonarcloud-github-action from v1.9 to v2.1.1 [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #1146:
URL: https://github.com/apache/daffodil/pull/1146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump SonarSource/sonarcloud-github-action from v1.9 to v2.1.1 [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #1146:
URL: https://github.com/apache/daffodil/pull/1146#issuecomment-1894256227
My first commit allowed a scan to run on PR, since the documentation says it's possible. The documentation is correct, however, it leaves out that due to limitations in GitHub actions it will not work from PR's from a forked repo. This is because github actions does not pass secrets to workflows originating from a forked repository to prevent leaking secret. But this means the SONAR_TOKEN secret that is required cannot be passed to the scan. So until SonarCloud comes up with alternative that does not require a secret token, we cannot allow scans on PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump SonarSource/sonarcloud-github-action from v1.9 to v2.1.1 [daffodil]
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on PR #1146:
URL: https://github.com/apache/daffodil/pull/1146#issuecomment-1894341904
I suggest you approve too and merge, Steve, since this is really a version bump anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump SonarSource/sonarcloud-github-action from v1.9 to v2.1.1 [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #1146:
URL: https://github.com/apache/daffodil/pull/1146#issuecomment-1894200489
For reference, here is the diff of the github action to this current version: https://github.com/SonarSource/sonarcloud-github-action/compare/v1.9.1...v2.1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org