[GitHub] [beam] tvalentyn commented on a change in pull request #14251: [BEAM-9185] Publish pre-release python artifacts (RCs) to PyPI

[GitBox <gi...@apache.org>]

tvalentyn commented on a change in pull request #14251:
URL: https://github.com/apache/beam/pull/14251#discussion_r597871620



##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -283,6 +283,8 @@ After following one of these processes you should manually update `CHANGES.md` o
      [version.py](https://github.com/apache/beam/blob/release-2.6.0/sdks/python/apache_beam/version.py#L21),
      [build.gradle](https://github.com/apache/beam/blob/release-2.6.0/runners/google-cloud-dataflow-java/build.gradle#L39),
      [gradle.properties](https://github.com/apache/beam/blob/release-2.16.0/gradle.properties#L27)
+     
+**ATTENTION:** The Release Candidate Number ``rc_num`` is an optional parameter to add the version of the release candidate.

Review comment:
       I am not sure I understand the release flow from the guide - why is the RC number optional?
   
   Could we explain what the process will look like, in particular, at which point RC artifacts will be created and at which point they will be published to PyPi (I am guessing it is before the voting email is sent)? So both RC and non-RC artifacts will be built ahead of the voting email, but only RC artifacts be published to pypi?
   
   I think it makes sense to update the voting email template  (https://github.com/benWize/beam/blob/BEAM-9185/website/www/site/content/en/contribute/release-guide.md#9-vote-and-validate-release-candidate) to point out that Python RC artifacts can be tried from PyPi .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org