You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/06/14 14:06:07 UTC
[GitHub] [trafficcontrol] solomonbS opened a new pull request, #6899: TP v2 change Full Name to Name on the user page
solomonbS opened a new pull request, #6899:
URL: https://github.com/apache/trafficcontrol/pull/6899
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
this pr changes the full name in TP v2 to name on the user page
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Portal v2
## What is the best way to verify this PR?
- Go to current user profile to verify that full name is changed to name.
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6899: TP v2 change Full Name to Name on the user page
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6899:
URL: https://github.com/apache/trafficcontrol/pull/6899#discussion_r903981883
##########
experimental/traffic-portal/src/app/shared/currentUser/current-user.service.spec.ts:
##########
@@ -129,7 +129,7 @@ describe("CurrentUserService", () => {
company: null,
country: null,
email: "different email",
- fullName: "different full name",
+ fullName: "different Name",
Review Comment:
Changes to this file are unnecessary; these are just testing string values for the `fullName` field, not labels thereof.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6899: TP v2 change Full Name to Name on the user page
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #6899:
URL: https://github.com/apache/trafficcontrol/pull/6899#discussion_r897289712
##########
experimental/traffic-portal/src/app/core/currentuser/currentuser.component.html:
##########
@@ -34,8 +34,8 @@ <h2>User Theme</h2>
<input matInput [(ngModel)]="editUser.username" name="username" type="text" required/>
</mat-form-field>
<mat-form-field style="grid-area: z;">
- <mat-label>Full Name</mat-label>
- <input matInput [(ngModel)]="editUser.fullName" name="fullName" type="text" required/>
+ <mat-label>Name</mat-label>
+ <input matInput [(ngModel)]="editUser.fullName" name="Name" type="text" required/>
Review Comment:
The `name` attribute of an `input` is a programmatic name, not an accessibility or otherwise human-readable name. It's meant to be the key in a key-value pair submitted to the server in the request that results from the form's submission. It also adds a property to the containing `HTMLFormElement` in the DOM by the same name. So `document.forms[0].Name` with the value you have. if it were `fullName`, then the HTMLFormElement at `document.forms[0]` would actually fulfill the `User` interface. Instead this will make it have one property with a differing name.
For all these reasons, the `name` attribute here should remain `fullName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6899: TP v2 change Full Name to Name on the user page
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #6899:
URL: https://github.com/apache/trafficcontrol/pull/6899#issuecomment-1160994840
This also needs to get updated in the users table and the user details pages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6899: TP v2 change Full Name to Name on the user page
Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #6899:
URL: https://github.com/apache/trafficcontrol/pull/6899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org