[jira] [Commented] (HBASE-5773) HtablePool constructor not reading config files in certain cases

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252386#comment-13252386 ] 

Hadoop QA commented on HBASE-5773:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522403/different-config-behaviour.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//console

This message is automatically generated.
                
> HtablePool constructor not reading config files in certain cases
> ----------------------------------------------------------------
>
>                 Key: HBASE-5773
>                 URL: https://issues.apache.org/jira/browse/HBASE-5773
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.90.6, 0.92.1, 0.94.1
>            Reporter: Ioan Eugen Stan
>            Priority: Minor
>             Fix For: 0.90.7, 0.92.2, 0.94.1
>
>         Attachments: different-config-behaviour.patch
>
>
> Creating a HtablePool can issue two behaviour depanding on the constructor called. 
> Case 1: loads the configs from hbase-site
>   public HTablePool() {
>     this(HBaseConfiguration.create(), Integer.MAX_VALUE);
>   }
> Calling this with null values for Configuration: 
> public HTablePool(final Configuration config, final int maxSize) {
>     this(config, maxSize, null, null);
>   }
> will issue:
>  public HTablePool(final Configuration config, final int maxSize,
>       final HTableInterfaceFactory tableFactory, PoolType poolType) {
>     // Make a new configuration instance so I can safely cleanup when
>     // done with the pool.
>     this.config = config == null ? new Configuration() : config;
> which does not read the hbase-site config files as HBaseConfiguration.create() does. 
> I've tracked this problem to all versions of hbase. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira