[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2386: Cleanup of not just dependencies

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492922729



##########
File path: ide/parsing.indexing/manifest.mf
##########
@@ -4,4 +4,5 @@ OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/parsing/indexing/Bundle.p
 OpenIDE-Module-Layer: org/netbeans/modules/parsing/impl/indexing/layer.xml
 AutoUpdate-Show-In-Client: false
 OpenIDE-Module-Implementation-Version: 1
+OpenIDE-Module-Needs: org.netbeans.modules.parsing.impl.indexing.implspi.ActiveDocumentProvider

Review comment:
       Just to  understand this correctly: Is the intention here, that parsing.indexing and parsing.nb are loosely coupled? I.e. parsing.indexing needs and implemenation of that SPI?

##########
File path: ide/javascript2.debug/nbproject/project.xml
##########
@@ -114,6 +114,7 @@
             <friend-packages>
                 <friend>org.netbeans.modules.debugger.jpda.js</friend>
                 <friend>org.netbeans.modules.debugger.jpda.truffle</friend>
+                <friend>org.netbeans.modules.java.lsp.server</friend>

Review comment:
       I don't see the reason for this change - am I missing the dependency relationship?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists