[GitHub] [superset] michael-s-molina commented on a diff in pull request #22115: fix: Add scrollTopOnPagination property to Table

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #22115:
URL: https://github.com/apache/superset/pull/22115#discussion_r1021612996


##########
superset-frontend/src/components/TableView/TableView.tsx:
##########
@@ -49,6 +49,7 @@ export interface TableViewProps {
   isPaginationSticky?: boolean;
   showRowCount?: boolean;
   scrollTable?: boolean;
+  scrollTopOnPagination?: boolean;

Review Comment:
   I wonder if we should even expose a property to configure this behavior. My fear is that we would allow different behaviors throughout the app. We could follow the same approach we did with the Select component and not expose this property until a valid use case appears. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org