You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/09/29 10:28:31 UTC

[GitHub] flink pull request #4748: [hotfix][tests] Use G1GC for tests

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4748

    [hotfix][tests] Use G1GC for tests

    We are using G1GC for running TaskManager, I think we should do it so also for tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink g1gc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4748.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4748
    
----
commit e5aff977d8ee1efac4fb4c12c57431568618a7e1
Author: Piotr Nowojski <pi...@gmail.com>
Date:   2017-09-27T16:38:42Z

    [hotfix][tests] Use G1GC for tests

----


---

[GitHub] flink pull request #4748: [hotfix][tests] Use G1GC for tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4748


---

[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4748
  
    For speed or consistency?


---

[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4748
  
    Thanks for merging!


---

[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4748
  
    Mostly for consistency, however using Serial GC on it's own doesn't seem like a better idea compared t G1GC (avoiding long pauses)


---

[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

Posted by haohui <gi...@git.apache.org>.

Github user haohui commented on the issue:

    https://github.com/apache/flink/pull/4748
  
    +1
    
    It's very rare to see people using SerialGC in production environment. Running the tests using SerialGC seems bringing in little values.



---