You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/30 14:23:16 UTC
[GitHub] [arrow] kszucs opened a new pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented
kszucs opened a new pull request #7594:
URL: https://github.com/apache/arrow/pull/7594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7594:
URL: https://github.com/apache/arrow/pull/7594#discussion_r447724372
##########
File path: python/pyarrow/_csv.pyx
##########
@@ -342,9 +342,9 @@ cdef class ConvertOptions:
----------
check_utf8 : bool, optional (default True)
Whether to check UTF8 validity of string columns.
- column_types: dict, optional
- Map column names to column types
- (disabling type inference on those columns).
+ column_types: pa.Schema or dict, optional
+ Explicitly map column names to column types. Passing this argument
Review comment:
I'm surprised: was the original spelling not clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7594:
URL: https://github.com/apache/arrow/pull/7594#discussion_r447723473
##########
File path: python/pyarrow/_csv.pyx
##########
@@ -342,9 +342,9 @@ cdef class ConvertOptions:
----------
check_utf8 : bool, optional (default True)
Whether to check UTF8 validity of string columns.
- column_types: dict, optional
- Map column names to column types
- (disabling type inference on those columns).
+ column_types: pa.Schema or dict, optional
+ Explicitly map column names to column types. Passing this argument
Review comment:
I'm not sure how to clarify it better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #7594:
URL: https://github.com/apache/arrow/pull/7594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7594:
URL: https://github.com/apache/arrow/pull/7594#issuecomment-651831683
https://issues.apache.org/jira/browse/ARROW-7654
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org