[GitHub] [echarts] pissang commented on a change in pull request #14017: Fix(pie): labelLine is not hidden in some case

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #14017:
URL: https://github.com/apache/echarts/pull/14017#discussion_r555576874



##########
File path: src/chart/pie/PieView.ts
##########
@@ -189,7 +189,7 @@ class PiePiece extends graphic.Sector {
         setLabelLineStyle(this, getLabelLineStatesModels(itemModel), {

Review comment:
       Use a `show` flag in `setLabelLineStyle` is not a good style. It makes this function more complex and obscure because it's not matching with the function name. 
   
   Instead, we should use `labelLine.hide()` when `position` is not 'outside' and `labelLine` has been created explicitly here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org