[jira] [Commented] (SM-2410) windows startup scripts don't handle setenv.bat correctly

["Krzysztof Sobkowiak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SM-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243045#comment-14243045 ] 

Krzysztof Sobkowiak commented on SM-2410:
-----------------------------------------

The `karaf.bat` script is maintained in Karaf project, the `servicemix.bat` is a copy of `karaf.bat`. We cannot change them. 

> windows startup scripts don't handle setenv.bat correctly
> ---------------------------------------------------------
>
>                 Key: SM-2410
>                 URL: https://issues.apache.org/jira/browse/SM-2410
>             Project: ServiceMix
>          Issue Type: Bug
>    Affects Versions: 5.3.0
>         Environment: Windows Any
>            Reporter: Alexander Sahler
>            Priority: Minor
>         Attachments: patch_karaf.bat, patch_servicemix.bat
>
>
> When setting variables in setenv.bat they don't find their way to JAVA_DEFAULT_OPTIONS. This is due to the variable overwrite in line 231.
> {noformat}
> set DEFAULT_JAVA_OPTS=%JAVA_MODE% -Xms%JAVA_MIN_MEM% -Xmx%JAVA_MAX_MEM% -Dderby.system.home="%KARAF_DATA%\derby" -Dderby.storage.fileSyncTransactionLog=true -Dcom.sun.management.jmxremote -XX:+UnlockDiagnosticVMOptions -XX:+UnsyncloadClass
> {noformat}
> Instead it should be:
> {noformat}
> set DEFAULT_JAVA_OPTS=%JAVA_MODE% %DEFAULT_JAVA_OPTS% -Xms%JAVA_MIN_MEM% -Xmx%JAVA_MAX_MEM% -Dderby.system.home="%KARAF_DATA%\derby" -Dderby.storage.fileSyncTransactionLog=true -Dcom.sun.management.jmxremote -XX:+UnlockDiagnosticVMOptions -XX:+UnsyncloadClass
> {noformat}
> to keep the previous contents of DEFAULT_JAVA_OPTS.
> The same applies for karaf.bat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)