You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Daniel Spiewak (JIRA)" <ji...@apache.org> on 2008/11/12 02:19:44 UTC

[jira] Created: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Scala Specs Should Use src/specs/scala/
---------------------------------------

                 Key: BUILDR-209
                 URL: https://issues.apache.org/jira/browse/BUILDR-209
             Project: Buildr
          Issue Type: Improvement
          Components: Test frameworks
    Affects Versions: 1.3.3
            Reporter: Daniel Spiewak
            Priority: Minor


If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Daniel Spiewak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661686#action_12661686 ] 

Daniel Spiewak commented on BUILDR-209:
---------------------------------------

Is there any way we could push this into 1.3.4?  First-class Specs support is a pretty important issue for me.

> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>            Priority: Minor
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved BUILDR-209.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.4

Patch applied.  Thanks again!

boisvert@sixtine:~/svn/buildr-separate-scala-specs$ svn commit -m "BUILDR-209 Scala Specs Should Use src/specs/scala/"
Sending        CHANGELOG
Sending        doc/languages.textile
Sending        lib/buildr/java/tests.rb
Adding         lib/buildr/scala/bdd.rb
Sending        lib/buildr/scala/tests.rb
Sending        lib/buildr/scala.rb
Sending        spec/sandbox.rb
Adding         spec/scala/bdd_spec.rb
Sending        spec/scala/tests_spec.rb
Transmitting file data .........
Committed revision 755456.


> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>             Fix For: 1.3.4
>
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680009#action_12680009 ] 

Alex Boisvert commented on BUILDR-209:
--------------------------------------

You're right but I'm not sure it's a good precedent.  Let's bring this up on the mailing list.  I think it's time for splitting specs and tests.

> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Daniel Spiewak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660514#action_12660514 ] 

Daniel Spiewak commented on BUILDR-209:
---------------------------------------

Implemented as a separate Specs handler in Git fork.  Specs are compiled to target/spec/classes (is this right?).

git://github.com/djspiewak/buildr.git

Annoyingly, it seems that ScalaTest supersedes Specs any time the src/test/scala directory even exists.  The test.using `:specs => true` config has no apparent effect.  Otherwise, Specs picks up correctly on src/spec/scala and life is happy.  Is this how it is supposed to be, or is this because of a pesky bug in Buildr?

> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>            Priority: Minor
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679995#action_12679995 ] 

Alex Boisvert commented on BUILDR-209:
--------------------------------------

Hi Daniel, sorry I've been sitting on this patch for 2 weeks now...  The one thing that concerns me is that in the past, you could mix and match any of ScalaTest, ScalaSpecs and ScalaCheck code (all under src/test/scala) in the same project.   With your change it's no longer possible to mix ScalaTest and ScalaCheck, they need to go in separate projects.   

I'm definitely supportive of using src/specs/scala ...  so I'm going to go ahead and commit it, although I think we need to implement first-class support for specs in Buildr so we don't have to chose between test and spec in the future.

> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Daniel Spiewak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679996#action_12679996 ] 

Daniel Spiewak commented on BUILDR-209:
---------------------------------------

Hmm, isn't exclusivity of test providers the norm?  For example, you can either use JUnit *or* JBehave.

> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Daniel Spiewak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Spiewak updated BUILDR-209:
----------------------------------

    Priority: Major  (was: Minor)

My separate-scala-specs branch now sports actual RSpec specs.  The only thing left now is documentation, which is as simple as adding a paragraph to the appropriate .textile file.  There might be some unforeseen issues with other test providers using the filter_classes method, but I doubt it.  If anything, the ScalaTest might have to be modified a bit.

Basically, almost all of the work has been put in to make this happen.  Could we consider this for inclusion in 1.3.4? 

> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-209) Scala Specs Should Use src/specs/scala/

Posted by "Daniel Spiewak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660553#action_12660553 ] 

Daniel Spiewak commented on BUILDR-209:
---------------------------------------

To clarify, this enhancement is contained entirely by the separate-scala-specs remote branch.

Additionally, the bizarre issues with ScalaTest have been resolved.

> Scala Specs Should Use src/specs/scala/
> ---------------------------------------
>
>                 Key: BUILDR-209
>                 URL: https://issues.apache.org/jira/browse/BUILDR-209
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Test frameworks
>    Affects Versions: 1.3.3
>            Reporter: Daniel Spiewak
>            Priority: Minor
>
> If you create a series of unit tests using most supported BDD frameworks, the source file will have to be placed in some sub-directory of src/spec (e.g. src/spec/java, src/spec/groovy, etc).  However, due to the way that support is implemented for Specs (the Scala framework), test units must be placed within the src/test/scala folder.  This not only breaks with user expectation, but it also makes certain situations a little more difficult to deal with (mixed Scala Test and Specs for example).  It would be nice if we could just stick .scala files in the src/spec/scala directory and have things magically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.