You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/02 08:29:37 UTC

[GitHub] [incubator-devlake] tk103331 opened a new issue, #2938: [Bug][plugin-helper] the timeout of ApiClient is incorrectly overridden

tk103331 opened a new issue, #2938:
URL: https://github.com/apache/incubator-devlake/issues/2938

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   I create ApiClient with a timeout value. But, the timeout value of ApiClient is incorrectly overridden by `helper.CreateAsyncApiClient()`.
   I don't think this should be overridden when API_TIMEOUT is empty, especially since I've set a timeout value.
   
   https://github.com/apache/incubator-devlake/blob/cb25f65384bd4608b29c48587084be42cb8bbe4e/plugins/helper/api_async_client.go#L59-L63
   
   ### What you expected to happen
   
   I think the timeout value should'n be overridden when API_TIMEOUT is empty, especially since I've set a timeout value.
   
   ### How to reproduce
   
   1. Create ApiClient with a timeout value.
   2. Use helper.CreateAsyncApiClient() to create AsyncApiClient.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   main
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn closed issue #2938: [Bug][plugin-helper] the timeout of ApiClient is incorrectly overridden

Posted by GitBox <gi...@apache.org>.
abeizn closed issue #2938: [Bug][plugin-helper] the timeout of ApiClient is incorrectly overridden
URL: https://github.com/apache/incubator-devlake/issues/2938


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn commented on issue #2938: [Bug][plugin-helper] the timeout of ApiClient is incorrectly overridden

Posted by GitBox <gi...@apache.org>.
abeizn commented on issue #2938:
URL: https://github.com/apache/incubator-devlake/issues/2938#issuecomment-1235234319

   @tk103331 Thanks for reporting the issue. I'm looking forward to your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org