You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/25 23:01:30 UTC
Review Request 47862: GEODE-1450: Move ExampleJSONAuthorization out of
'test' and into 'main'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47862/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
- This also renames the class to SampleJsonAuthorization (it's already
in an 'examples' package so I figured the original name was a bit
redundant).
- Once we have an 'examples' submodule this class could be refactored a
bit more and moved there (or simply extended there with a thin
wrapper).
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java f34be0b5ce4d833b60a20dced38a57e72eda1670
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
Diff: https://reviews.apache.org/r/47862/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 47862: GEODE-1450: Move ExampleJSONAuthorization
out of 'test' and into 'main'
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47862/#review134868
-----------------------------------------------------------
Fix it, then Ship it!
Fix it and ship it!
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java (line 51)
<https://reviews.apache.org/r/47862/#comment199811>
If this is now User visible, then you should probably write up some detailed javadocs on at least the class.
- Kirk Lund
On May 25, 2016, 11:01 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47862/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 11:01 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - This also renames the class to SampleJsonAuthorization (it's already
> in an 'examples' package so I figured the original name was a bit
> redundant).
> - Once we have an 'examples' submodule this class could be refactored a
> bit more and moved there (or simply extended there with a thin
> wrapper).
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java f34be0b5ce4d833b60a20dced38a57e72eda1670
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
>
> Diff: https://reviews.apache.org/r/47862/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47862: GEODE-1450: Move ExampleJSONAuthorization
out of 'test' and into 'main'
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47862/#review134877
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 25, 2016, 11:01 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47862/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 11:01 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - This also renames the class to SampleJsonAuthorization (it's already
> in an 'examples' package so I figured the original name was a bit
> redundant).
> - Once we have an 'examples' submodule this class could be refactored a
> bit more and moved there (or simply extended there with a thin
> wrapper).
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java f34be0b5ce4d833b60a20dced38a57e72eda1670
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
>
> Diff: https://reviews.apache.org/r/47862/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>