You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 13:06:48 UTC

[GitHub] [airflow] griffincosgrove opened a new issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

griffincosgrove opened a new issue #13634:
URL: https://github.com/apache/airflow/issues/13634


   On file `master:airflow/providers/segment/provider.yaml`
   
   ```
   integrations:
     - integration-name: Segment
       external-doc-url: https://oapi.dingtalk.com
       tags: [service]
   ```
   
   That is the API for Dingtalk, which is an unrelated Alibaba owned service. The docs for Twilio Segment can be found at [(https://segment.com/docs/)](url)
   
   Not sure any of this is relevant because but it appears I must add this information
   **Apache Airflow version**: 2.0.0
   
   **Environment**: GNU/Linux
   
   - **Cloud provider or hardware configuration**:
   - **OS** (e.g. from /etc/os-release): Ubuntu
   - **Kernel** (e.g. `uname -a`): 20.4
   - **Install tools**: PIP
   
   **What happened**: `external-doc-url` is mapped to dingtalk API
   
   **What you expected to happen**: `external-doc-url` to be mapped to Segment docs
   
   **How to reproduce it**: Observe code at `master:airflow/providers/segment/provider.yaml`
   
   ```
   integrations:
     - integration-name: Segment
       external-doc-url: https://oapi.dingtalk.com
       tags: [service]
   ```
   
   New to Apache Airflow, but please bear with me 😄 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758741095


   @griffincosgrove there are no other implications. We only use it for documentation. http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow-providers/operators-and-hooks-ref/services.html#dingding


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758731011


   @mik-laj is this just a one line change? If so yes! 😃 
   
   Not sure if this has other implications I am unaware of. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758723322


   Are you willing to submit a PR? I'm happy to help with the review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758871980


   Assigned it to you @griffincosgrove 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758754348


   @mik-laj yes I would like to send in a PR for this. Please assign this to me. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758875259


   Thanks! @kaxil


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj closed issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #13634:
URL: https://github.com/apache/airflow/issues/13634


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758741095


   @griffincosgrove Yes. It is only one line change. there are no other implications. We only use it for documentation. http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow-providers/operators-and-hooks-ref/services.html#dingding


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #13634: Docs: Segment `external-doc-url` links to Dingtalk API

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #13634:
URL: https://github.com/apache/airflow/issues/13634#issuecomment-758643395


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org