You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/04/17 15:35:39 UTC

[impala] branch master updated: IMPALA-7995: print webpage to debug test failure

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 667067a  IMPALA-7995: print webpage to debug test failure
667067a is described below

commit 667067a7b7c3b2b42187e59295b94ba0ca4249f0
Author: Tim Armstrong <ta...@cloudera.com>
AuthorDate: Tue Apr 16 21:00:30 2019 -0700

    IMPALA-7995: print webpage to debug test failure
    
    TestWebPage::test_catalog failed on a test run. Printing the response
    test will help debug in future.
    
    Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
    Reviewed-on: http://gerrit.cloudera.org:8080/13052
    Reviewed-by: Tim Armstrong <ta...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/webserver/test_web_pages.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/webserver/test_web_pages.py b/tests/webserver/test_web_pages.py
index 463e1fe..cb165d4 100644
--- a/tests/webserver/test_web_pages.py
+++ b/tests/webserver/test_web_pages.py
@@ -157,8 +157,9 @@ class TestWebPage(ImpalaTestSuite):
     for port in ports_to_test:
       input_url = url.format(port)
       response = requests.get(input_url)
-      assert response.status_code == requests.codes.ok\
-          and string_to_search in response.text, "Offending url: " + input_url
+      assert (response.status_code == requests.codes.ok
+          and string_to_search in response.text), "URL: {0} Str:'{1}'\nResp:{2}".format(
+              input_url, string_to_search, response.text)
       responses.append(response)
     return responses