You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/02/25 17:17:53 UTC
[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
coolbeevip opened a new pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741
Optimized dependency management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] WillemJiang commented on pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741#issuecomment-1051521390
@coolbeevip There are some error in alpha-fsm module when loading the spring boot application. Can you take a look at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741#discussion_r815248929
##########
File path: pack-contracts/pack-contract-grpc/pom.xml
##########
@@ -41,6 +41,11 @@
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>3.19.2</version>
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] WillemJiang commented on pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741#issuecomment-1056601804
Create another PR for the work of SCB-2397.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] WillemJiang closed pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
Posted by GitBox <gi...@apache.org>.
WillemJiang closed pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741#issuecomment-1051527760
> @coolbeevip There are some error in alpha-fsm module when loading the spring boot application. Can you take a look at it?
Ok, I am solving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741#discussion_r815248917
##########
File path: pack-contracts/pack-contract-grpc/pom.xml
##########
@@ -41,6 +41,11 @@
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>3.19.2</version>
Review comment:
yes, I missed it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #741: WIP:SCB-2397 Add pack-dependencies module management dependencies
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #741:
URL: https://github.com/apache/servicecomb-pack/pull/741#discussion_r815236344
##########
File path: pack-contracts/pack-contract-grpc/pom.xml
##########
@@ -41,6 +41,11 @@
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>3.19.2</version>
Review comment:
I think we need to specify the dependency version here with protobuf-java.version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org