[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #2741: HDFS-15855.Solve the problem of incorrect EC progress when loading FsImage.

[GitBox <gi...@apache.org>]

Hexiaoqiao commented on a change in pull request #2741:
URL: https://github.com/apache/hadoop/pull/2741#discussion_r597498170



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
##########
@@ -482,11 +483,15 @@ private void loadPolicy(ErasureCodingPolicyInfo info) {
    *
    */
   public synchronized void loadPolicies(
-      List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf)
+      List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf,

Review comment:
       +1, keep the original method and parameters as followinng.
   `public synchronized void loadPolicies(
         List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf) {
     loadPolicies(ecPolicies, conf, null);
   }`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org