You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Gordon Sim (JIRA)" <ji...@apache.org> on 2012/11/05 20:28:12 UTC
[jira] [Created] (PROTON-118) Add support for Messenger API
Gordon Sim created PROTON-118:
---------------------------------
Summary: Add support for Messenger API
Key: PROTON-118
URL: https://issues.apache.org/jira/browse/PROTON-118
Project: Qpid Proton
Issue Type: New Feature
Components: proton-j
Affects Versions: 0.1, 0.2
Reporter: Gordon Sim
Fix For: 0.3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-118) Add support for Messenger API
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated PROTON-118:
------------------------------
Attachment: (was: engine.patch)
> Add support for Messenger API
> -----------------------------
>
> Key: PROTON-118
> URL: https://issues.apache.org/jira/browse/PROTON-118
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.3
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-118) Add support for Messenger API
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated PROTON-118:
------------------------------
Attachment: (was: driver.patch)
> Add support for Messenger API
> -----------------------------
>
> Key: PROTON-118
> URL: https://issues.apache.org/jira/browse/PROTON-118
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.3
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-118) Add support for Messenger API
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim reassigned PROTON-118:
---------------------------------
Assignee: Gordon Sim
> Add support for Messenger API
> -----------------------------
>
> Key: PROTON-118
> URL: https://issues.apache.org/jira/browse/PROTON-118
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.3
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-118) Add support for Messenger API
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated PROTON-118:
------------------------------
Attachment: engine.patch
driver.patch
This is just an early preview of my initial stab at a messenger API. It doesn't yet do the reply-to munging, nor does it have the new acknowledgement stuff. Otherwise its more or less a straightforward port from the C version.
It works against the C implementation for simple send and receive examples, but does not yet support SSL (or SASL beyond ANONYMOUS).
The patch is split in two pieces for easier review. The driver patch makes some minor modifications to the driver API (adds ability to get at all connectors, as does the C version; changed from int to long for timeout; throw rather than swallow the IOExceptions from process). It also makes some more significant changes to the ConnectorImpl. This is largely so that it behaves like the C version (allowing a closer mirroring of the messenger impl).
The second patch adds the new messenger interface and an implementation. I've kept the separation between impl and interface that appears to be the pattern elsewhere but haven't added any factory yet which might be desirable to avoid code being tied directly to an impl class.
As I say, this is very much still work-in-progress but I thought it might be useful to get early feedback, collaborate with others interested etc etc.
> Add support for Messenger API
> -----------------------------
>
> Key: PROTON-118
> URL: https://issues.apache.org/jira/browse/PROTON-118
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.3
>
> Attachments: driver.patch, engine.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-118) Add support for Messenger API
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492398#comment-13492398 ]
Gordon Sim commented on PROTON-118:
-----------------------------------
Added slightly updated versions of the patches to review board: https://reviews.apache.org/r/7932/ & https://reviews.apache.org/r/7934
> Add support for Messenger API
> -----------------------------
>
> Key: PROTON-118
> URL: https://issues.apache.org/jira/browse/PROTON-118
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.3
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-118) Add support for Messenger API
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490881#comment-13490881 ]
Gordon Sim commented on PROTON-118:
-----------------------------------
Two deviations from the C to highlight:
(i) at present the Sender.unsettled() method isn't implemented so I couldn't rely on that for determining when send() can stop blocking. That is a temporary deviation only, just to make some progress with the rest of it.
(ii) in matching a message's address to a connection, I use the context on the connection to hold the host:port combination used to create it and match against that. This is in part because I was confused about the respective meaning of hostname and remote-hostname, and the facet that one has only a setter, the other only a getter. However it also seemed wrong to append the port to a 'hostname' (which seems to be what the C impl does). Thoughts on that particularly welcome.
> Add support for Messenger API
> -----------------------------
>
> Key: PROTON-118
> URL: https://issues.apache.org/jira/browse/PROTON-118
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-j
> Affects Versions: 0.1, 0.2
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Fix For: 0.3
>
> Attachments: driver.patch, engine.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira