You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2024/07/22 11:03:30 UTC
[PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
liugddx opened a new pull request, #38215:
URL: https://github.com/apache/doris/pull/38215
## Proposed changes
Issue Number: close #38174
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2247739294
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244193859
<details>
<summary>ClickBench: <b>Total hot run time: 30.56 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4dcc56cfe21badfeb9e3ca09cd89181ab325dd30, data reload: false
query1 0.05 0.04 0.04
query2 0.08 0.04 0.04
query3 0.22 0.05 0.05
query4 1.67 0.07 0.08
query5 0.51 0.49 0.52
query6 1.13 0.74 0.72
query7 0.02 0.02 0.02
query8 0.06 0.05 0.04
query9 0.55 0.51 0.48
query10 0.55 0.55 0.53
query11 0.14 0.11 0.12
query12 0.15 0.13 0.12
query13 0.60 0.59 0.60
query14 0.76 0.77 0.79
query15 0.85 0.80 0.81
query16 0.37 0.37 0.37
query17 1.05 0.98 0.97
query18 0.22 0.22 0.22
query19 1.90 1.81 1.74
query20 0.02 0.01 0.01
query21 15.42 0.78 0.66
query22 3.88 7.72 1.86
query23 18.25 1.33 1.19
query24 2.13 0.23 0.22
query25 0.15 0.09 0.09
query26 0.29 0.22 0.22
query27 0.45 0.24 0.23
query28 13.35 1.01 0.99
query29 12.63 3.32 3.31
query30 0.25 0.06 0.06
query31 2.85 0.38 0.37
query32 3.31 0.48 0.48
query33 2.89 2.93 2.96
query34 17.14 4.32 4.39
query35 4.41 4.38 4.50
query36 0.64 0.48 0.49
query37 0.18 0.14 0.15
query38 0.17 0.15 0.15
query39 0.04 0.04 0.04
query40 0.15 0.13 0.13
query41 0.10 0.05 0.04
query42 0.05 0.05 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.68 s
Total hot run time: 30.56 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2245551089
<details>
<summary>ClickBench: <b>Total hot run time: 31.01 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 03499b884bdef539533d9c24747f4ee89e53a6e2, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.22 0.05 0.05
query4 1.68 0.07 0.07
query5 0.50 0.51 0.52
query6 1.13 0.72 0.74
query7 0.02 0.01 0.01
query8 0.05 0.05 0.04
query9 0.57 0.49 0.50
query10 0.55 0.54 0.54
query11 0.15 0.12 0.12
query12 0.15 0.12 0.13
query13 0.60 0.58 0.58
query14 0.75 0.78 0.79
query15 0.85 0.80 0.80
query16 0.35 0.35 0.35
query17 0.98 0.98 0.96
query18 0.23 0.22 0.22
query19 1.80 1.69 1.65
query20 0.01 0.01 0.01
query21 15.38 0.79 0.64
query22 3.96 7.26 2.38
query23 18.29 1.41 1.30
query24 2.20 0.25 0.21
query25 0.16 0.09 0.08
query26 0.30 0.21 0.21
query27 0.46 0.23 0.22
query28 13.18 1.01 1.00
query29 12.59 3.30 3.29
query30 0.26 0.06 0.06
query31 2.86 0.40 0.40
query32 3.26 0.47 0.46
query33 2.90 2.90 2.90
query34 17.00 4.38 4.36
query35 4.45 4.35 4.38
query36 0.67 0.46 0.47
query37 0.20 0.17 0.15
query38 0.15 0.17 0.14
query39 0.04 0.04 0.04
query40 0.15 0.14 0.14
query41 0.09 0.05 0.05
query42 0.05 0.05 0.04
query43 0.05 0.04 0.04
Total cold run time: 109.36 s
Total hot run time: 31.01 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2246751859
<details>
<summary>ClickBench: <b>Total hot run time: 30.93 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e15b12ebc058be1ebdaed1dbdfed0a7b8b4791e5, data reload: false
query1 0.04 0.04 0.03
query2 0.09 0.04 0.04
query3 0.23 0.05 0.05
query4 1.67 0.07 0.07
query5 0.52 0.48 0.49
query6 1.13 0.74 0.72
query7 0.02 0.01 0.01
query8 0.06 0.04 0.04
query9 0.55 0.49 0.49
query10 0.53 0.54 0.55
query11 0.15 0.12 0.12
query12 0.15 0.12 0.12
query13 0.60 0.59 0.59
query14 0.75 0.79 0.78
query15 0.86 0.82 0.82
query16 0.36 0.35 0.35
query17 0.98 1.05 0.97
query18 0.23 0.22 0.23
query19 1.84 1.67 1.72
query20 0.01 0.01 0.01
query21 15.42 0.81 0.68
query22 4.14 6.80 2.24
query23 18.22 1.35 1.30
query24 2.12 0.26 0.22
query25 0.16 0.08 0.08
query26 0.29 0.21 0.21
query27 0.46 0.24 0.23
query28 13.22 1.02 0.99
query29 12.66 3.30 3.27
query30 0.26 0.06 0.06
query31 2.87 0.39 0.39
query32 3.27 0.47 0.48
query33 2.94 2.90 2.96
query34 17.20 4.34 4.34
query35 4.43 4.37 4.38
query36 0.65 0.47 0.47
query37 0.20 0.16 0.16
query38 0.15 0.15 0.14
query39 0.05 0.04 0.04
query40 0.15 0.13 0.13
query41 0.09 0.05 0.04
query42 0.06 0.04 0.06
query43 0.05 0.04 0.04
Total cold run time: 109.83 s
Total hot run time: 30.93 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2242752531
<details>
<summary>TPC-DS: <b>Total hot run time: 174221 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e9ede229bede24c314c312422ecdcb57c89f8a6, data reload: false
query1 919 372 365 365
query2 6451 1898 1821 1821
query3 6625 207 218 207
query4 27384 17546 17361 17361
query5 3704 494 505 494
query6 277 187 170 170
query7 4578 295 287 287
query8 242 203 191 191
query9 8399 2474 2450 2450
query10 450 304 281 281
query11 11887 10140 10077 10077
query12 128 90 86 86
query13 1635 378 368 368
query14 10042 7774 7551 7551
query15 220 168 162 162
query16 7738 518 484 484
query17 1139 531 518 518
query18 1946 285 277 277
query19 189 146 153 146
query20 91 79 82 79
query21 206 124 132 124
query22 4557 4162 4193 4162
query23 33998 33461 33643 33461
query24 9861 2947 2872 2872
query25 602 389 375 375
query26 710 152 159 152
query27 2246 275 279 275
query28 5731 2062 2077 2062
query29 895 645 659 645
query30 255 147 151 147
query31 1012 769 781 769
query32 98 55 57 55
query33 655 328 317 317
query34 890 491 514 491
query35 862 739 743 739
query36 1129 976 953 953
query37 152 88 85 85
query38 2954 2861 2913 2861
query39 912 862 843 843
query40 216 121 124 121
query41 47 44 44 44
query42 126 108 105 105
query43 525 467 483 467
query44 1063 717 725 717
query45 189 159 159 159
query46 1072 728 703 703
query47 1878 1757 1791 1757
query48 366 291 290 290
query49 839 398 399 398
query50 782 402 390 390
query51 6762 6751 6683 6683
query52 100 93 90 90
query53 352 295 291 291
query54 886 451 444 444
query55 75 70 74 70
query56 285 265 266 265
query57 1103 1094 1070 1070
query58 244 241 267 241
query59 3074 2552 2716 2552
query60 323 269 273 269
query61 98 93 92 92
query62 764 625 644 625
query63 316 287 285 285
query64 9145 2210 1667 1667
query65 3144 3120 3128 3120
query66 763 324 331 324
query67 15453 15050 14966 14966
query68 6180 532 530 530
query69 664 436 376 376
query70 1245 1135 1162 1135
query71 444 282 276 276
query72 6901 5840 5471 5471
query73 821 327 331 327
query74 6184 5723 5651 5651
query75 3717 2694 2648 2648
query76 3843 955 1025 955
query77 707 316 298 298
query78 9577 10427 9245 9245
query79 3367 517 512 512
query80 858 485 470 470
query81 560 219 218 218
query82 715 142 132 132
query83 201 169 167 167
query84 276 86 87 86
query85 1148 316 298 298
query86 450 318 316 316
query87 3225 3185 3134 3134
query88 4392 2467 2445 2445
query89 477 393 383 383
query90 1727 190 190 190
query91 124 97 102 97
query92 60 47 47 47
query93 4429 492 491 491
query94 1082 287 277 277
query95 411 310 326 310
query96 614 275 270 270
query97 3163 3053 3068 3053
query98 230 206 195 195
query99 1504 1250 1296 1250
Total cold run time: 281055 ms
Total hot run time: 174221 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249229337
<details>
<summary>TPC-DS: <b>Total hot run time: 173880 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 901 371 360 360
query2 6452 1843 1842 1842
query3 6631 209 222 209
query4 28361 17498 17398 17398
query5 3664 477 481 477
query6 267 180 173 173
query7 4595 284 287 284
query8 240 199 197 197
query9 8530 2406 2391 2391
query10 444 273 296 273
query11 11383 10047 10076 10047
query12 120 88 86 86
query13 1641 377 367 367
query14 10658 7807 7668 7668
query15 255 167 165 165
query16 7685 477 474 474
query17 1596 576 546 546
query18 1789 287 287 287
query19 201 155 167 155
query20 89 88 86 86
query21 209 135 130 130
query22 4429 3984 3935 3935
query23 34164 33815 33645 33645
query24 10592 3035 2908 2908
query25 637 402 417 402
query26 1111 155 160 155
query27 2379 302 358 302
query28 6935 2078 2073 2073
query29 884 650 629 629
query30 254 155 153 153
query31 959 767 764 764
query32 96 54 57 54
query33 749 319 335 319
query34 986 484 491 484
query35 880 772 805 772
query36 1133 970 981 970
query37 149 84 92 84
query38 2960 2862 2789 2789
query39 937 821 782 782
query40 199 123 116 116
query41 46 44 42 42
query42 116 94 97 94
query43 499 457 461 457
query44 1190 727 721 721
query45 204 174 179 174
query46 1086 794 713 713
query47 1844 1759 1790 1759
query48 376 299 294 294
query49 828 406 415 406
query50 767 397 383 383
query51 6731 6634 6687 6634
query52 101 93 90 90
query53 357 290 296 290
query54 1019 444 441 441
query55 76 75 73 73
query56 282 272 266 266
query57 1132 1047 1029 1029
query58 261 244 262 244
query59 2793 2663 2540 2540
query60 305 283 279 279
query61 98 94 93 93
query62 769 638 645 638
query63 325 290 292 290
query64 9535 2223 1666 1666
query65 3174 3121 3104 3104
query66 760 321 326 321
query67 15690 14972 14955 14955
query68 8047 554 571 554
query69 705 441 391 391
query70 1203 1154 1065 1065
query71 507 288 274 274
query72 8536 6017 5500 5500
query73 1570 320 324 320
query74 6221 5691 5722 5691
query75 4543 2675 2708 2675
query76 4768 996 964 964
query77 797 323 295 295
query78 10179 8932 8985 8932
query79 8283 524 529 524
query80 1104 477 479 477
query81 583 213 221 213
query82 504 141 142 141
query83 290 161 166 161
query84 280 87 90 87
query85 1026 324 304 304
query86 351 298 306 298
query87 3304 3128 3108 3108
query88 4150 2377 2364 2364
query89 542 387 378 378
query90 2072 195 261 195
query91 128 106 101 101
query92 58 48 48 48
query93 6211 510 516 510
query94 1381 298 275 275
query95 403 317 319 317
query96 610 266 268 266
query97 3203 3042 3065 3042
query98 218 203 199 199
query99 1543 1264 1281 1264
Total cold run time: 299828 ms
Total hot run time: 173880 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1691118827
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -115,10 +117,24 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const IColumn& column, const
if (scale > 3) {
uint32_t microsecond = datetime_val.microsecond();
timestamp = (timestamp * 1000000) + microsecond;
+ timestamp -= std::chrono::duration_cast<std::chrono::microseconds>(
+ cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
+ .time_since_epoch())
+ .count();
} else if (scale > 0) {
uint32_t millisecond = datetime_val.microsecond() / 1000;
timestamp = (timestamp * 1000) + millisecond;
+ timestamp -= std::chrono::duration_cast<std::chrono::milliseconds>(
+ cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
+ .time_since_epoch())
+ .count();
+ } else if (scale == 0) {
+ timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
Review Comment:
Should the logic here be removed? It should only require modifying the scale of the TypeDescriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2247986380
<details>
<summary>TPC-DS: <b>Total hot run time: 175241 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 915 380 381 380
query2 6434 1988 1877 1877
query3 6637 211 219 211
query4 28431 17502 17300 17300
query5 3774 487 494 487
query6 277 187 176 176
query7 4582 285 295 285
query8 250 189 201 189
query9 8515 2425 2425 2425
query10 423 286 278 278
query11 10816 10029 10154 10029
query12 124 83 90 83
query13 1628 364 364 364
query14 10059 7962 8192 7962
query15 240 170 176 170
query16 7160 484 472 472
query17 1116 555 531 531
query18 1782 278 280 278
query19 189 148 148 148
query20 91 89 84 84
query21 210 136 130 130
query22 4276 4087 3899 3899
query23 34307 34083 33821 33821
query24 11093 2899 2813 2813
query25 623 389 391 389
query26 712 162 154 154
query27 2252 277 281 277
query28 6421 2088 2082 2082
query29 885 684 658 658
query30 258 159 174 159
query31 984 780 768 768
query32 100 53 53 53
query33 657 358 345 345
query34 879 505 517 505
query35 895 765 766 765
query36 1165 976 981 976
query37 147 84 88 84
query38 2974 2884 2849 2849
query39 852 814 844 814
query40 200 125 121 121
query41 48 46 44 44
query42 122 95 101 95
query43 519 469 462 462
query44 1122 728 754 728
query45 208 175 173 173
query46 1081 716 805 716
query47 1838 1777 1760 1760
query48 384 288 287 287
query49 842 420 423 420
query50 783 394 407 394
query51 6829 6681 6695 6681
query52 110 91 96 91
query53 366 288 296 288
query54 890 466 445 445
query55 77 73 73 73
query56 304 271 278 271
query57 1152 1049 1047 1047
query58 241 256 268 256
query59 2987 2905 2624 2624
query60 305 280 287 280
query61 117 115 116 115
query62 797 663 654 654
query63 321 298 290 290
query64 9226 2317 1743 1743
query65 3161 3112 3138 3112
query66 751 327 329 327
query67 15346 15055 15164 15055
query68 4640 555 556 555
query69 596 340 344 340
query70 1205 1140 1087 1087
query71 407 300 298 298
query72 8978 5824 5923 5824
query73 750 327 325 325
query74 6134 5775 5691 5691
query75 4387 2684 2721 2684
query76 2796 891 934 891
query77 685 314 302 302
query78 9728 9021 9088 9021
query79 2948 536 531 531
query80 1343 482 472 472
query81 583 223 224 223
query82 829 133 131 131
query83 364 169 169 169
query84 273 87 89 87
query85 1839 325 366 325
query86 452 336 326 326
query87 3298 3113 3090 3090
query88 4428 2392 2402 2392
query89 478 395 400 395
query90 1971 191 192 191
query91 132 107 101 101
query92 57 54 53 53
query93 4363 520 516 516
query94 1316 300 288 288
query95 409 319 332 319
query96 617 282 279 279
query97 3184 3047 3052 3047
query98 229 199 192 192
query99 1521 1288 1274 1274
Total cold run time: 284200 ms
Total hot run time: 175241 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2245682848
better add some test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2246718903
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2380428916
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370972737
TeamCity be ut coverage result:
Function Coverage: 37.30% (9619/25787)
Line Coverage: 28.70% (79582/277257)
Region Coverage: 28.16% (41163/146196)
Branch Coverage: 24.79% (20976/84622)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5ad2fd31185d475853b5ff6398eb417e1319b1cf_5ad2fd31185d475853b5ff6398eb417e1319b1cf/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2376141289
<details>
<summary>TPC-H: <b>Total hot run time: 40800 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53b29bdb163a3b6dcc8131338c1927b9f7f985a3, data reload: false
------ Round 1 ----------------------------------
q1 17572 7462 7277 7277
q2 2020 295 281 281
q3 12170 1087 1197 1087
q4 10546 768 744 744
q5 7775 2843 2761 2761
q6 234 150 148 148
q7 1014 631 601 601
q8 9577 1931 1939 1931
q9 7961 6450 6389 6389
q10 6975 2300 2369 2300
q11 443 255 247 247
q12 422 217 216 216
q13 17777 2997 3007 2997
q14 245 216 223 216
q15 568 540 525 525
q16 700 618 609 609
q17 969 572 595 572
q18 7161 6575 6782 6575
q19 1399 949 992 949
q20 469 204 202 202
q21 4046 3213 3172 3172
q22 1095 1001 1013 1001
Total cold run time: 111138 ms
Total hot run time: 40800 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7741 7201 7230 7201
q2 336 241 242 241
q3 3062 3033 2922 2922
q4 2132 1862 1790 1790
q5 5682 5660 5716 5660
q6 233 145 146 145
q7 2210 1805 1809 1805
q8 3325 3493 3513 3493
q9 8867 9028 8960 8960
q10 3538 3554 3581 3554
q11 610 494 499 494
q12 807 610 601 601
q13 8618 3118 3160 3118
q14 319 283 272 272
q15 587 521 521 521
q16 717 681 678 678
q17 1838 1612 1630 1612
q18 8272 7881 7843 7843
q19 1709 1657 1571 1571
q20 2119 1877 1890 1877
q21 5436 5326 5476 5326
q22 1097 1064 1052 1052
Total cold run time: 69255 ms
Total hot run time: 60736 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2378308744
<details>
<summary>TPC-DS: <b>Total hot run time: 191928 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53b29bdb163a3b6dcc8131338c1927b9f7f985a3, data reload: false
query1 958 372 380 372
query2 6527 2203 2063 2063
query3 6693 216 226 216
query4 33863 23421 23481 23421
query5 4321 452 435 435
query6 261 163 158 158
query7 4617 305 317 305
query8 287 217 216 216
query9 9569 2682 2659 2659
query10 481 291 309 291
query11 18144 15094 15292 15094
query12 158 101 97 97
query13 1626 434 403 403
query14 10584 7506 7035 7035
query15 309 176 182 176
query16 7943 456 456 456
query17 1771 597 586 586
query18 1887 308 314 308
query19 375 153 165 153
query20 120 108 111 108
query21 211 106 103 103
query22 4722 4583 4400 4400
query23 34723 34873 34039 34039
query24 11197 2897 2865 2865
query25 670 407 414 407
query26 1557 165 177 165
query27 2796 304 293 293
query28 7918 2445 2441 2441
query29 978 437 431 431
query30 316 168 152 152
query31 1011 781 815 781
query32 100 57 59 57
query33 788 310 309 309
query34 971 500 503 500
query35 902 750 735 735
query36 1123 954 921 921
query37 152 90 89 89
query38 3991 3986 3893 3893
query39 1479 1432 1545 1432
query40 288 101 100 100
query41 55 52 50 50
query42 125 97 101 97
query43 541 496 500 496
query44 1259 825 800 800
query45 197 164 170 164
query46 1135 725 718 718
query47 1969 1861 1912 1861
query48 472 376 392 376
query49 1190 417 415 415
query50 839 405 406 405
query51 7171 6915 6924 6915
query52 99 89 90 89
query53 258 188 186 186
query54 1362 480 473 473
query55 83 80 81 80
query56 307 271 257 257
query57 1234 1119 1130 1119
query58 252 240 251 240
query59 3281 3063 3133 3063
query60 288 270 272 270
query61 105 104 103 103
query62 832 669 683 669
query63 221 200 186 186
query64 5176 637 612 612
query65 3288 3185 3201 3185
query66 1129 315 306 306
query67 15995 15643 15986 15643
query68 5061 551 556 551
query69 453 299 307 299
query70 1205 1127 1111 1111
query71 344 275 274 274
query72 7036 4010 3933 3933
query73 772 336 348 336
query74 10139 8889 9085 8889
query75 3395 2672 2687 2672
query76 2976 927 935 927
query77 472 295 298 295
query78 10612 9596 9645 9596
query79 3393 612 611 611
query80 1235 444 443 443
query81 577 247 242 242
query82 1182 138 136 136
query83 249 137 147 137
query84 309 90 74 74
query85 1569 293 277 277
query86 489 309 308 308
query87 4415 4357 4319 4319
query88 4042 2388 2381 2381
query89 414 284 286 284
query90 1953 188 190 188
query91 184 147 142 142
query92 70 49 49 49
query93 2824 562 550 550
query94 854 302 302 302
query95 361 260 254 254
query96 632 284 288 284
query97 3382 3161 3114 3114
query98 230 204 193 193
query99 1628 1314 1324 1314
Total cold run time: 307707 ms
Total hot run time: 191928 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254504827
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254521290
<details>
<summary>TPC-DS: <b>Total hot run time: 173373 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0d988836fde4b274f87c6cbf6a5d5347e4c5b467, data reload: false
query1 910 379 375 375
query2 6453 2000 1909 1909
query3 6639 211 215 211
query4 27461 17509 17336 17336
query5 3675 481 488 481
query6 259 162 177 162
query7 4574 304 302 302
query8 239 185 195 185
query9 8511 2477 2422 2422
query10 437 290 263 263
query11 11780 10163 10037 10037
query12 113 87 84 84
query13 1621 388 371 371
query14 9627 7222 7644 7222
query15 212 162 163 162
query16 7519 490 466 466
query17 1144 559 531 531
query18 1799 291 281 281
query19 192 140 138 138
query20 92 81 83 81
query21 224 107 102 102
query22 4242 3977 3845 3845
query23 34105 33773 33768 33768
query24 11044 2894 2911 2894
query25 603 423 437 423
query26 718 158 162 158
query27 2317 276 281 276
query28 6255 2150 2117 2117
query29 784 427 429 427
query30 259 156 153 153
query31 995 754 782 754
query32 93 57 53 53
query33 650 349 336 336
query34 901 477 487 477
query35 859 753 787 753
query36 1119 953 961 953
query37 141 81 84 81
query38 2924 2902 2827 2827
query39 864 802 835 802
query40 186 110 109 109
query41 45 47 43 43
query42 112 100 92 92
query43 529 486 477 477
query44 1087 719 717 717
query45 209 177 181 177
query46 1096 742 719 719
query47 1822 1748 1754 1748
query48 382 295 286 286
query49 841 408 409 408
query50 796 406 408 406
query51 6869 6776 6633 6633
query52 104 90 92 90
query53 255 187 174 174
query54 834 444 443 443
query55 76 74 77 74
query56 292 255 274 255
query57 1143 1061 1049 1049
query58 268 306 270 270
query59 3132 2652 2756 2652
query60 315 288 281 281
query61 97 96 99 96
query62 785 660 642 642
query63 214 176 175 175
query64 9185 2259 1698 1698
query65 3175 3112 3097 3097
query66 733 355 346 346
query67 15589 14951 14893 14893
query68 6622 567 567 567
query69 728 376 316 316
query70 1199 1139 1139 1139
query71 469 268 283 268
query72 8361 5700 5667 5667
query73 848 330 326 326
query74 6090 5670 5659 5659
query75 3766 2666 2678 2666
query76 3981 1018 956 956
query77 690 301 312 301
query78 9747 9045 8970 8970
query79 3452 528 527 527
query80 1150 488 490 488
query81 564 215 215 215
query82 453 139 136 136
query83 204 172 176 172
query84 269 80 82 80
query85 864 312 301 301
query86 337 315 302 302
query87 3237 3077 3084 3077
query88 4326 2489 2486 2486
query89 414 296 287 287
query90 1887 197 195 195
query91 126 101 98 98
query92 57 48 48 48
query93 4795 546 548 546
query94 864 291 290 290
query95 369 340 263 263
query96 613 279 275 275
query97 3154 3024 3053 3024
query98 216 197 193 193
query99 1495 1267 1288 1267
Total cold run time: 283872 ms
Total hot run time: 173373 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255614182
<details>
<summary>TPC-DS: <b>Total hot run time: 170012 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a009a163f2dacca36efbf95476750a5a9c9cfe57, data reload: false
query1 903 372 368 368
query2 6487 1679 1647 1647
query3 6686 210 223 210
query4 19783 17562 17339 17339
query5 4247 520 507 507
query6 297 170 154 154
query7 4618 298 300 298
query8 243 186 209 186
query9 8526 2427 2439 2427
query10 452 295 272 272
query11 10555 10163 10058 10058
query12 142 87 89 87
query13 1631 379 374 374
query14 9594 7888 7774 7774
query15 215 163 164 163
query16 7111 473 458 458
query17 966 566 556 556
query18 1923 296 293 293
query19 206 146 149 146
query20 91 85 89 85
query21 211 100 101 100
query22 4231 4001 3970 3970
query23 33749 32993 32885 32885
query24 10373 3128 3138 3128
query25 726 406 430 406
query26 1827 157 160 157
query27 2858 276 283 276
query28 6947 2011 1987 1987
query29 1391 444 440 440
query30 283 151 152 151
query31 915 764 761 761
query32 101 56 59 56
query33 706 335 329 329
query34 917 486 487 486
query35 871 710 731 710
query36 992 850 880 850
query37 314 84 79 79
query38 2894 2806 2786 2786
query39 878 814 821 814
query40 291 116 117 116
query41 51 47 52 47
query42 125 110 105 105
query43 463 401 410 401
query44 1213 803 717 717
query45 204 174 177 174
query46 1089 830 785 785
query47 1809 1728 1741 1728
query48 356 293 292 292
query49 1180 417 431 417
query50 914 456 442 442
query51 6671 6771 6591 6591
query52 101 92 88 88
query53 256 188 175 175
query54 658 455 461 455
query55 77 86 76 76
query56 277 257 264 257
query57 1134 1020 1033 1020
query58 285 273 270 270
query59 2558 2687 2466 2466
query60 286 271 281 271
query61 99 117 97 97
query62 917 668 678 668
query63 210 190 192 190
query64 5787 1922 1917 1917
query65 3158 3098 3075 3075
query66 1452 337 330 330
query67 15290 14826 15237 14826
query68 4739 556 583 556
query69 451 304 300 300
query70 1102 1101 1048 1048
query71 454 278 271 271
query72 7173 2684 2507 2507
query73 757 332 329 329
query74 6090 5706 5627 5627
query75 3413 2732 2754 2732
query76 2825 1329 1416 1329
query77 436 314 307 307
query78 9480 9029 8832 8832
query79 2471 529 527 527
query80 975 503 502 502
query81 558 228 226 226
query82 821 136 126 126
query83 247 172 179 172
query84 274 80 79 79
query85 1630 364 307 307
query86 474 296 303 296
query87 3301 3094 3151 3094
query88 3907 2480 2463 2463
query89 389 283 289 283
query90 1897 194 187 187
query91 126 103 103 103
query92 59 52 53 52
query93 2234 629 626 626
query94 906 315 283 283
query95 379 274 272 272
query96 599 284 278 278
query97 3251 3036 3032 3032
query98 220 200 205 200
query99 1701 1317 1297 1297
Total cold run time: 266110 ms
Total hot run time: 170012 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255546399
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2310104248
在等 flink connector 和 spark connector 发版，要不流水线过不了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2378278101
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244141116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249561515
<details>
<summary>ClickBench: <b>Total hot run time: 30.74 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.05 0.04
query3 0.22 0.05 0.04
query4 1.68 0.07 0.07
query5 0.49 0.47 0.50
query6 1.13 0.74 0.73
query7 0.02 0.01 0.01
query8 0.05 0.05 0.04
query9 0.55 0.49 0.47
query10 0.54 0.55 0.55
query11 0.15 0.12 0.11
query12 0.14 0.12 0.12
query13 0.59 0.58 0.58
query14 0.76 0.78 0.78
query15 0.84 0.83 0.83
query16 0.38 0.37 0.36
query17 1.02 0.98 0.98
query18 0.23 0.22 0.21
query19 1.90 1.77 1.77
query20 0.01 0.00 0.01
query21 15.38 0.76 0.64
query22 3.85 6.52 2.06
query23 18.27 1.39 1.31
query24 2.09 0.25 0.21
query25 0.17 0.09 0.08
query26 0.30 0.21 0.21
query27 0.45 0.24 0.23
query28 13.26 1.01 0.99
query29 12.66 3.29 3.24
query30 0.26 0.06 0.05
query31 2.88 0.38 0.39
query32 3.27 0.49 0.48
query33 2.91 2.88 2.92
query34 17.17 4.36 4.31
query35 4.42 4.43 4.46
query36 0.66 0.46 0.47
query37 0.18 0.16 0.16
query38 0.15 0.15 0.16
query39 0.04 0.03 0.04
query40 0.15 0.12 0.13
query41 0.09 0.05 0.05
query42 0.06 0.05 0.04
query43 0.05 0.04 0.04
Total cold run time: 109.54 s
Total hot run time: 30.74 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2248415608
<details>
<summary>TPC-DS: <b>Total hot run time: 173879 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 915 378 372 372
query2 6476 1886 1826 1826
query3 6638 212 219 212
query4 25773 17520 17453 17453
query5 3579 487 471 471
query6 261 161 170 161
query7 4600 296 290 290
query8 242 201 190 190
query9 8458 2409 2371 2371
query10 443 302 286 286
query11 10918 10128 10019 10019
query12 117 85 82 82
query13 1644 381 367 367
query14 10396 7531 7794 7531
query15 261 160 163 160
query16 7804 476 493 476
query17 1580 541 535 535
query18 2031 273 269 269
query19 227 153 143 143
query20 85 81 80 80
query21 207 128 124 124
query22 4323 4133 4029 4029
query23 34128 33667 33560 33560
query24 8148 2946 2909 2909
query25 599 389 372 372
query26 712 162 158 158
query27 2105 281 290 281
query28 6077 2064 2094 2064
query29 902 640 656 640
query30 258 151 153 151
query31 979 772 766 766
query32 96 62 54 54
query33 598 354 350 350
query34 903 486 495 486
query35 845 760 789 760
query36 1152 984 993 984
query37 145 82 82 82
query38 2970 2834 2814 2814
query39 911 892 833 833
query40 224 123 117 117
query41 45 42 42 42
query42 116 97 99 97
query43 507 451 457 451
query44 1079 724 748 724
query45 211 180 173 173
query46 1083 734 726 726
query47 1858 1783 1771 1771
query48 374 303 296 296
query49 825 404 414 404
query50 768 382 401 382
query51 6765 6755 6607 6607
query52 102 88 97 88
query53 389 309 297 297
query54 654 459 445 445
query55 77 75 74 74
query56 303 274 281 274
query57 1126 1027 1025 1025
query58 246 260 255 255
query59 2797 2610 2569 2569
query60 300 276 305 276
query61 95 93 95 93
query62 789 648 645 645
query63 322 296 296 296
query64 9123 2234 1724 1724
query65 3182 3105 3145 3105
query66 751 329 338 329
query67 15543 14982 15108 14982
query68 4497 558 563 558
query69 587 408 364 364
query70 1201 1154 1163 1154
query71 369 277 280 277
query72 7678 5463 6033 5463
query73 764 331 324 324
query74 6092 5649 5701 5649
query75 3429 2689 2678 2678
query76 2349 922 964 922
query77 702 307 313 307
query78 10264 9083 8940 8940
query79 2746 528 528 528
query80 1934 506 484 484
query81 588 221 230 221
query82 886 146 139 139
query83 324 170 165 165
query84 265 86 86 86
query85 1639 312 298 298
query86 473 316 327 316
query87 3273 3074 3076 3074
query88 3906 2380 2364 2364
query89 495 384 386 384
query90 1756 191 197 191
query91 132 102 102 102
query92 61 50 47 47
query93 2723 516 521 516
query94 1169 286 276 276
query95 413 319 310 310
query96 608 278 275 275
query97 3222 3025 3066 3025
query98 226 200 190 190
query99 1734 1274 1304 1274
Total cold run time: 274665 ms
Total hot run time: 173879 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2252031792
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2250369231
<details>
<summary>TPC-DS: <b>Total hot run time: 173622 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d2024fd6f9dfa859427c6a2f4e4bc7dba4883866, data reload: false
query1 933 392 371 371
query2 6419 1951 1819 1819
query3 6646 209 220 209
query4 28276 17776 17352 17352
query5 3741 475 504 475
query6 295 158 159 158
query7 4596 289 291 289
query8 233 193 184 184
query9 8432 2428 2402 2402
query10 436 291 269 269
query11 11543 9954 9927 9927
query12 119 89 84 84
query13 1620 367 353 353
query14 10354 8686 7532 7532
query15 221 173 170 170
query16 7475 470 448 448
query17 1518 590 532 532
query18 1230 296 274 274
query19 196 140 145 140
query20 93 84 83 83
query21 206 101 97 97
query22 4379 4096 4042 4042
query23 34195 33929 33430 33430
query24 11107 2946 2966 2946
query25 627 401 416 401
query26 1088 151 157 151
query27 2300 277 288 277
query28 7042 2082 2075 2075
query29 756 478 422 422
query30 257 152 154 152
query31 995 797 755 755
query32 98 52 55 52
query33 751 328 344 328
query34 895 485 487 485
query35 886 798 767 767
query36 1121 911 964 911
query37 143 83 86 83
query38 2912 2825 2814 2814
query39 874 804 823 804
query40 201 119 118 118
query41 52 45 45 45
query42 123 96 98 96
query43 497 462 476 462
query44 1213 732 739 732
query45 215 181 176 176
query46 1108 761 743 743
query47 1876 1783 1818 1783
query48 373 292 297 292
query49 845 408 416 408
query50 799 414 408 408
query51 6826 6637 6635 6635
query52 100 87 93 87
query53 250 184 185 184
query54 908 442 437 437
query55 73 74 73 73
query56 299 275 274 274
query57 1119 1040 1038 1038
query58 266 261 287 261
query59 2987 3020 2848 2848
query60 326 296 309 296
query61 98 95 98 95
query62 822 678 645 645
query63 213 183 180 180
query64 9527 2260 1718 1718
query65 3182 3141 3117 3117
query66 728 326 328 326
query67 15405 15112 14808 14808
query68 4699 567 563 563
query69 637 417 304 304
query70 1157 1141 1079 1079
query71 421 281 281 281
query72 7743 5853 5770 5770
query73 783 328 328 328
query74 6075 5719 5631 5631
query75 3395 2679 2658 2658
query76 2857 973 865 865
query77 628 307 305 305
query78 9666 9915 9351 9351
query79 3396 523 528 523
query80 1882 490 493 490
query81 589 217 220 217
query82 833 133 140 133
query83 352 181 180 180
query84 269 81 81 81
query85 1619 329 304 304
query86 338 287 288 287
query87 3289 3076 3096 3076
query88 4472 2387 2398 2387
query89 423 292 290 290
query90 1730 194 190 190
query91 129 103 101 101
query92 64 49 51 49
query93 4901 549 545 545
query94 685 289 294 289
query95 353 260 258 258
query96 615 272 282 272
query97 3211 2990 3030 2990
query98 243 218 201 201
query99 1563 1276 1284 1276
Total cold run time: 284456 ms
Total hot run time: 173622 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254467721
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254517987
<details>
<summary>TPC-H: <b>Total hot run time: 39691 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0d988836fde4b274f87c6cbf6a5d5347e4c5b467, data reload: false
------ Round 1 ----------------------------------
q1 17927 4742 4288 4288
q2 2036 197 197 197
q3 10482 1267 1147 1147
q4 10161 758 726 726
q5 7546 2799 2714 2714
q6 220 137 136 136
q7 964 610 607 607
q8 9217 1954 1939 1939
q9 8690 6577 6552 6552
q10 8829 3784 3801 3784
q11 446 248 247 247
q12 405 224 213 213
q13 18553 2956 2992 2956
q14 275 236 247 236
q15 530 485 494 485
q16 522 382 382 382
q17 997 651 758 651
q18 8216 7519 7523 7519
q19 5301 1077 1123 1077
q20 678 342 349 342
q21 5074 3218 3300 3218
q22 342 289 275 275
Total cold run time: 117411 ms
Total hot run time: 39691 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4539 4288 4259 4259
q2 375 259 267 259
q3 3025 2871 2918 2871
q4 1987 1705 1726 1705
q5 5671 5565 5546 5546
q6 226 130 130 130
q7 2220 1894 1845 1845
q8 3274 3494 3474 3474
q9 8870 8692 8969 8692
q10 4101 3874 3763 3763
q11 577 523 494 494
q12 819 689 638 638
q13 17196 3144 3165 3144
q14 311 305 303 303
q15 515 481 480 480
q16 510 436 427 427
q17 1839 1529 1539 1529
q18 8116 8253 7850 7850
q19 1768 1627 1650 1627
q20 2100 1900 1868 1868
q21 7205 4828 4767 4767
q22 593 486 512 486
Total cold run time: 75837 ms
Total hot run time: 56157 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370996109
<details>
<summary>ClickBench: <b>Total hot run time: 33.44 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5ad2fd31185d475853b5ff6398eb417e1319b1cf, data reload: false
query1 0.05 0.04 0.04
query2 0.06 0.02 0.03
query3 0.23 0.06 0.06
query4 1.64 0.10 0.10
query5 0.51 0.53 0.53
query6 1.12 0.73 0.72
query7 0.03 0.02 0.02
query8 0.04 0.02 0.04
query9 0.58 0.51 0.50
query10 0.55 0.57 0.56
query11 0.15 0.10 0.10
query12 0.14 0.13 0.11
query13 0.60 0.60 0.59
query14 2.96 2.96 2.99
query15 0.89 0.83 0.83
query16 0.37 0.39 0.36
query17 1.07 1.07 1.04
query18 0.24 0.22 0.23
query19 1.94 1.92 2.02
query20 0.01 0.01 0.01
query21 15.35 0.58 0.58
query22 3.28 1.89 1.89
query23 17.48 0.81 0.82
query24 2.75 1.36 1.80
query25 0.31 0.04 0.11
query26 0.53 0.14 0.16
query27 0.05 0.04 0.04
query28 10.08 1.10 1.08
query29 12.59 3.22 3.21
query30 0.25 0.06 0.06
query31 2.87 0.38 0.37
query32 3.29 0.48 0.47
query33 3.00 3.00 3.04
query34 17.33 4.48 4.43
query35 4.53 4.57 4.44
query36 0.64 0.50 0.48
query37 0.08 0.06 0.06
query38 0.04 0.04 0.04
query39 0.03 0.03 0.02
query40 0.16 0.13 0.13
query41 0.08 0.03 0.03
query42 0.04 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 107.97 s
Total hot run time: 33.44 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2376168831
TeamCity be ut coverage result:
Function Coverage: 37.28% (9624/25813)
Line Coverage: 28.69% (79649/277598)
Region Coverage: 28.12% (41183/146479)
Branch Coverage: 24.75% (20977/84754)
Coverage Report: http://coverage.selectdb-in.cc/coverage/53b29bdb163a3b6dcc8131338c1927b9f7f985a3_53b29bdb163a3b6dcc8131338c1927b9f7f985a3/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370403433
TeamCity be ut coverage result:
Function Coverage: 37.27% (9606/25774)
Line Coverage: 28.69% (79533/277187)
Region Coverage: 28.13% (41127/146190)
Branch Coverage: 24.78% (20969/84624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/893c34c4a2f2cabfc98916e504aad123f1a6862b_893c34c4a2f2cabfc98916e504aad123f1a6862b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370453254
<details>
<summary>TPC-DS: <b>Total hot run time: 192428 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 893c34c4a2f2cabfc98916e504aad123f1a6862b, data reload: false
query1 964 385 376 376
query2 6369 2119 2024 2024
query3 8682 192 201 192
query4 33878 23540 23427 23427
query5 3594 458 475 458
query6 263 169 183 169
query7 4188 298 305 298
query8 280 215 215 215
query9 9616 2684 2667 2667
query10 475 279 288 279
query11 17959 15264 15311 15264
query12 145 101 98 98
query13 1553 421 426 421
query14 10397 7468 7407 7407
query15 246 170 173 170
query16 7912 489 497 489
query17 1616 605 580 580
query18 2116 333 333 333
query19 347 156 157 156
query20 123 119 114 114
query21 215 108 107 107
query22 4858 4448 4336 4336
query23 35309 34645 34570 34570
query24 11216 2886 2876 2876
query25 631 414 413 413
query26 1153 163 163 163
query27 2247 301 313 301
query28 7641 2454 2442 2442
query29 821 434 433 433
query30 254 160 160 160
query31 1012 779 817 779
query32 97 53 55 53
query33 758 293 289 289
query34 911 511 490 490
query35 901 767 724 724
query36 1112 947 944 944
query37 156 96 79 79
query38 3968 3915 3843 3843
query39 1522 1422 1435 1422
query40 209 95 103 95
query41 50 47 47 47
query42 118 97 94 94
query43 525 493 497 493
query44 1267 825 814 814
query45 195 168 167 167
query46 1130 730 719 719
query47 1916 1847 1857 1847
query48 467 373 370 370
query49 904 418 405 405
query50 823 410 408 408
query51 6895 7044 6948 6948
query52 101 108 84 84
query53 257 178 173 173
query54 1225 453 456 453
query55 76 75 77 75
query56 288 253 243 243
query57 1198 1097 1122 1097
query58 245 237 222 222
query59 3199 3024 3010 3010
query60 290 263 304 263
query61 123 109 98 98
query62 850 661 653 653
query63 221 193 186 186
query64 3947 637 647 637
query65 3266 3232 3209 3209
query66 784 299 311 299
query67 16053 15534 15449 15449
query68 4823 582 563 563
query69 582 290 300 290
query70 1224 1133 1137 1133
query71 429 267 272 267
query72 7689 3993 4057 3993
query73 764 343 349 343
query74 10630 8971 8972 8971
query75 4216 2665 2658 2658
query76 3662 953 918 918
query77 736 312 280 280
query78 10090 9356 9334 9334
query79 2682 600 609 600
query80 1032 433 440 433
query81 567 241 240 240
query82 691 136 139 136
query83 362 135 137 135
query84 284 81 79 79
query85 1345 309 283 283
query86 444 280 303 280
query87 4442 4373 4407 4373
query88 3925 2422 2368 2368
query89 402 286 283 283
query90 1961 186 185 185
query91 174 167 145 145
query92 67 51 49 49
query93 2358 550 554 550
query94 1057 297 295 295
query95 358 254 250 250
query96 616 281 278 278
query97 3288 3116 3153 3116
query98 235 203 205 203
query99 1552 1278 1328 1278
Total cold run time: 304814 ms
Total hot run time: 192428 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370876414
<details>
<summary>ClickBench: <b>Total hot run time: 32.19 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 893c34c4a2f2cabfc98916e504aad123f1a6862b, data reload: false
query1 0.04 0.04 0.04
query2 0.07 0.03 0.03
query3 0.23 0.06 0.06
query4 1.65 0.10 0.10
query5 0.52 0.52 0.51
query6 1.13 0.74 0.72
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.57 0.52 0.49
query10 0.56 0.56 0.56
query11 0.14 0.11 0.11
query12 0.13 0.11 0.11
query13 0.61 0.61 0.59
query14 2.98 2.94 3.02
query15 0.91 0.83 0.83
query16 0.39 0.42 0.38
query17 1.07 1.06 1.04
query18 0.25 0.22 0.22
query19 2.01 1.83 2.01
query20 0.01 0.00 0.00
query21 15.35 0.60 0.58
query22 2.72 2.68 1.40
query23 17.15 0.86 0.90
query24 3.23 0.53 1.39
query25 0.26 0.16 0.19
query26 0.31 0.15 0.13
query27 0.05 0.04 0.04
query28 10.66 1.08 1.07
query29 12.54 3.21 3.19
query30 0.25 0.06 0.06
query31 2.89 0.38 0.40
query32 3.28 0.47 0.47
query33 2.98 3.03 3.08
query34 16.95 4.43 4.46
query35 4.48 4.51 4.48
query36 0.69 0.50 0.49
query37 0.08 0.06 0.06
query38 0.05 0.03 0.03
query39 0.03 0.02 0.02
query40 0.16 0.13 0.12
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.02 0.02
Total cold run time: 107.58 s
Total hot run time: 32.19 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2380460452
TeamCity be ut coverage result:
Function Coverage: 37.29% (9626/25811)
Line Coverage: 28.71% (79713/277636)
Region Coverage: 28.13% (41211/146480)
Branch Coverage: 24.75% (20989/84788)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5d84c24b8a638d6a756ce24eab65537774bf5e8f_5d84c24b8a638d6a756ce24eab65537774bf5e8f/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244145023
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2245538734
<details>
<summary>TPC-DS: <b>Total hot run time: 173892 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 03499b884bdef539533d9c24747f4ee89e53a6e2, data reload: false
query1 910 371 374 371
query2 6363 1804 1811 1804
query3 6647 206 221 206
query4 27307 17478 17248 17248
query5 3495 489 492 489
query6 268 184 171 171
query7 4581 291 299 291
query8 250 201 187 187
query9 8459 2443 2428 2428
query10 445 282 310 282
query11 11608 10058 10178 10058
query12 119 91 85 85
query13 1640 381 377 377
query14 9411 7822 7821 7821
query15 236 168 171 168
query16 7642 488 474 474
query17 1556 571 522 522
query18 1753 277 268 268
query19 202 168 154 154
query20 90 83 79 79
query21 210 125 131 125
query22 4281 3972 3977 3972
query23 33990 33483 33573 33483
query24 7174 2938 3028 2938
query25 605 385 391 385
query26 698 154 156 154
query27 2334 277 304 277
query28 5465 2098 2107 2098
query29 902 646 692 646
query30 271 148 150 148
query31 971 744 767 744
query32 98 56 58 56
query33 570 338 333 333
query34 909 506 500 500
query35 885 768 803 768
query36 1091 989 966 966
query37 142 80 82 80
query38 2983 2829 2849 2829
query39 895 832 817 817
query40 202 120 123 120
query41 47 45 44 44
query42 127 129 103 103
query43 504 484 450 450
query44 1079 738 731 731
query45 211 161 162 161
query46 1088 750 728 728
query47 1870 1784 1746 1746
query48 361 293 297 293
query49 842 411 408 408
query50 781 388 389 388
query51 6838 6640 6796 6640
query52 104 95 91 91
query53 361 303 300 300
query54 585 450 455 450
query55 77 73 80 73
query56 285 269 268 268
query57 1109 1050 1083 1050
query58 259 250 255 250
query59 2825 2550 2526 2526
query60 298 279 281 279
query61 98 92 92 92
query62 784 639 658 639
query63 324 299 299 299
query64 9199 2230 1691 1691
query65 3207 3088 3104 3088
query66 755 326 333 326
query67 15509 14996 14911 14911
query68 4519 557 552 552
query69 568 443 363 363
query70 1191 1165 1138 1138
query71 381 288 280 280
query72 7093 5600 6158 5600
query73 752 327 329 327
query74 6070 5775 5639 5639
query75 3344 2707 2735 2707
query76 2166 834 1023 834
query77 515 306 298 298
query78 10419 8997 8919 8919
query79 2514 535 549 535
query80 2532 485 496 485
query81 606 223 224 223
query82 839 132 136 132
query83 308 169 170 169
query84 261 94 88 88
query85 1872 306 299 299
query86 469 311 313 311
query87 3280 3110 3085 3085
query88 4131 2391 2389 2389
query89 477 384 400 384
query90 1715 202 195 195
query91 131 100 103 100
query92 59 48 50 48
query93 3238 515 515 515
query94 785 280 298 280
query95 411 382 321 321
query96 615 278 269 269
query97 3190 3057 3034 3034
query98 227 203 192 192
query99 1532 1262 1234 1234
Total cold run time: 273395 ms
Total hot run time: 173892 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2246716292
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249645732
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2252027470
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249666440
<details>
<summary>TPC-H: <b>Total hot run time: 40224 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec848b55520d1a4c70c338b096ea396162b3fed2, data reload: false
------ Round 1 ----------------------------------
q1 18849 4440 4411 4411
q2 2799 198 201 198
q3 12542 1187 1153 1153
q4 10592 829 712 712
q5 7590 2689 2671 2671
q6 229 141 137 137
q7 953 598 593 593
q8 9219 2078 2097 2078
q9 8620 6588 6591 6588
q10 8805 3778 3758 3758
q11 448 232 233 232
q12 401 220 220 220
q13 17749 2981 2972 2972
q14 271 241 237 237
q15 524 479 487 479
q16 484 379 374 374
q17 961 722 672 672
q18 8119 7581 7465 7465
q19 8546 1466 1493 1466
q20 769 328 320 320
q21 4885 3202 3310 3202
q22 347 288 286 286
Total cold run time: 123702 ms
Total hot run time: 40224 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4426 4256 4241 4241
q2 377 271 270 270
q3 2999 2736 2801 2736
q4 1910 1585 1570 1570
q5 5293 5340 5344 5340
q6 219 134 135 134
q7 2116 1730 1752 1730
q8 3252 3338 3308 3308
q9 8431 8414 8449 8414
q10 3882 3651 3734 3651
q11 565 510 482 482
q12 746 603 591 591
q13 17409 3011 2961 2961
q14 306 264 266 264
q15 525 477 468 468
q16 466 425 404 404
q17 1749 1489 1472 1472
q18 7582 7402 7354 7354
q19 1662 1661 1599 1599
q20 2020 1788 1789 1788
q21 4836 4648 4588 4588
q22 580 488 502 488
Total cold run time: 71351 ms
Total hot run time: 53853 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2245455894
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249635287
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255261124
<details>
<summary>TPC-DS: <b>Total hot run time: 169624 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 98f27de0d49036043179bc3e045b0b8899b5bdc0, data reload: false
query1 914 372 367 367
query2 6477 1701 1698 1698
query3 6684 213 217 213
query4 20354 17566 17240 17240
query5 4304 507 513 507
query6 279 188 170 170
query7 4603 301 290 290
query8 244 199 210 199
query9 8510 2424 2410 2410
query10 429 279 266 266
query11 10609 10158 9886 9886
query12 140 91 90 90
query13 1649 404 376 376
query14 10469 7667 8356 7667
query15 203 167 164 164
query16 7122 476 442 442
query17 968 569 577 569
query18 1937 299 290 290
query19 197 157 189 157
query20 94 87 84 84
query21 208 99 99 99
query22 4219 4011 4112 4011
query23 33634 32905 32976 32905
query24 10498 3099 3010 3010
query25 688 377 403 377
query26 1756 156 151 151
query27 2908 276 277 276
query28 6960 1998 1982 1982
query29 1345 417 425 417
query30 287 149 148 148
query31 961 744 757 744
query32 99 54 54 54
query33 702 314 328 314
query34 919 487 487 487
query35 898 726 741 726
query36 992 834 869 834
query37 295 78 77 77
query38 2871 2773 2761 2761
query39 866 801 804 801
query40 279 111 114 111
query41 47 48 44 44
query42 127 102 97 97
query43 459 411 418 411
query44 1189 722 726 722
query45 204 177 176 176
query46 1086 802 794 794
query47 1806 1718 1728 1718
query48 376 297 291 291
query49 1173 433 435 433
query50 898 442 443 442
query51 6881 6709 6675 6675
query52 104 88 97 88
query53 256 185 175 175
query54 645 455 459 455
query55 75 76 73 73
query56 272 251 259 251
query57 1130 1030 1039 1030
query58 275 259 264 259
query59 2611 2308 2483 2308
query60 289 275 271 271
query61 100 94 98 94
query62 928 656 670 656
query63 212 183 184 183
query64 5875 1926 1886 1886
query65 3178 3089 3093 3089
query66 1435 330 328 328
query67 15510 14945 14928 14928
query68 4356 579 590 579
query69 447 307 294 294
query70 1109 1071 1044 1044
query71 409 321 272 272
query72 7237 2704 2536 2536
query73 770 331 338 331
query74 6112 5583 5590 5583
query75 3424 2719 2732 2719
query76 2655 1315 1364 1315
query77 500 318 316 316
query78 9509 8966 8897 8897
query79 1713 539 533 533
query80 1083 515 506 506
query81 551 224 224 224
query82 1112 130 129 129
query83 263 171 174 171
query84 272 81 79 79
query85 1301 317 299 299
query86 408 312 293 293
query87 3325 3111 3126 3111
query88 3062 2501 2507 2501
query89 388 297 284 284
query90 1826 194 189 189
query91 125 104 104 104
query92 64 53 52 52
query93 1546 631 635 631
query94 888 307 306 306
query95 393 279 278 278
query96 600 284 283 283
query97 3208 3024 3058 3024
query98 217 205 207 205
query99 1678 1292 1289 1289
Total cold run time: 265263 ms
Total hot run time: 169624 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2247684098
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1688107589
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -112,13 +114,23 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const IColumn& column, const
binary_cast<UInt64, DateV2Value<DateTimeV2ValueType>>(col_data[i]);
datetime_val.unix_timestamp(×tamp, ctz);
- if (scale > 3) {
+ if (scale > 0) {
uint32_t microsecond = datetime_val.microsecond();
- timestamp = (timestamp * 1000000) + microsecond;
- } else if (scale > 0) {
- uint32_t millisecond = datetime_val.microsecond() / 1000;
- timestamp = (timestamp * 1000) + millisecond;
+
+ if (scale > 3) {
+ timestamp = (timestamp * 1000000) + microsecond;
+ } else {
+ uint32_t millisecond = microsecond / 1000;
+ timestamp = (timestamp * 1000) + millisecond;
+ }
+ } else {
+ timestamp *= 1000000;
}
+ timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
Review Comment:
sub `1970` timestamp does not seem to be the root cause,
it seems to be a problem caused by incorrect `DATETIME` `scale`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2245436820
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2242698338
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2304522931
<details>
<summary>TPC-H: <b>Total hot run time: 37605 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 491fd64bc5e55944a0e878b69db16b865936869c, data reload: false
------ Round 1 ----------------------------------
q1 17604 4361 4280 4280
q2 2016 182 177 177
q3 11829 983 1077 983
q4 10518 724 721 721
q5 7765 2812 2762 2762
q6 228 138 135 135
q7 981 607 592 592
q8 9325 2063 2046 2046
q9 7099 6521 6547 6521
q10 6990 2256 2204 2204
q11 465 237 239 237
q12 390 219 215 215
q13 17899 3024 3047 3024
q14 285 238 223 223
q15 513 482 489 482
q16 494 402 385 385
q17 972 689 648 648
q18 7339 6896 6875 6875
q19 1390 1018 934 934
q20 680 329 328 328
q21 4067 2839 3062 2839
q22 1112 1027 994 994
Total cold run time: 109961 ms
Total hot run time: 37605 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4360 4299 4306 4299
q2 387 273 275 273
q3 2878 2698 2678 2678
q4 1897 1630 1656 1630
q5 5510 5702 5695 5695
q6 223 130 132 130
q7 2247 1844 1855 1844
q8 3342 3423 3417 3417
q9 8864 8738 8747 8738
q10 3556 3412 3372 3372
q11 617 516 514 514
q12 826 662 674 662
q13 13390 3383 3346 3346
q14 336 314 299 299
q15 540 484 506 484
q16 521 458 463 458
q17 1869 1588 1528 1528
q18 8222 7622 8042 7622
q19 1714 1588 1578 1578
q20 2126 1933 1936 1933
q21 5761 5467 5626 5467
q22 1183 1064 1039 1039
Total cold run time: 70369 ms
Total hot run time: 57006 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2304557365
<details>
<summary>ClickBench: <b>Total hot run time: 31.14 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 491fd64bc5e55944a0e878b69db16b865936869c, data reload: false
query1 0.05 0.05 0.04
query2 0.08 0.04 0.04
query3 0.22 0.06 0.05
query4 1.66 0.09 0.09
query5 0.52 0.51 0.50
query6 1.13 0.73 0.72
query7 0.03 0.02 0.01
query8 0.05 0.05 0.05
query9 0.55 0.48 0.48
query10 0.55 0.53 0.53
query11 0.16 0.11 0.12
query12 0.15 0.13 0.12
query13 0.61 0.58 0.59
query14 0.77 0.80 0.78
query15 0.85 0.82 0.82
query16 0.36 0.39 0.38
query17 0.98 1.01 1.08
query18 0.21 0.19 0.20
query19 1.91 1.87 1.78
query20 0.01 0.01 0.02
query21 15.39 0.67 0.64
query22 3.87 7.11 2.30
query23 18.30 1.30 1.21
query24 2.15 0.23 0.22
query25 0.15 0.09 0.08
query26 0.27 0.18 0.17
query27 0.08 0.08 0.08
query28 13.50 1.02 0.99
query29 12.63 3.39 3.35
query30 0.25 0.05 0.05
query31 2.90 0.39 0.39
query32 3.25 0.48 0.47
query33 2.96 3.02 3.02
query34 17.15 4.40 4.40
query35 4.44 4.42 4.43
query36 0.65 0.46 0.47
query37 0.18 0.16 0.16
query38 0.16 0.15 0.16
query39 0.04 0.03 0.03
query40 0.16 0.13 0.13
query41 0.09 0.05 0.05
query42 0.06 0.04 0.04
query43 0.05 0.04 0.04
Total cold run time: 109.53 s
Total hot run time: 31.14 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2378308643
TeamCity be ut coverage result:
Function Coverage: 37.31% (9635/25823)
Line Coverage: 28.72% (79744/277668)
Region Coverage: 28.13% (41215/146510)
Branch Coverage: 24.76% (20992/84768)
Coverage Report: http://coverage.selectdb-in.cc/coverage/53b29bdb163a3b6dcc8131338c1927b9f7f985a3_53b29bdb163a3b6dcc8131338c1927b9f7f985a3/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370981459
<details>
<summary>TPC-DS: <b>Total hot run time: 191557 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5ad2fd31185d475853b5ff6398eb417e1319b1cf, data reload: false
query1 969 370 393 370
query2 6543 2095 2000 2000
query3 6709 229 226 226
query4 34875 23380 23493 23380
query5 4349 491 482 482
query6 278 182 174 174
query7 4629 311 308 308
query8 295 240 227 227
query9 9691 2722 2692 2692
query10 471 284 265 265
query11 18262 15149 16668 15149
query12 148 101 95 95
query13 1611 427 427 427
query14 10306 7474 7267 7267
query15 273 176 177 176
query16 7905 467 479 467
query17 1755 597 535 535
query18 2002 310 299 299
query19 352 144 143 143
query20 113 107 106 106
query21 215 106 101 101
query22 4657 4499 4205 4205
query23 34808 33961 34072 33961
query24 11117 2867 2886 2867
query25 624 396 405 396
query26 1157 168 158 158
query27 2506 292 293 292
query28 8041 2461 2474 2461
query29 835 456 447 447
query30 321 158 162 158
query31 1062 811 809 809
query32 94 55 57 55
query33 771 294 294 294
query34 981 503 496 496
query35 902 738 739 738
query36 1109 951 953 951
query37 153 88 90 88
query38 4009 3929 3886 3886
query39 1458 1394 1414 1394
query40 200 94 95 94
query41 49 47 50 47
query42 123 98 96 96
query43 537 491 472 472
query44 1255 808 795 795
query45 192 164 169 164
query46 1144 702 725 702
query47 1941 1816 1868 1816
query48 480 368 372 368
query49 1127 392 394 392
query50 831 409 418 409
query51 7060 6962 6975 6962
query52 96 86 86 86
query53 265 191 180 180
query54 1214 472 486 472
query55 78 80 79 79
query56 279 252 267 252
query57 1229 1093 1094 1093
query58 274 238 241 238
query59 3242 3004 3041 3004
query60 311 280 290 280
query61 129 123 121 121
query62 857 684 666 666
query63 230 198 187 187
query64 5106 737 722 722
query65 3296 3203 3226 3203
query66 1429 358 327 327
query67 16189 15774 15530 15530
query68 3519 606 587 587
query69 460 315 305 305
query70 1208 1052 1140 1052
query71 350 277 276 276
query72 6373 4308 3911 3911
query73 771 352 354 352
query74 9644 9057 9093 9057
query75 3394 2696 2682 2682
query76 2684 1000 870 870
query77 409 300 295 295
query78 10142 9245 9187 9187
query79 2439 603 604 603
query80 1327 449 444 444
query81 575 245 241 241
query82 677 136 142 136
query83 222 141 139 139
query84 243 83 80 80
query85 1663 287 273 273
query86 475 296 310 296
query87 4413 4356 4356 4356
query88 4366 2431 2386 2386
query89 402 292 292 292
query90 1947 190 196 190
query91 197 149 144 144
query92 67 48 48 48
query93 1457 582 571 571
query94 943 294 303 294
query95 362 251 262 251
query96 617 279 285 279
query97 3296 3175 3183 3175
query98 214 208 197 197
query99 1701 1292 1286 1286
Total cold run time: 302076 ms
Total hot run time: 191557 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2304546327
<details>
<summary>TPC-DS: <b>Total hot run time: 192177 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 491fd64bc5e55944a0e878b69db16b865936869c, data reload: false
query1 1259 896 850 850
query2 6292 1839 1822 1822
query3 10598 3960 3861 3861
query4 59623 26238 23165 23165
query5 5388 510 509 509
query6 398 157 163 157
query7 5758 296 306 296
query8 280 203 212 203
query9 8744 2458 2451 2451
query10 458 270 260 260
query11 17805 15162 15096 15096
query12 156 110 106 106
query13 1523 386 388 386
query14 11169 7500 8037 7500
query15 223 185 172 172
query16 7153 472 494 472
query17 1097 583 577 577
query18 1379 304 297 297
query19 294 154 152 152
query20 119 110 116 110
query21 211 108 106 106
query22 4805 4521 4623 4521
query23 34044 33736 33242 33242
query24 6019 2951 2846 2846
query25 542 401 396 396
query26 684 166 162 162
query27 1764 277 288 277
query28 3777 2059 2010 2010
query29 689 434 431 431
query30 227 157 154 154
query31 945 740 765 740
query32 81 54 59 54
query33 453 307 291 291
query34 867 484 492 484
query35 861 722 734 722
query36 1083 956 947 947
query37 143 84 86 84
query38 4072 3824 3841 3824
query39 1442 1415 1459 1415
query40 203 120 118 118
query41 48 47 45 45
query42 115 97 95 95
query43 493 460 472 460
query44 1105 751 759 751
query45 198 170 163 163
query46 1104 750 758 750
query47 1882 1809 1830 1809
query48 380 310 313 310
query49 803 468 421 421
query50 814 431 432 431
query51 7092 7117 7019 7019
query52 97 88 85 85
query53 259 196 179 179
query54 554 455 459 455
query55 75 76 77 76
query56 287 249 253 249
query57 1194 1049 1049 1049
query58 217 252 239 239
query59 2986 2934 2717 2717
query60 303 259 270 259
query61 102 124 99 99
query62 744 661 650 650
query63 219 188 183 183
query64 3328 1764 1772 1764
query65 3221 3233 3177 3177
query66 672 365 339 339
query67 15364 15355 15423 15355
query68 3031 597 584 584
query69 402 273 278 273
query70 1213 1057 1055 1055
query71 339 267 282 267
query72 2715 2143 2138 2138
query73 712 331 326 326
query74 9274 8830 8858 8830
query75 3418 2700 2718 2700
query76 1443 1003 1083 1003
query77 516 320 328 320
query78 10863 9342 9036 9036
query79 1040 530 533 530
query80 676 511 529 511
query81 541 231 227 227
query82 276 135 136 135
query83 169 149 147 147
query84 267 78 78 78
query85 679 287 350 287
query86 320 311 303 303
query87 4305 4277 4186 4186
query88 3544 2342 2368 2342
query89 374 286 286 286
query90 1990 203 195 195
query91 123 100 105 100
query92 62 56 51 51
query93 1064 548 547 547
query94 696 300 301 300
query95 360 258 258 258
query96 594 270 276 270
query97 3182 3050 3115 3050
query98 216 216 205 205
query99 1678 1242 1279 1242
Total cold run time: 302366 ms
Total hot run time: 192177 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2242686715
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2242689496
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2246747520
<details>
<summary>TPC-DS: <b>Total hot run time: 175342 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e15b12ebc058be1ebdaed1dbdfed0a7b8b4791e5, data reload: false
query1 917 379 365 365
query2 6432 1884 1848 1848
query3 6632 209 221 209
query4 28750 17638 17093 17093
query5 3666 496 500 496
query6 275 178 184 178
query7 4589 297 287 287
query8 238 196 194 194
query9 8690 2407 2379 2379
query10 425 310 278 278
query11 11017 10022 10082 10022
query12 117 86 82 82
query13 1644 374 376 374
query14 10361 7918 8341 7918
query15 240 167 165 165
query16 7549 472 495 472
query17 1584 570 543 543
query18 1745 305 292 292
query19 215 156 160 156
query20 112 81 84 81
query21 207 144 146 144
query22 4327 4191 4071 4071
query23 34358 34014 33775 33775
query24 10664 2997 2982 2982
query25 621 397 398 397
query26 723 162 160 160
query27 2232 279 289 279
query28 6210 2086 2101 2086
query29 917 647 686 647
query30 257 157 153 153
query31 1025 779 766 766
query32 94 56 64 56
query33 672 362 356 356
query34 941 500 514 500
query35 896 828 779 779
query36 1183 1031 1000 1000
query37 149 85 92 85
query38 3000 2940 2864 2864
query39 940 852 813 813
query40 204 126 125 125
query41 45 45 44 44
query42 121 101 99 99
query43 511 478 464 464
query44 1106 725 728 725
query45 205 174 166 166
query46 1105 762 764 762
query47 1839 1782 1761 1761
query48 369 297 294 294
query49 836 422 423 422
query50 802 399 394 394
query51 6752 6670 6700 6670
query52 108 94 96 94
query53 374 312 294 294
query54 871 463 454 454
query55 80 74 83 74
query56 334 277 278 277
query57 1114 1084 1046 1046
query58 246 255 260 255
query59 2787 2733 2698 2698
query60 312 294 298 294
query61 102 98 96 96
query62 800 638 656 638
query63 338 294 310 294
query64 9186 2246 1769 1769
query65 3176 3143 3111 3111
query66 720 337 331 331
query67 15548 15031 14983 14983
query68 4504 559 555 555
query69 549 409 394 394
query70 1151 1144 1141 1141
query71 375 299 299 299
query72 7209 5802 5702 5702
query73 768 329 327 327
query74 6068 5678 5642 5642
query75 3383 2685 2735 2685
query76 2176 1009 935 935
query77 456 319 316 316
query78 10014 9497 8969 8969
query79 3181 536 547 536
query80 1863 508 502 502
query81 612 228 226 226
query82 900 151 141 141
query83 325 178 175 175
query84 271 98 89 89
query85 1648 318 371 318
query86 490 327 322 322
query87 3282 3075 3112 3075
query88 4516 2377 2398 2377
query89 514 408 414 408
query90 1765 198 202 198
query91 132 106 106 106
query92 64 53 52 52
query93 5145 524 518 518
query94 1012 295 290 290
query95 411 324 320 320
query96 616 269 270 269
query97 3306 3052 3014 3014
query98 221 210 211 210
query99 1572 1252 1299 1252
Total cold run time: 283104 ms
Total hot run time: 175342 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244140280
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249181053
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249541063
<details>
<summary>TPC-H: <b>Total hot run time: 39736 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
------ Round 1 ----------------------------------
q1 17623 4358 4290 4290
q2 2001 188 181 181
q3 10455 1216 1132 1132
q4 10184 832 854 832
q5 7525 2674 2662 2662
q6 219 138 138 138
q7 954 600 607 600
q8 9222 2052 2063 2052
q9 8544 6542 6555 6542
q10 8823 3768 3796 3768
q11 463 234 235 234
q12 432 224 223 223
q13 17798 3001 3015 3001
q14 264 245 242 242
q15 504 483 502 483
q16 506 385 381 381
q17 947 609 638 609
q18 8024 7462 7424 7424
q19 6501 1368 1248 1248
q20 647 324 330 324
q21 4953 3090 3238 3090
q22 351 280 283 280
Total cold run time: 116940 ms
Total hot run time: 39736 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4352 4266 4248 4248
q2 363 275 267 267
q3 2969 2799 2927 2799
q4 1987 1713 1661 1661
q5 5634 5540 5474 5474
q6 217 130 130 130
q7 2202 1796 1881 1796
q8 3263 3389 3457 3389
q9 8743 8683 8792 8683
q10 4069 3866 3849 3849
q11 570 485 498 485
q12 806 657 672 657
q13 16948 3137 3161 3137
q14 320 279 310 279
q15 525 503 486 486
q16 499 451 434 434
q17 1804 1537 1515 1515
q18 7998 7934 7824 7824
q19 1706 1603 1575 1575
q20 2135 1926 1848 1848
q21 5143 4830 4872 4830
q22 554 471 491 471
Total cold run time: 72807 ms
Total hot run time: 55837 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254497683
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254503321
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2376061609
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370841907
<details>
<summary>TPC-H: <b>Total hot run time: 41326 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 893c34c4a2f2cabfc98916e504aad123f1a6862b, data reload: false
------ Round 1 ----------------------------------
q1 17953 7602 7310 7310
q2 2250 175 163 163
q3 11484 1230 1187 1187
q4 11271 803 740 740
q5 8018 2946 2888 2888
q6 242 157 156 156
q7 1020 646 629 629
q8 9339 1976 1970 1970
q9 6625 6400 6434 6400
q10 6986 2308 2314 2308
q11 444 243 245 243
q12 407 220 216 216
q13 17793 3035 3010 3010
q14 248 212 204 204
q15 574 538 528 528
q16 652 622 606 606
q17 998 578 588 578
q18 7305 6748 6720 6720
q19 1410 985 1041 985
q20 605 308 281 281
q21 4036 3212 3242 3212
q22 1124 992 998 992
Total cold run time: 110784 ms
Total hot run time: 41326 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7345 7279 7268 7268
q2 337 223 222 222
q3 2947 2798 2823 2798
q4 1937 1705 1698 1698
q5 5460 5534 5501 5501
q6 224 143 143 143
q7 2117 1729 1719 1719
q8 3253 3413 3469 3413
q9 8551 8511 8550 8511
q10 3490 3447 3467 3447
q11 583 490 470 470
q12 827 554 596 554
q13 5916 3030 3039 3030
q14 291 257 278 257
q15 569 515 515 515
q16 737 662 658 658
q17 1799 1558 1559 1558
q18 7811 7438 7347 7347
q19 1673 1536 1504 1504
q20 2028 1827 1825 1825
q21 5474 5281 5352 5281
q22 1142 1022 1004 1004
Total cold run time: 64511 ms
Total hot run time: 58723 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2378299592
<details>
<summary>TPC-H: <b>Total hot run time: 41037 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53b29bdb163a3b6dcc8131338c1927b9f7f985a3, data reload: false
------ Round 1 ----------------------------------
q1 17837 7984 7349 7349
q2 2600 168 152 152
q3 12246 1127 1153 1127
q4 10368 760 817 760
q5 7827 2885 2838 2838
q6 238 150 162 150
q7 984 634 630 630
q8 9628 1905 1962 1905
q9 6563 6440 6451 6440
q10 6938 2313 2294 2294
q11 437 243 254 243
q12 412 230 225 225
q13 17795 2962 2978 2962
q14 255 209 203 203
q15 558 530 527 527
q16 656 583 593 583
q17 978 541 571 541
q18 7183 6745 6700 6700
q19 1399 1032 1005 1005
q20 493 214 203 203
q21 3968 3237 3181 3181
q22 1097 1020 1019 1019
Total cold run time: 110460 ms
Total hot run time: 41037 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7285 7274 7221 7221
q2 330 229 228 228
q3 2874 2782 2743 2743
q4 1939 1666 1727 1666
q5 5380 5418 5460 5418
q6 224 140 136 136
q7 2090 1714 1682 1682
q8 3236 3375 3409 3375
q9 8480 8517 8534 8517
q10 3482 3468 3470 3468
q11 571 483 465 465
q12 785 588 609 588
q13 5053 3024 2996 2996
q14 291 259 255 255
q15 562 517 501 501
q16 667 620 652 620
q17 1780 1570 1561 1561
q18 7738 7438 7541 7438
q19 1670 1524 1472 1472
q20 2051 1795 1842 1795
q21 5504 5230 5106 5106
q22 1112 1008 993 993
Total cold run time: 63104 ms
Total hot run time: 58244 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2380503448
<details>
<summary>TPC-H: <b>Total hot run time: 40643 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5d84c24b8a638d6a756ce24eab65537774bf5e8f, data reload: false
------ Round 1 ----------------------------------
q1 17561 7385 7249 7249
q2 2010 307 268 268
q3 12173 1040 1160 1040
q4 10556 706 693 693
q5 7735 2853 2753 2753
q6 242 150 151 150
q7 1018 635 619 619
q8 9363 1937 1904 1904
q9 6560 6402 6367 6367
q10 6959 2285 2282 2282
q11 439 237 260 237
q12 416 221 220 220
q13 17779 2996 2997 2996
q14 244 215 208 208
q15 579 539 517 517
q16 630 592 581 581
q17 962 528 541 528
q18 7111 6589 6711 6589
q19 1395 1042 1025 1025
q20 489 203 205 203
q21 4222 3233 3257 3233
q22 1089 1011 981 981
Total cold run time: 109532 ms
Total hot run time: 40643 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7445 7204 7228 7204
q2 331 228 228 228
q3 2989 2940 2951 2940
q4 2040 1877 1754 1754
q5 5761 5777 5767 5767
q6 234 147 144 144
q7 2188 1791 1851 1791
q8 3362 3616 3453 3453
q9 8886 8834 8781 8781
q10 3571 3567 3551 3551
q11 574 508 504 504
q12 823 657 644 644
q13 8721 3171 3186 3171
q14 329 280 276 276
q15 577 516 533 516
q16 676 642 633 633
q17 1870 1644 1611 1611
q18 8273 7692 7629 7629
q19 1690 1563 1430 1430
q20 2097 1885 1929 1885
q21 5492 5394 5383 5383
q22 1107 1069 1032 1032
Total cold run time: 69036 ms
Total hot run time: 60327 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244211838
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1691371195
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -115,10 +117,24 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const IColumn& column, const
if (scale > 3) {
uint32_t microsecond = datetime_val.microsecond();
timestamp = (timestamp * 1000000) + microsecond;
+ timestamp -= std::chrono::duration_cast<std::chrono::microseconds>(
+ cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
+ .time_since_epoch())
+ .count();
} else if (scale > 0) {
uint32_t millisecond = datetime_val.microsecond() / 1000;
timestamp = (timestamp * 1000) + millisecond;
+ timestamp -= std::chrono::duration_cast<std::chrono::milliseconds>(
+ cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
+ .time_since_epoch())
+ .count();
+ } else if (scale == 0) {
+ timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
Review Comment:
> Should the logic here be removed? It should only require modifying the scale of the TypeDescriptor.
Already Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2250232000
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2250381953
<details>
<summary>ClickBench: <b>Total hot run time: 30.52 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d2024fd6f9dfa859427c6a2f4e4bc7dba4883866, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.04 0.05
query4 1.69 0.09 0.09
query5 0.49 0.46 0.50
query6 1.12 0.73 0.73
query7 0.01 0.02 0.01
query8 0.05 0.04 0.04
query9 0.56 0.49 0.50
query10 0.54 0.54 0.54
query11 0.15 0.11 0.11
query12 0.14 0.13 0.12
query13 0.60 0.59 0.59
query14 0.76 0.78 0.78
query15 0.84 0.83 0.81
query16 0.35 0.37 0.35
query17 1.01 0.97 0.97
query18 0.23 0.21 0.22
query19 1.84 1.69 1.70
query20 0.01 0.01 0.01
query21 15.40 0.75 0.64
query22 4.65 6.86 1.99
query23 18.24 1.40 1.22
query24 2.08 0.22 0.22
query25 0.16 0.08 0.09
query26 0.31 0.21 0.21
query27 0.46 0.22 0.22
query28 13.35 1.02 1.01
query29 12.62 3.34 3.31
query30 0.25 0.06 0.06
query31 2.86 0.38 0.38
query32 3.28 0.48 0.46
query33 2.91 2.87 2.90
query34 17.14 4.32 4.31
query35 4.40 4.38 4.38
query36 0.65 0.48 0.47
query37 0.18 0.16 0.15
query38 0.16 0.15 0.14
query39 0.04 0.04 0.04
query40 0.14 0.12 0.12
query41 0.10 0.05 0.05
query42 0.06 0.05 0.04
query43 0.04 0.05 0.04
Total cold run time: 110.22 s
Total hot run time: 30.52 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255567379
Waiting for merge. https://github.com/apache/doris-flink-connector/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2245509911
<details>
<summary>TPC-H: <b>Total hot run time: 40560 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 03499b884bdef539533d9c24747f4ee89e53a6e2, data reload: false
------ Round 1 ----------------------------------
q1 17793 4322 4266 4266
q2 2013 199 184 184
q3 10779 1152 1136 1136
q4 10192 793 765 765
q5 7530 2727 2704 2704
q6 222 136 139 136
q7 963 616 605 605
q8 9285 2075 2094 2075
q9 8752 6585 6564 6564
q10 8946 3835 3828 3828
q11 477 244 245 244
q12 455 230 229 229
q13 18684 3009 3017 3009
q14 286 248 234 234
q15 530 501 510 501
q16 531 437 405 405
q17 969 710 701 701
q18 9186 7874 8105 7874
q19 10218 1494 1294 1294
q20 697 331 346 331
q21 4963 3186 3218 3186
q22 339 289 290 289
Total cold run time: 123810 ms
Total hot run time: 40560 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4426 4306 4391 4306
q2 380 267 262 262
q3 3203 2939 2923 2923
q4 1993 1656 1718 1656
q5 5562 5481 5603 5481
q6 224 134 134 134
q7 2264 1834 1847 1834
q8 3266 3412 3389 3389
q9 8813 8848 8735 8735
q10 3959 3810 3843 3810
q11 582 485 511 485
q12 810 620 649 620
q13 17224 3144 3192 3144
q14 305 282 276 276
q15 528 505 488 488
q16 486 436 439 436
q17 1830 1555 1507 1507
q18 8223 7794 7906 7794
q19 1738 1475 1646 1475
q20 3024 1887 1864 1864
q21 8991 4823 4718 4718
q22 791 501 504 501
Total cold run time: 78622 ms
Total hot run time: 55838 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2242762141
<details>
<summary>ClickBench: <b>Total hot run time: 30.55 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9e9ede229bede24c314c312422ecdcb57c89f8a6, data reload: false
query1 0.05 0.04 0.03
query2 0.07 0.04 0.04
query3 0.22 0.05 0.05
query4 1.67 0.08 0.07
query5 0.49 0.48 0.49
query6 1.18 0.73 0.73
query7 0.02 0.01 0.02
query8 0.05 0.05 0.05
query9 0.55 0.49 0.50
query10 0.54 0.54 0.55
query11 0.16 0.11 0.11
query12 0.15 0.13 0.12
query13 0.60 0.58 0.57
query14 0.76 0.78 0.81
query15 0.86 0.82 0.81
query16 0.37 0.37 0.37
query17 1.04 1.03 1.05
query18 0.23 0.22 0.22
query19 1.81 1.74 1.84
query20 0.01 0.01 0.01
query21 15.39 0.79 0.67
query22 4.49 7.79 1.75
query23 18.28 1.40 1.26
query24 2.07 0.24 0.23
query25 0.16 0.09 0.09
query26 0.31 0.21 0.20
query27 0.46 0.23 0.23
query28 13.30 1.02 1.02
query29 12.61 3.29 3.28
query30 0.25 0.06 0.05
query31 2.91 0.39 0.39
query32 3.23 0.47 0.47
query33 2.92 2.85 2.89
query34 17.16 4.35 4.32
query35 4.39 4.40 4.50
query36 0.66 0.49 0.49
query37 0.20 0.16 0.16
query38 0.16 0.15 0.15
query39 0.04 0.04 0.04
query40 0.15 0.12 0.13
query41 0.09 0.04 0.05
query42 0.06 0.05 0.05
query43 0.04 0.04 0.04
Total cold run time: 110.16 s
Total hot run time: 30.55 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249204457
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244189697
<details>
<summary>TPC-DS: <b>Total hot run time: 173102 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4dcc56cfe21badfeb9e3ca09cd89181ab325dd30, data reload: false
query1 909 368 368 368
query2 6493 1902 1909 1902
query3 6666 200 213 200
query4 24808 17511 17295 17295
query5 4184 485 471 471
query6 289 155 158 155
query7 4587 282 282 282
query8 244 197 179 179
query9 8491 2383 2363 2363
query10 458 287 266 266
query11 10956 10044 10052 10044
query12 135 82 83 82
query13 1632 367 353 353
query14 10218 7680 7585 7585
query15 221 168 166 166
query16 7704 467 496 467
query17 1414 569 525 525
query18 1945 278 271 271
query19 188 144 143 143
query20 90 81 80 80
query21 206 126 122 122
query22 4274 4059 4026 4026
query23 33790 33158 33205 33158
query24 11436 2873 2863 2863
query25 628 358 356 356
query26 1619 148 149 148
query27 2938 263 263 263
query28 7381 1969 1944 1944
query29 1016 632 613 613
query30 284 173 149 149
query31 971 745 741 741
query32 95 51 52 51
query33 774 318 334 318
query34 894 479 475 475
query35 862 748 729 729
query36 1117 944 920 920
query37 143 80 78 78
query38 2857 2784 2700 2700
query39 864 812 800 800
query40 286 118 116 116
query41 49 47 45 45
query42 112 98 102 98
query43 520 465 477 465
query44 1203 713 708 708
query45 188 158 158 158
query46 1087 721 727 721
query47 1869 1773 1775 1773
query48 360 290 286 286
query49 1165 428 430 428
query50 797 389 379 379
query51 6774 6793 6663 6663
query52 99 96 90 90
query53 360 287 291 287
query54 944 452 447 447
query55 76 71 82 71
query56 331 282 291 282
query57 1156 1029 1065 1029
query58 267 243 260 243
query59 2852 2747 2748 2747
query60 327 291 301 291
query61 120 115 117 115
query62 851 627 645 627
query63 325 297 307 297
query64 10554 2248 7416 2248
query65 3228 3105 3134 3105
query66 1376 331 372 331
query67 15448 15037 15096 15037
query68 4629 517 527 517
query69 597 409 357 357
query70 1205 1147 1178 1147
query71 430 273 281 273
query72 7342 5665 5077 5077
query73 739 320 318 318
query74 6043 5677 5567 5567
query75 3600 2710 2737 2710
query76 3173 942 940 940
query77 624 317 309 309
query78 9852 9371 8966 8966
query79 7654 520 518 518
query80 1211 472 475 472
query81 581 227 222 222
query82 794 147 138 138
query83 193 163 165 163
query84 277 88 88 88
query85 1429 368 289 289
query86 477 295 305 295
query87 3243 3093 3115 3093
query88 4970 2396 2381 2381
query89 493 395 393 393
query90 1874 193 190 190
query91 130 103 104 103
query92 58 49 50 49
query93 6007 511 495 495
query94 1165 266 295 266
query95 399 319 314 314
query96 606 271 272 271
query97 3187 3034 3019 3019
query98 215 200 196 196
query99 1694 1287 1228 1228
Total cold run time: 291396 ms
Total hot run time: 173102 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1688012582
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -112,13 +114,23 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const IColumn& column, const
binary_cast<UInt64, DateV2Value<DateTimeV2ValueType>>(col_data[i]);
datetime_val.unix_timestamp(×tamp, ctz);
- if (scale > 3) {
+ if (scale > 0) {
uint32_t microsecond = datetime_val.microsecond();
- timestamp = (timestamp * 1000000) + microsecond;
- } else if (scale > 0) {
- uint32_t millisecond = datetime_val.microsecond() / 1000;
- timestamp = (timestamp * 1000) + millisecond;
+
+ if (scale > 3) {
+ timestamp = (timestamp * 1000000) + microsecond;
+ } else {
+ uint32_t millisecond = microsecond / 1000;
+ timestamp = (timestamp * 1000) + millisecond;
+ }
+ } else {
+ timestamp *= 1000000;
}
+ timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
Review Comment:
```
if (scale > 0) {
uint32_t microsecond = datetime_val.microsecond();
if (scale > 3) {
timestamp = (timestamp * 1000000) + microsecond;
} else {
uint32_t millisecond = microsecond / 1000;
timestamp = (timestamp * 1000) + millisecond;
}
} else {
timestamp *= 1000000;
}
timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
.time_since_epoch())
.count() *
1000000;
```
in above code, no matter how much the scale is, the timestamp is millisecond precision, maybe change to:
```
int64_t time_offset = std::chrono::duration_cast<std::chrono::seconds>(
cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
.time_since_epoch())
.count();
if (scale > 3) {
uint32_t microsecond = datetime_val.microsecond();
timestamp = (timestamp - time_offset) * 1000000 + microsecond;
} else if (scale > 0) {
uint32_t millisecond = datetime_val.microsecond() / 1000;
timestamp = (timestamp - time_offset) * 1000 + millisecond;
} else {
timestamp -= time_offset;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1688012582
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -112,13 +114,23 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const IColumn& column, const
binary_cast<UInt64, DateV2Value<DateTimeV2ValueType>>(col_data[i]);
datetime_val.unix_timestamp(×tamp, ctz);
- if (scale > 3) {
+ if (scale > 0) {
uint32_t microsecond = datetime_val.microsecond();
- timestamp = (timestamp * 1000000) + microsecond;
- } else if (scale > 0) {
- uint32_t millisecond = datetime_val.microsecond() / 1000;
- timestamp = (timestamp * 1000) + millisecond;
+
+ if (scale > 3) {
+ timestamp = (timestamp * 1000000) + microsecond;
+ } else {
+ uint32_t millisecond = microsecond / 1000;
+ timestamp = (timestamp * 1000) + millisecond;
+ }
+ } else {
+ timestamp *= 1000000;
}
+ timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
Review Comment:
```
if (scale > 0) {
uint32_t microsecond = datetime_val.microsecond();
if (scale > 3) {
timestamp = (timestamp * 1000000) + microsecond;
} else {
uint32_t millisecond = microsecond / 1000;
timestamp = (timestamp * 1000) + millisecond;
}
} else {
timestamp *= 1000000;
}
timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
.time_since_epoch())
.count() *
1000000;
```
in above code, no matter how much the scale is, the timestamp is millisecond precision, maybe change to:
```
int64_t time_offset = std::chrono::duration_cast<std::chrono::seconds>(
cctz::convert(cctz::civil_second(1970, 1, 1, 0, 0, 0), ctz)
.time_since_epoch())
.count();
if (scale > 3) {
uint32_t microsecond = datetime_val.microsecond();
timestamp = (timestamp - time_offset) * 1000000 + microsecond;
} else if (scale > 0) {
uint32_t millisecond = datetime_val.microsecond() / 1000;
timestamp = (timestamp - time_offset) * 1000 + millisecond;
} else {
timestamp -= time_offset;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370427515
<details>
<summary>TPC-H: <b>Total hot run time: 41256 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 893c34c4a2f2cabfc98916e504aad123f1a6862b, data reload: false
------ Round 1 ----------------------------------
q1 17606 7341 7219 7219
q2 2015 318 306 306
q3 12141 1044 1203 1044
q4 10575 721 756 721
q5 7848 2889 2834 2834
q6 233 152 149 149
q7 974 611 608 608
q8 9361 1926 1956 1926
q9 6652 6507 6489 6489
q10 6992 2351 2368 2351
q11 437 249 259 249
q12 410 226 221 221
q13 20147 3015 3009 3009
q14 242 216 208 208
q15 589 521 532 521
q16 689 610 612 610
q17 960 580 534 534
q18 7287 6834 6852 6834
q19 1402 980 1009 980
q20 609 291 286 286
q21 4177 3144 3206 3144
q22 1130 1013 1023 1013
Total cold run time: 112476 ms
Total hot run time: 41256 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7287 7339 7337 7337
q2 359 242 246 242
q3 3157 3167 3100 3100
q4 2173 1872 1879 1872
q5 5792 5858 5925 5858
q6 236 163 152 152
q7 2189 1815 1867 1815
q8 3357 3539 3540 3539
q9 9007 8985 8904 8904
q10 3535 3570 3593 3570
q11 569 488 484 484
q12 823 619 603 603
q13 13363 3182 3197 3182
q14 314 295 279 279
q15 577 524 533 524
q16 718 686 693 686
q17 1874 1674 1617 1617
q18 8217 7886 7798 7798
q19 1719 1584 1549 1549
q20 2152 1891 1880 1880
q21 5577 5281 5421 5281
q22 1143 1097 1014 1014
Total cold run time: 74138 ms
Total hot run time: 61286 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370958579
<details>
<summary>TPC-H: <b>Total hot run time: 40740 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5ad2fd31185d475853b5ff6398eb417e1319b1cf, data reload: false
------ Round 1 ----------------------------------
q1 18117 7461 7302 7302
q2 2105 164 158 158
q3 10571 1150 1122 1122
q4 10217 751 676 676
q5 7732 2814 2844 2814
q6 238 147 150 147
q7 977 633 591 591
q8 9339 1894 1980 1894
q9 6516 6379 6373 6373
q10 6991 2266 2280 2266
q11 448 249 250 249
q12 409 222 214 214
q13 17771 2957 3063 2957
q14 249 244 220 220
q15 573 518 517 517
q16 675 614 612 612
q17 978 508 543 508
q18 7323 6701 6684 6684
q19 1406 1075 1031 1031
q20 588 296 283 283
q21 4223 3155 3192 3155
q22 1106 987 967 967
Total cold run time: 108552 ms
Total hot run time: 40740 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7175 7222 7208 7208
q2 324 228 225 225
q3 2919 2735 2774 2735
q4 1925 1691 1667 1667
q5 5399 5468 5467 5467
q6 227 137 141 137
q7 2098 1703 1707 1703
q8 3199 3388 3431 3388
q9 8551 8498 8448 8448
q10 3477 3431 3432 3431
q11 588 487 469 469
q12 779 592 594 592
q13 9523 2969 2952 2952
q14 311 261 270 261
q15 562 521 514 514
q16 703 661 663 661
q17 1788 1540 1565 1540
q18 7849 7466 7272 7272
q19 1644 1481 1386 1386
q20 2037 1815 1836 1815
q21 5374 5222 5216 5216
q22 1105 1011 984 984
Total cold run time: 67557 ms
Total hot run time: 58071 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244141530
@xinyiZzz PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249696750
<details>
<summary>ClickBench: <b>Total hot run time: 30.68 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec848b55520d1a4c70c338b096ea396162b3fed2, data reload: false
query1 0.04 0.03 0.03
query2 0.10 0.04 0.03
query3 0.22 0.05 0.05
query4 1.68 0.08 0.07
query5 0.50 0.49 0.49
query6 1.14 0.74 0.73
query7 0.02 0.01 0.01
query8 0.05 0.04 0.05
query9 0.55 0.49 0.49
query10 0.54 0.55 0.55
query11 0.16 0.10 0.11
query12 0.15 0.13 0.12
query13 0.59 0.59 0.59
query14 0.76 0.79 0.77
query15 0.85 0.81 0.84
query16 0.36 0.35 0.37
query17 0.95 1.00 0.94
query18 0.22 0.20 0.21
query19 1.79 1.82 1.73
query20 0.01 0.00 0.01
query21 15.39 0.80 0.64
query22 4.14 7.19 1.94
query23 18.29 1.39 1.30
query24 2.10 0.23 0.23
query25 0.16 0.09 0.09
query26 0.30 0.21 0.21
query27 0.46 0.23 0.23
query28 13.23 1.02 1.01
query29 12.60 3.28 3.25
query30 0.25 0.06 0.06
query31 2.88 0.39 0.39
query32 3.31 0.48 0.46
query33 2.84 2.97 2.92
query34 16.81 4.42 4.41
query35 4.49 4.39 4.43
query36 0.66 0.47 0.49
query37 0.19 0.16 0.16
query38 0.16 0.14 0.14
query39 0.04 0.03 0.03
query40 0.15 0.12 0.12
query41 0.09 0.05 0.06
query42 0.06 0.05 0.04
query43 0.04 0.05 0.04
Total cold run time: 109.32 s
Total hot run time: 30.68 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249193187
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2246737640
<details>
<summary>TPC-H: <b>Total hot run time: 39774 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e15b12ebc058be1ebdaed1dbdfed0a7b8b4791e5, data reload: false
------ Round 1 ----------------------------------
q1 17614 4783 4255 4255
q2 2017 193 193 193
q3 10433 1166 1119 1119
q4 10182 814 794 794
q5 7515 2661 2579 2579
q6 222 138 139 138
q7 962 608 602 602
q8 9221 2091 2055 2055
q9 8738 6565 6561 6561
q10 8817 3774 3783 3774
q11 476 239 240 239
q12 425 222 229 222
q13 17773 2966 2991 2966
q14 271 233 239 233
q15 523 497 490 490
q16 502 397 378 378
q17 967 633 755 633
q18 8007 7560 7393 7393
q19 5880 1424 1418 1418
q20 686 326 329 326
q21 4903 3118 3219 3118
q22 352 289 288 288
Total cold run time: 116486 ms
Total hot run time: 39774 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4428 4423 4232 4232
q2 373 273 279 273
q3 2972 2864 2875 2864
q4 2009 1697 1670 1670
q5 5691 5571 5470 5470
q6 227 133 134 133
q7 2185 1900 1873 1873
q8 3294 3449 3435 3435
q9 8729 8757 8895 8757
q10 4068 3918 3800 3800
q11 596 512 505 505
q12 813 651 645 645
q13 16034 3175 3204 3175
q14 319 291 271 271
q15 525 488 503 488
q16 478 454 439 439
q17 1829 1551 1502 1502
q18 8092 7977 7812 7812
q19 1699 1592 1674 1592
q20 2142 1887 1875 1875
q21 8487 4829 4596 4596
q22 593 525 488 488
Total cold run time: 75583 ms
Total hot run time: 55895 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249218729
<details>
<summary>TPC-H: <b>Total hot run time: 40112 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
------ Round 1 ----------------------------------
q1 17631 4523 4306 4306
q2 2004 191 184 184
q3 10445 1229 1135 1135
q4 10188 817 795 795
q5 7599 2722 2665 2665
q6 219 136 135 135
q7 949 606 591 591
q8 9210 2074 2068 2068
q9 8837 6589 6569 6569
q10 8824 3853 3778 3778
q11 473 233 240 233
q12 392 233 231 231
q13 18709 2980 2979 2979
q14 283 231 243 231
q15 531 484 500 484
q16 500 390 383 383
q17 983 695 832 695
q18 8197 7636 7471 7471
q19 8327 1383 1360 1360
q20 654 323 335 323
q21 5015 3323 3215 3215
q22 348 281 284 281
Total cold run time: 120318 ms
Total hot run time: 40112 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4384 4282 4373 4282
q2 385 274 280 274
q3 3244 2978 3027 2978
q4 2036 1765 1702 1702
q5 5583 5535 5551 5535
q6 229 139 139 139
q7 2312 1865 1907 1865
q8 3377 3462 3444 3444
q9 8926 9062 8881 8881
q10 4149 3929 3917 3917
q11 608 525 518 518
q12 826 636 620 620
q13 17488 3340 3413 3340
q14 356 301 311 301
q15 559 502 502 502
q16 514 467 467 467
q17 1871 1568 1586 1568
q18 8970 8657 8287 8287
q19 1836 1552 1630 1552
q20 2201 1905 1905 1905
q21 5356 5091 4909 4909
q22 628 532 492 492
Total cold run time: 75838 ms
Total hot run time: 57478 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249554490
<details>
<summary>TPC-DS: <b>Total hot run time: 173782 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 913 374 370 370
query2 6443 1962 1917 1917
query3 6641 206 216 206
query4 26046 17588 17434 17434
query5 3687 485 493 485
query6 267 175 170 170
query7 4585 292 288 288
query8 243 205 192 192
query9 8769 2425 2418 2418
query10 436 282 264 264
query11 11704 10102 9907 9907
query12 110 89 83 83
query13 1641 376 364 364
query14 10094 7756 7874 7756
query15 208 168 170 168
query16 7673 504 474 474
query17 1261 557 524 524
query18 1713 283 271 271
query19 197 146 148 146
query20 89 82 80 80
query21 209 129 125 125
query22 4243 4026 3955 3955
query23 33953 33720 33529 33529
query24 11388 2853 2884 2853
query25 639 397 381 381
query26 1184 155 152 152
query27 2978 288 283 283
query28 7520 2087 2067 2067
query29 894 640 667 640
query30 260 161 162 161
query31 966 772 749 749
query32 97 54 54 54
query33 751 322 333 322
query34 943 498 513 498
query35 877 768 763 763
query36 1167 992 989 989
query37 145 83 82 82
query38 2962 2851 2831 2831
query39 870 807 835 807
query40 199 123 120 120
query41 48 43 46 43
query42 125 98 103 98
query43 511 477 469 469
query44 1208 724 721 721
query45 206 169 169 169
query46 1077 745 753 745
query47 1848 1765 1773 1765
query48 372 286 291 286
query49 832 405 412 405
query50 775 389 398 389
query51 6803 6721 6592 6592
query52 108 90 95 90
query53 359 292 293 292
query54 869 448 454 448
query55 77 74 76 74
query56 280 260 268 260
query57 1106 1067 1066 1066
query58 247 241 251 241
query59 2945 2620 2621 2620
query60 316 290 299 290
query61 118 119 115 115
query62 796 646 663 646
query63 339 301 294 294
query64 9468 2306 1691 1691
query65 3147 3127 3110 3110
query66 744 321 327 321
query67 15498 15043 14860 14860
query68 6208 537 539 537
query69 625 421 388 388
query70 1127 1115 1159 1115
query71 482 288 273 273
query72 8023 5370 5708 5370
query73 783 324 327 324
query74 6294 5639 5599 5599
query75 3888 2697 2683 2683
query76 3759 978 980 978
query77 719 302 316 302
query78 9701 9050 8967 8967
query79 2239 531 516 516
query80 2271 472 474 472
query81 589 224 223 223
query82 1354 133 135 133
query83 286 172 168 168
query84 272 92 150 92
query85 1482 320 295 295
query86 475 304 313 304
query87 3264 3098 3096 3096
query88 3974 2362 2409 2362
query89 482 399 386 386
query90 1773 200 194 194
query91 132 98 101 98
query92 60 49 52 49
query93 2541 507 512 507
query94 1133 299 296 296
query95 406 324 324 324
query96 609 275 275 275
query97 3192 3040 3022 3022
query98 222 202 198 198
query99 1532 1258 1277 1258
Total cold run time: 285084 ms
Total hot run time: 173782 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1694677147
##########
be/src/util/arrow/row_batch.cpp:
##########
@@ -46,7 +46,8 @@ namespace doris {
using strings::Substitute;
-Status convert_to_arrow_type(const TypeDescriptor& type, std::shared_ptr<arrow::DataType>* result) {
+Status convert_to_arrow_type(const TypeDescriptor& type, std::shared_ptr<arrow::DataType>* result,
Review Comment:
warning: function 'convert_to_arrow_type' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
Status convert_to_arrow_type(const TypeDescriptor& type, std::shared_ptr<arrow::DataType>* result,
^
```
<details>
<summary>Additional context</summary>
**be/src/util/arrow/row_batch.cpp:48:** 108 lines including whitespace and comments (threshold 80)
```cpp
Status convert_to_arrow_type(const TypeDescriptor& type, std::shared_ptr<arrow::DataType>* result,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2250221041
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255625398
<details>
<summary>ClickBench: <b>Total hot run time: 29.89 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a009a163f2dacca36efbf95476750a5a9c9cfe57, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.04 0.04
query3 0.23 0.05 0.05
query4 1.69 0.07 0.07
query5 0.52 0.48 0.48
query6 1.14 0.70 0.71
query7 0.01 0.02 0.01
query8 0.05 0.04 0.04
query9 0.57 0.51 0.51
query10 0.56 0.56 0.55
query11 0.15 0.12 0.11
query12 0.15 0.12 0.12
query13 0.62 0.59 0.59
query14 0.78 0.78 0.79
query15 0.89 0.85 0.86
query16 0.36 0.36 0.36
query17 0.99 1.00 1.00
query18 0.22 0.21 0.22
query19 1.84 1.73 1.76
query20 0.01 0.00 0.00
query21 15.44 0.78 0.66
query22 3.86 8.80 1.23
query23 17.83 1.29 1.30
query24 2.23 0.23 0.22
query25 0.19 0.10 0.08
query26 0.31 0.22 0.21
query27 0.45 0.24 0.24
query28 13.18 1.00 0.98
query29 12.56 3.25 3.29
query30 0.25 0.07 0.05
query31 2.87 0.41 0.41
query32 3.25 0.49 0.48
query33 2.93 2.96 2.94
query34 15.46 4.28 4.28
query35 4.34 4.28 4.27
query36 0.68 0.48 0.48
query37 0.20 0.16 0.16
query38 0.16 0.15 0.15
query39 0.04 0.04 0.04
query40 0.16 0.13 0.13
query41 0.10 0.05 0.04
query42 0.05 0.05 0.04
query43 0.05 0.03 0.04
Total cold run time: 107.48 s
Total hot run time: 29.89 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2251858942
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255070705
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2378312604
<details>
<summary>ClickBench: <b>Total hot run time: 33.04 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 53b29bdb163a3b6dcc8131338c1927b9f7f985a3, data reload: false
query1 0.05 0.05 0.04
query2 0.07 0.03 0.02
query3 0.23 0.06 0.07
query4 1.65 0.10 0.10
query5 0.53 0.49 0.49
query6 1.14 0.73 0.73
query7 0.01 0.01 0.01
query8 0.04 0.04 0.03
query9 0.56 0.50 0.50
query10 0.55 0.57 0.54
query11 0.13 0.11 0.11
query12 0.14 0.11 0.11
query13 0.61 0.59 0.60
query14 2.77 2.84 2.80
query15 0.90 0.82 0.82
query16 0.39 0.41 0.38
query17 1.06 1.04 1.04
query18 0.23 0.23 0.22
query19 1.96 1.92 2.01
query20 0.01 0.01 0.01
query21 15.36 0.60 0.57
query22 2.29 3.03 1.62
query23 17.02 0.91 0.66
query24 3.31 1.46 2.08
query25 0.15 0.12 0.09
query26 0.72 0.14 0.14
query27 0.04 0.04 0.04
query28 9.31 1.09 1.08
query29 12.52 3.26 3.25
query30 0.24 0.06 0.06
query31 2.89 0.37 0.37
query32 3.29 0.47 0.46
query33 2.98 3.00 3.05
query34 16.96 4.52 4.47
query35 4.46 4.48 4.48
query36 0.69 0.48 0.50
query37 0.08 0.06 0.05
query38 0.05 0.03 0.04
query39 0.03 0.02 0.03
query40 0.16 0.13 0.12
query41 0.07 0.02 0.02
query42 0.03 0.03 0.02
query43 0.03 0.03 0.03
Total cold run time: 105.71 s
Total hot run time: 33.04 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2376174824
<details>
<summary>ClickBench: <b>Total hot run time: 32.95 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 53b29bdb163a3b6dcc8131338c1927b9f7f985a3, data reload: false
query1 0.04 0.04 0.04
query2 0.06 0.03 0.03
query3 0.23 0.06 0.06
query4 1.64 0.10 0.10
query5 0.51 0.49 0.50
query6 1.14 0.73 0.73
query7 0.02 0.02 0.02
query8 0.04 0.03 0.03
query9 0.56 0.50 0.51
query10 0.56 0.57 0.56
query11 0.14 0.10 0.10
query12 0.14 0.10 0.11
query13 0.61 0.59 0.59
query14 2.98 3.04 2.95
query15 0.90 0.84 0.82
query16 0.36 0.39 0.38
query17 1.05 1.07 1.03
query18 0.20 0.19 0.20
query19 1.95 1.83 1.99
query20 0.02 0.01 0.01
query21 15.36 0.58 0.57
query22 2.63 1.93 1.66
query23 17.20 0.78 0.89
query24 3.09 1.28 1.68
query25 0.32 0.12 0.04
query26 0.47 0.15 0.14
query27 0.05 0.04 0.04
query28 9.81 1.09 1.07
query29 12.57 3.26 3.20
query30 0.24 0.06 0.07
query31 2.87 0.39 0.38
query32 3.28 0.46 0.46
query33 2.98 3.01 3.04
query34 16.90 4.46 4.48
query35 4.49 4.51 4.47
query36 0.67 0.48 0.48
query37 0.08 0.06 0.05
query38 0.05 0.03 0.04
query39 0.04 0.02 0.02
query40 0.15 0.12 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 106.54 s
Total hot run time: 32.95 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2376403756
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2380549475
<details>
<summary>ClickBench: <b>Total hot run time: 32.85 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5d84c24b8a638d6a756ce24eab65537774bf5e8f, data reload: false
query1 0.05 0.04 0.05
query2 0.06 0.02 0.03
query3 0.24 0.06 0.06
query4 1.64 0.10 0.10
query5 0.52 0.50 0.49
query6 1.13 0.72 0.72
query7 0.02 0.02 0.02
query8 0.04 0.03 0.03
query9 0.56 0.50 0.49
query10 0.54 0.55 0.55
query11 0.16 0.11 0.10
query12 0.14 0.12 0.11
query13 0.61 0.59 0.59
query14 2.79 2.72 2.70
query15 0.90 0.83 0.84
query16 0.38 0.38 0.38
query17 1.08 1.06 1.04
query18 0.20 0.20 0.19
query19 1.94 1.89 2.00
query20 0.02 0.01 0.01
query21 15.36 0.59 0.59
query22 2.40 1.94 2.56
query23 16.91 1.20 0.82
query24 2.91 1.46 0.98
query25 0.33 0.12 0.13
query26 0.42 0.15 0.13
query27 0.04 0.05 0.04
query28 10.36 1.11 1.06
query29 12.59 3.25 3.29
query30 0.24 0.06 0.05
query31 2.90 0.37 0.38
query32 3.29 0.49 0.46
query33 3.01 3.04 3.00
query34 16.92 4.44 4.48
query35 4.51 4.48 4.49
query36 0.68 0.48 0.48
query37 0.08 0.06 0.05
query38 0.05 0.03 0.03
query39 0.03 0.02 0.02
query40 0.17 0.13 0.12
query41 0.08 0.02 0.02
query42 0.04 0.02 0.02
query43 0.03 0.03 0.02
Total cold run time: 106.37 s
Total hot run time: 32.85 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370345411
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254504650
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255241735
<details>
<summary>TPC-H: <b>Total hot run time: 42023 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 98f27de0d49036043179bc3e045b0b8899b5bdc0, data reload: false
------ Round 1 ----------------------------------
q1 17989 4306 4195 4195
q2 2431 206 212 206
q3 10429 1443 1366 1366
q4 10177 856 962 856
q5 7644 3029 3000 3000
q6 223 137 141 137
q7 1028 612 628 612
q8 9452 1868 1978 1868
q9 8753 6633 6663 6633
q10 8719 3896 3850 3850
q11 428 258 267 258
q12 420 239 230 230
q13 17738 2912 2942 2912
q14 274 249 247 247
q15 527 485 500 485
q16 493 405 384 384
q17 978 917 872 872
q18 8176 7402 7345 7345
q19 1394 1224 1212 1212
q20 575 322 350 322
q21 5491 4799 4752 4752
q22 350 281 285 281
Total cold run time: 113689 ms
Total hot run time: 42023 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4064 4031 3994 3994
q2 331 239 220 220
q3 3035 2980 3007 2980
q4 1916 1877 1881 1877
q5 5279 5263 5256 5256
q6 224 132 138 132
q7 2083 1678 1696 1678
q8 3229 3324 3310 3310
q9 8424 8322 8315 8315
q10 3751 3835 3866 3835
q11 537 449 457 449
q12 714 566 558 558
q13 14110 2927 2904 2904
q14 283 265 266 265
q15 516 479 473 473
q16 437 395 403 395
q17 1740 1689 1705 1689
q18 7763 7273 7285 7273
q19 1718 1718 1692 1692
q20 2069 1783 1768 1768
q21 5466 5316 5193 5193
q22 517 435 431 431
Total cold run time: 68206 ms
Total hot run time: 54687 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255271897
<details>
<summary>ClickBench: <b>Total hot run time: 29.73 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 98f27de0d49036043179bc3e045b0b8899b5bdc0, data reload: false
query1 0.04 0.04 0.04
query2 0.07 0.04 0.04
query3 0.23 0.04 0.04
query4 1.68 0.06 0.06
query5 0.48 0.48 0.49
query6 1.14 0.71 0.71
query7 0.02 0.02 0.01
query8 0.05 0.05 0.04
query9 0.57 0.50 0.50
query10 0.56 0.55 0.58
query11 0.15 0.11 0.12
query12 0.14 0.12 0.13
query13 0.61 0.60 0.60
query14 0.76 0.79 0.80
query15 0.88 0.85 0.87
query16 0.35 0.36 0.35
query17 1.00 1.03 1.06
query18 0.22 0.22 0.21
query19 1.85 1.72 1.70
query20 0.01 0.00 0.00
query21 15.40 0.79 0.66
query22 3.58 8.35 1.12
query23 17.91 1.36 1.31
query24 2.26 0.23 0.22
query25 0.18 0.08 0.08
query26 0.32 0.21 0.21
query27 0.45 0.24 0.23
query28 13.18 0.99 0.96
query29 12.58 3.32 3.25
query30 0.25 0.06 0.06
query31 2.86 0.41 0.40
query32 3.26 0.49 0.48
query33 2.95 2.93 2.97
query34 15.50 4.27 4.23
query35 4.30 4.29 4.29
query36 0.67 0.48 0.50
query37 0.19 0.16 0.17
query38 0.16 0.14 0.15
query39 0.04 0.04 0.04
query40 0.16 0.13 0.13
query41 0.10 0.05 0.04
query42 0.06 0.05 0.04
query43 0.05 0.05 0.04
Total cold run time: 107.22 s
Total hot run time: 29.73 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #38215:
URL: https://github.com/apache/doris/pull/38215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370920322
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2376406311
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370866500
<details>
<summary>TPC-DS: <b>Total hot run time: 191074 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 893c34c4a2f2cabfc98916e504aad123f1a6862b, data reload: false
query1 979 369 385 369
query2 6519 2141 2032 2032
query3 6702 223 222 222
query4 34738 23520 23461 23461
query5 4395 465 464 464
query6 255 160 157 157
query7 4614 300 306 300
query8 274 226 224 224
query9 9655 2694 2687 2687
query10 472 281 275 275
query11 18252 15293 15223 15223
query12 152 98 101 98
query13 1636 451 437 437
query14 10875 7181 7235 7181
query15 265 174 186 174
query16 7742 488 496 488
query17 1662 567 564 564
query18 2077 311 317 311
query19 356 152 152 152
query20 114 110 110 110
query21 218 103 103 103
query22 4321 4230 4254 4230
query23 34925 33854 34105 33854
query24 11146 2827 2774 2774
query25 656 412 436 412
query26 1192 164 161 161
query27 2796 295 304 295
query28 8217 2469 2427 2427
query29 840 443 432 432
query30 323 166 156 156
query31 1048 779 822 779
query32 101 57 59 57
query33 771 303 297 297
query34 962 495 513 495
query35 889 775 743 743
query36 1096 978 974 974
query37 160 87 86 86
query38 3981 3863 3893 3863
query39 1481 1427 1440 1427
query40 210 98 98 98
query41 51 50 51 50
query42 124 99 99 99
query43 540 509 520 509
query44 1230 820 801 801
query45 196 165 167 165
query46 1133 746 717 717
query47 1885 1817 1836 1817
query48 503 384 388 384
query49 1144 437 423 423
query50 801 427 414 414
query51 7082 7261 6912 6912
query52 104 88 89 88
query53 263 197 186 186
query54 1292 469 495 469
query55 74 77 78 77
query56 274 272 270 270
query57 1225 1122 1114 1114
query58 251 238 241 238
query59 3236 2968 2997 2968
query60 319 284 275 275
query61 132 106 116 106
query62 858 680 685 680
query63 229 193 187 187
query64 5258 657 626 626
query65 3320 3207 3209 3207
query66 1425 310 308 308
query67 16034 15548 15232 15232
query68 5003 575 572 572
query69 492 298 300 298
query70 1205 1058 1130 1058
query71 354 274 277 274
query72 7038 4201 4022 4022
query73 769 353 346 346
query74 10250 8974 8985 8974
query75 3462 2708 2677 2677
query76 3231 964 1001 964
query77 651 303 307 303
query78 9960 9230 9083 9083
query79 2175 585 624 585
query80 1183 453 449 449
query81 592 244 251 244
query82 915 137 141 137
query83 282 136 134 134
query84 270 79 74 74
query85 1352 291 281 281
query86 420 315 299 299
query87 4473 4303 4334 4303
query88 3847 2448 2403 2403
query89 411 287 283 283
query90 2143 192 193 192
query91 194 146 150 146
query92 71 50 48 48
query93 1640 575 561 561
query94 1171 286 294 286
query95 361 258 261 258
query96 621 285 285 285
query97 3265 3120 3156 3120
query98 221 196 197 196
query99 1591 1305 1315 1305
Total cold run time: 305663 ms
Total hot run time: 191074 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2376164420
<details>
<summary>TPC-DS: <b>Total hot run time: 192276 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53b29bdb163a3b6dcc8131338c1927b9f7f985a3, data reload: false
query1 950 387 385 385
query2 6235 2061 2050 2050
query3 8693 197 201 197
query4 33869 23504 23358 23358
query5 3464 467 480 467
query6 267 170 163 163
query7 4196 306 298 298
query8 280 227 222 222
query9 9668 2702 2708 2702
query10 475 291 283 283
query11 17830 15096 15275 15096
query12 163 97 96 96
query13 1542 441 420 420
query14 9283 7466 7345 7345
query15 252 171 182 171
query16 8016 453 470 453
query17 1660 609 594 594
query18 1980 326 331 326
query19 377 161 156 156
query20 120 116 109 109
query21 212 109 108 108
query22 4801 4423 4565 4423
query23 35407 34506 34538 34506
query24 11377 2894 2789 2789
query25 621 413 414 413
query26 1191 170 167 167
query27 2246 304 308 304
query28 7603 2459 2425 2425
query29 827 447 437 437
query30 264 157 163 157
query31 1039 754 800 754
query32 96 54 55 54
query33 747 309 298 298
query34 908 509 495 495
query35 881 718 739 718
query36 1095 950 975 950
query37 155 96 90 90
query38 3976 3877 3899 3877
query39 1620 1426 1424 1424
query40 213 96 98 96
query41 50 49 47 47
query42 117 96 99 96
query43 531 479 476 476
query44 1239 833 790 790
query45 195 165 168 165
query46 1142 713 719 713
query47 1907 1791 1831 1791
query48 465 368 381 368
query49 891 405 404 404
query50 809 420 426 420
query51 7143 7106 6883 6883
query52 97 87 87 87
query53 253 201 178 178
query54 1220 471 463 463
query55 79 82 77 77
query56 317 254 247 247
query57 1222 1136 1085 1085
query58 231 242 219 219
query59 3141 2893 2974 2893
query60 311 273 268 268
query61 111 109 105 105
query62 857 678 678 678
query63 227 191 188 188
query64 3945 644 685 644
query65 3339 3211 3260 3211
query66 769 309 337 309
query67 16752 15432 15752 15432
query68 5005 585 575 575
query69 605 313 309 309
query70 1193 1118 1131 1118
query71 436 272 270 270
query72 7801 4135 4045 4045
query73 769 345 344 344
query74 10358 9013 8891 8891
query75 4408 2588 2663 2588
query76 3766 948 945 945
query77 723 301 300 300
query78 10593 9889 9812 9812
query79 2996 613 619 613
query80 1921 464 445 445
query81 597 238 250 238
query82 657 139 140 139
query83 317 136 147 136
query84 286 79 76 76
query85 1667 317 284 284
query86 461 305 299 299
query87 4414 4384 4249 4249
query88 4422 2436 2389 2389
query89 408 290 284 284
query90 2103 185 187 185
query91 182 138 142 138
query92 65 51 51 51
query93 2352 552 559 552
query94 1132 301 293 293
query95 357 258 253 253
query96 625 280 283 280
query97 3225 3142 3084 3084
query98 220 196 195 195
query99 1556 1309 1283 1283
Total cold run time: 307579 ms
Total hot run time: 192276 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2252025949
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2248009609
<details>
<summary>ClickBench: <b>Total hot run time: 31.05 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.04 0.04
query3 0.21 0.05 0.05
query4 1.68 0.08 0.08
query5 0.51 0.47 0.49
query6 1.14 0.74 0.73
query7 0.02 0.02 0.01
query8 0.05 0.04 0.04
query9 0.55 0.50 0.50
query10 0.55 0.52 0.54
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.60 0.58 0.58
query14 0.76 0.77 0.79
query15 0.85 0.81 0.81
query16 0.36 0.36 0.37
query17 0.95 1.05 1.01
query18 0.23 0.22 0.22
query19 1.78 1.68 1.74
query20 0.01 0.01 0.01
query21 15.39 0.79 0.67
query22 3.77 7.73 2.35
query23 18.34 1.37 1.16
query24 2.05 0.22 0.23
query25 0.15 0.08 0.08
query26 0.30 0.21 0.20
query27 0.45 0.23 0.23
query28 13.28 1.03 1.03
query29 12.63 3.34 3.31
query30 0.25 0.06 0.05
query31 2.88 0.39 0.38
query32 3.27 0.49 0.47
query33 2.86 2.92 2.95
query34 17.05 4.36 4.46
query35 4.49 4.45 4.46
query36 0.66 0.48 0.46
query37 0.20 0.15 0.16
query38 0.16 0.15 0.15
query39 0.04 0.04 0.03
query40 0.16 0.12 0.12
query41 0.09 0.04 0.05
query42 0.05 0.04 0.04
query43 0.05 0.04 0.04
Total cold run time: 109.25 s
Total hot run time: 31.05 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2242733725
<details>
<summary>TPC-H: <b>Total hot run time: 39758 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e9ede229bede24c314c312422ecdcb57c89f8a6, data reload: false
------ Round 1 ----------------------------------
q1 17625 4290 4314 4290
q2 2012 198 189 189
q3 10462 1223 1122 1122
q4 10177 809 762 762
q5 7621 2662 2676 2662
q6 222 139 136 136
q7 973 600 610 600
q8 9217 2069 2097 2069
q9 8834 6539 6560 6539
q10 8839 3773 3790 3773
q11 461 233 241 233
q12 459 232 228 228
q13 17758 3015 3017 3015
q14 283 239 233 233
q15 519 496 486 486
q16 513 375 375 375
q17 969 659 677 659
q18 7969 7442 7355 7355
q19 8644 1300 1471 1300
q20 692 324 321 321
q21 4930 3128 3275 3128
q22 351 283 292 283
Total cold run time: 119530 ms
Total hot run time: 39758 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4457 4318 4293 4293
q2 376 270 259 259
q3 3089 2925 2913 2913
q4 1984 1754 1726 1726
q5 5589 5544 5464 5464
q6 220 134 140 134
q7 2229 1843 1827 1827
q8 3308 3453 3422 3422
q9 8786 8919 8802 8802
q10 4114 3768 3831 3768
q11 611 513 493 493
q12 811 648 640 640
q13 17098 3163 3181 3163
q14 308 313 285 285
q15 526 479 475 475
q16 494 440 476 440
q17 1849 1563 1504 1504
q18 8196 8252 8009 8009
q19 1787 1549 1586 1549
q20 2418 1864 1864 1864
q21 7260 4868 4807 4807
q22 582 518 496 496
Total cold run time: 76092 ms
Total hot run time: 56333 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1688252760
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -112,13 +114,23 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const IColumn& column, const
binary_cast<UInt64, DateV2Value<DateTimeV2ValueType>>(col_data[i]);
datetime_val.unix_timestamp(×tamp, ctz);
- if (scale > 3) {
+ if (scale > 0) {
uint32_t microsecond = datetime_val.microsecond();
- timestamp = (timestamp * 1000000) + microsecond;
- } else if (scale > 0) {
- uint32_t millisecond = datetime_val.microsecond() / 1000;
- timestamp = (timestamp * 1000) + millisecond;
+
+ if (scale > 3) {
+ timestamp = (timestamp * 1000000) + microsecond;
+ } else {
+ uint32_t millisecond = microsecond / 1000;
+ timestamp = (timestamp * 1000) + millisecond;
+ }
+ } else {
+ timestamp *= 1000000;
}
+ timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
Review Comment:
> sub `1970` timestamp does not seem to be the root cause, it seems to be a problem caused by incorrect `DATETIME` `scale`.
I've revert the changes of timestmp scale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2248426778
<details>
<summary>ClickBench: <b>Total hot run time: 31.55 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 0.05 0.04 0.04
query2 0.09 0.03 0.04
query3 0.22 0.06 0.05
query4 1.67 0.09 0.07
query5 0.47 0.48 0.48
query6 1.13 0.73 0.73
query7 0.02 0.02 0.01
query8 0.05 0.04 0.04
query9 0.56 0.47 0.48
query10 0.55 0.54 0.54
query11 0.15 0.11 0.12
query12 0.15 0.13 0.12
query13 0.60 0.58 0.58
query14 0.77 0.79 0.78
query15 0.86 0.83 0.83
query16 0.37 0.37 0.38
query17 0.96 1.04 1.00
query18 0.23 0.22 0.21
query19 1.82 1.70 1.70
query20 0.01 0.02 0.01
query21 15.43 0.79 0.66
query22 3.73 6.35 2.70
query23 18.31 1.46 1.29
query24 2.14 0.24 0.22
query25 0.15 0.09 0.08
query26 0.33 0.22 0.20
query27 0.46 0.24 0.24
query28 13.17 1.02 1.02
query29 12.61 3.31 3.32
query30 0.25 0.06 0.06
query31 2.86 0.39 0.39
query32 3.28 0.48 0.47
query33 2.90 2.95 2.93
query34 17.16 4.37 4.38
query35 4.40 4.38 4.39
query36 0.64 0.48 0.51
query37 0.19 0.16 0.15
query38 0.15 0.15 0.15
query39 0.05 0.04 0.04
query40 0.14 0.13 0.12
query41 0.09 0.04 0.04
query42 0.05 0.04 0.04
query43 0.05 0.04 0.04
Total cold run time: 109.27 s
Total hot run time: 31.55 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2248385645
<details>
<summary>TPC-H: <b>Total hot run time: 39770 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
------ Round 1 ----------------------------------
q1 17645 4404 4276 4276
q2 2011 191 185 185
q3 10468 1225 1087 1087
q4 10198 897 721 721
q5 7527 2691 2593 2593
q6 221 135 137 135
q7 949 593 592 592
q8 9215 2066 2071 2066
q9 8940 6552 6545 6545
q10 8731 3791 3778 3778
q11 480 235 247 235
q12 403 218 226 218
q13 17771 2981 2996 2981
q14 268 235 246 235
q15 523 490 485 485
q16 499 397 395 395
q17 953 675 643 643
q18 8050 7583 7431 7431
q19 8004 1396 1430 1396
q20 672 325 315 315
q21 4848 3202 3171 3171
q22 340 287 288 287
Total cold run time: 118716 ms
Total hot run time: 39770 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4436 4266 4254 4254
q2 384 299 288 288
q3 2996 2901 2910 2901
q4 2021 1688 1774 1688
q5 5670 5600 5515 5515
q6 230 139 130 130
q7 2211 1906 1868 1868
q8 3339 3515 3502 3502
q9 8968 9095 8973 8973
q10 4222 3773 3874 3773
q11 610 501 495 495
q12 823 722 636 636
q13 16082 3241 3257 3241
q14 331 285 298 285
q15 546 511 495 495
q16 511 438 470 438
q17 1833 1541 1523 1523
q18 8535 9500 8545 8545
q19 2347 1572 1555 1555
q20 2266 1991 1946 1946
q21 9842 4940 4884 4884
q22 628 510 565 510
Total cold run time: 78831 ms
Total hot run time: 57445 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249501536
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249686411
<details>
<summary>TPC-DS: <b>Total hot run time: 172709 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec848b55520d1a4c70c338b096ea396162b3fed2, data reload: false
query1 926 371 359 359
query2 6448 1935 1846 1846
query3 6651 210 211 210
query4 28433 17694 17401 17401
query5 4178 480 480 480
query6 266 169 165 165
query7 4598 293 284 284
query8 259 204 200 200
query9 8487 2425 2383 2383
query10 441 277 269 269
query11 10593 9990 10030 9990
query12 134 92 83 83
query13 1640 387 369 369
query14 9442 7324 7610 7324
query15 217 166 163 163
query16 7788 466 440 440
query17 1250 546 528 528
query18 1907 271 291 271
query19 194 146 146 146
query20 89 83 81 81
query21 205 136 130 130
query22 4410 4047 4041 4041
query23 33935 33416 33180 33180
query24 12099 2883 2782 2782
query25 668 372 396 372
query26 1822 149 150 149
query27 2873 267 271 267
query28 7545 2008 1996 1996
query29 1136 616 613 613
query30 289 152 147 147
query31 979 755 751 751
query32 94 51 53 51
query33 773 327 334 327
query34 908 469 496 469
query35 843 739 722 722
query36 1111 938 944 938
query37 210 78 77 77
query38 2842 2726 2748 2726
query39 858 825 820 820
query40 266 122 116 116
query41 51 46 46 46
query42 126 108 110 108
query43 508 473 476 473
query44 1255 776 724 724
query45 207 172 174 172
query46 1100 748 723 723
query47 1879 1787 1792 1787
query48 372 297 284 284
query49 1191 421 413 413
query50 800 392 399 392
query51 6792 6662 6639 6639
query52 109 94 94 94
query53 352 287 281 281
query54 1027 447 447 447
query55 79 73 73 73
query56 302 265 265 265
query57 1177 1049 1072 1049
query58 258 250 250 250
query59 2787 2838 2821 2821
query60 312 275 307 275
query61 97 94 95 94
query62 822 663 646 646
query63 321 290 283 283
query64 10483 2210 1642 1642
query65 3454 3106 3168 3106
query66 1353 346 323 323
query67 15330 15155 14889 14889
query68 4556 544 560 544
query69 483 339 352 339
query70 1203 1082 1088 1082
query71 400 349 271 271
query72 7008 5458 6123 5458
query73 760 326 325 325
query74 6089 5592 5665 5592
query75 3430 2693 2702 2693
query76 2765 989 917 917
query77 489 305 298 298
query78 10863 9025 9653 9025
query79 2595 530 521 521
query80 2126 470 464 464
query81 586 225 227 225
query82 826 134 133 133
query83 301 170 172 170
query84 273 89 88 88
query85 2155 321 301 301
query86 387 325 286 286
query87 3309 3071 3091 3071
query88 4303 2367 2365 2365
query89 474 369 380 369
query90 1616 196 192 192
query91 132 100 103 100
query92 64 50 51 50
query93 2885 518 509 509
query94 692 283 292 283
query95 403 316 321 316
query96 601 274 271 271
query97 3226 3036 3037 3036
query98 209 201 195 195
query99 1598 1255 1274 1255
Total cold run time: 287158 ms
Total hot run time: 172709 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2254522879
<details>
<summary>ClickBench: <b>Total hot run time: 30.47 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0d988836fde4b274f87c6cbf6a5d5347e4c5b467, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.04 0.04
query3 0.22 0.06 0.05
query4 1.67 0.07 0.08
query5 0.50 0.49 0.51
query6 1.16 0.73 0.71
query7 0.02 0.01 0.01
query8 0.05 0.04 0.05
query9 0.54 0.51 0.49
query10 0.55 0.54 0.55
query11 0.16 0.12 0.12
query12 0.14 0.12 0.12
query13 0.59 0.58 0.59
query14 0.77 0.76 0.80
query15 0.85 0.81 0.81
query16 0.36 0.35 0.37
query17 0.96 0.96 1.01
query18 0.22 0.21 0.21
query19 1.76 1.67 1.71
query20 0.02 0.01 0.01
query21 15.42 0.75 0.66
query22 4.17 7.39 1.90
query23 18.28 1.35 1.24
query24 1.99 0.24 0.23
query25 0.15 0.09 0.08
query26 0.30 0.21 0.20
query27 0.45 0.23 0.24
query28 13.27 1.03 1.00
query29 12.65 3.28 3.28
query30 0.26 0.06 0.05
query31 2.88 0.39 0.38
query32 3.31 0.48 0.46
query33 2.88 2.92 2.92
query34 17.25 4.33 4.32
query35 4.47 4.42 4.42
query36 0.65 0.46 0.48
query37 0.18 0.15 0.16
query38 0.16 0.15 0.14
query39 0.04 0.04 0.04
query40 0.15 0.13 0.13
query41 0.09 0.04 0.04
query42 0.05 0.04 0.05
query43 0.05 0.04 0.05
Total cold run time: 109.76 s
Total hot run time: 30.47 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2304440168
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370467492
<details>
<summary>ClickBench: <b>Total hot run time: 32.56 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 893c34c4a2f2cabfc98916e504aad123f1a6862b, data reload: false
query1 0.05 0.04 0.05
query2 0.06 0.03 0.03
query3 0.23 0.06 0.06
query4 1.64 0.10 0.10
query5 0.52 0.51 0.51
query6 1.14 0.73 0.72
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.56 0.50 0.49
query10 0.55 0.57 0.55
query11 0.13 0.10 0.10
query12 0.14 0.12 0.11
query13 0.60 0.63 0.59
query14 3.12 2.94 3.03
query15 0.90 0.82 0.83
query16 0.38 0.38 0.41
query17 1.08 1.06 1.06
query18 0.19 0.19 0.19
query19 1.95 1.90 1.95
query20 0.01 0.01 0.01
query21 15.35 0.59 0.60
query22 2.43 2.50 1.67
query23 17.42 0.76 0.80
query24 2.57 0.73 1.27
query25 0.40 0.16 0.10
query26 0.38 0.14 0.14
query27 0.06 0.04 0.04
query28 11.06 1.10 1.06
query29 12.53 3.32 3.28
query30 0.24 0.06 0.05
query31 2.88 0.38 0.37
query32 3.28 0.46 0.46
query33 3.02 3.05 3.04
query34 17.08 4.42 4.49
query35 4.49 4.51 4.44
query36 0.71 0.47 0.49
query37 0.08 0.06 0.06
query38 0.04 0.04 0.03
query39 0.04 0.02 0.02
query40 0.16 0.12 0.12
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 107.67 s
Total hot run time: 32.56 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370638395
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2380547767
<details>
<summary>TPC-DS: <b>Total hot run time: 192563 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5d84c24b8a638d6a756ce24eab65537774bf5e8f, data reload: false
query1 931 393 417 393
query2 6240 2159 2050 2050
query3 8686 201 208 201
query4 33568 23542 23391 23391
query5 3507 469 469 469
query6 280 168 168 168
query7 4195 307 310 307
query8 294 239 231 231
query9 9405 2687 2676 2676
query10 486 296 288 288
query11 18033 15248 15248 15248
query12 160 101 99 99
query13 1530 439 417 417
query14 9616 7161 7455 7161
query15 254 172 172 172
query16 7943 465 426 426
query17 1672 631 596 596
query18 2115 326 337 326
query19 311 154 151 151
query20 121 118 116 116
query21 219 110 101 101
query22 4565 4660 4566 4566
query23 34839 34750 34244 34244
query24 11594 2819 2853 2819
query25 567 422 434 422
query26 1211 165 177 165
query27 2607 317 296 296
query28 7755 2455 2456 2455
query29 691 447 428 428
query30 267 150 157 150
query31 1036 812 811 811
query32 97 64 58 58
query33 774 303 308 303
query34 933 518 514 514
query35 913 749 725 725
query36 1117 978 918 918
query37 156 94 90 90
query38 4005 3926 3887 3887
query39 1475 1418 1426 1418
query40 258 102 102 102
query41 53 47 51 47
query42 123 96 103 96
query43 536 505 497 497
query44 1251 813 801 801
query45 198 164 172 164
query46 1169 736 739 736
query47 1932 1808 1831 1808
query48 479 377 380 377
query49 1033 444 391 391
query50 841 409 419 409
query51 7161 6875 6955 6875
query52 99 87 87 87
query53 260 183 184 183
query54 1182 483 482 482
query55 82 78 81 78
query56 312 257 256 256
query57 1226 1091 1098 1091
query58 228 241 236 236
query59 3117 3106 3065 3065
query60 290 260 285 260
query61 106 102 101 101
query62 838 758 665 665
query63 218 193 184 184
query64 4868 654 631 631
query65 3246 3180 3198 3180
query66 1267 320 309 309
query67 15981 15551 15631 15551
query68 4337 575 602 575
query69 509 326 294 294
query70 1144 1095 1156 1095
query71 367 275 275 275
query72 6936 4044 4013 4013
query73 791 348 350 348
query74 10401 9102 9036 9036
query75 3430 2700 2666 2666
query76 2788 912 911 911
query77 611 297 298 297
query78 10481 9628 9499 9499
query79 2974 634 613 613
query80 1616 455 473 455
query81 588 240 232 232
query82 700 142 138 138
query83 279 134 132 132
query84 284 75 83 75
query85 1437 294 283 283
query86 456 303 309 303
query87 4460 4445 4366 4366
query88 4187 2402 2370 2370
query89 410 292 298 292
query90 1955 191 184 184
query91 195 148 143 143
query92 71 52 48 48
query93 2777 572 557 557
query94 1072 291 301 291
query95 356 262 264 262
query96 619 291 287 287
query97 3236 3135 3163 3135
query98 227 206 193 193
query99 1514 1309 1277 1277
Total cold run time: 303730 ms
Total hot run time: 192563 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2370857991
TeamCity be ut coverage result:
Function Coverage: 37.29% (9617/25787)
Line Coverage: 28.70% (79559/277215)
Region Coverage: 28.15% (41150/146180)
Branch Coverage: 24.79% (20972/84608)
Coverage Report: http://coverage.selectdb-in.cc/coverage/893c34c4a2f2cabfc98916e504aad123f1a6862b_893c34c4a2f2cabfc98916e504aad123f1a6862b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2249234305
<details>
<summary>ClickBench: <b>Total hot run time: 30.42 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.04 0.04
query3 0.23 0.05 0.04
query4 1.68 0.07 0.08
query5 0.49 0.50 0.47
query6 1.12 0.73 0.73
query7 0.02 0.02 0.01
query8 0.06 0.04 0.04
query9 0.56 0.48 0.48
query10 0.55 0.56 0.53
query11 0.15 0.11 0.12
query12 0.15 0.12 0.12
query13 0.60 0.58 0.60
query14 0.76 0.78 0.77
query15 0.86 0.82 0.82
query16 0.37 0.35 0.36
query17 1.03 0.97 1.00
query18 0.23 0.21 0.20
query19 1.81 1.74 1.75
query20 0.02 0.01 0.00
query21 15.40 0.77 0.65
query22 4.56 7.02 1.70
query23 18.28 1.41 1.24
query24 2.10 0.24 0.21
query25 0.16 0.09 0.09
query26 0.30 0.21 0.20
query27 0.45 0.23 0.23
query28 13.30 1.02 1.01
query29 12.61 3.34 3.32
query30 0.26 0.06 0.05
query31 2.88 0.38 0.38
query32 3.24 0.48 0.47
query33 2.87 2.93 2.94
query34 17.12 4.34 4.34
query35 4.41 4.43 4.42
query36 0.71 0.48 0.50
query37 0.19 0.16 0.15
query38 0.16 0.16 0.16
query39 0.04 0.04 0.03
query40 0.15 0.12 0.12
query41 0.10 0.05 0.05
query42 0.06 0.06 0.05
query43 0.05 0.05 0.04
Total cold run time: 110.21 s
Total hot run time: 30.42 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2250343108
<details>
<summary>TPC-H: <b>Total hot run time: 39223 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d2024fd6f9dfa859427c6a2f4e4bc7dba4883866, data reload: false
------ Round 1 ----------------------------------
q1 17781 4500 4329 4329
q2 2012 196 198 196
q3 10538 1247 1047 1047
q4 10154 756 796 756
q5 7541 2739 2730 2730
q6 223 136 139 136
q7 971 631 596 596
q8 9220 1919 1934 1919
q9 8728 6544 6549 6544
q10 8645 3789 3748 3748
q11 461 251 246 246
q12 404 234 225 225
q13 17765 2992 3017 2992
q14 281 238 242 238
q15 525 489 495 489
q16 498 386 379 379
q17 975 738 693 693
q18 8160 7467 7317 7317
q19 5033 934 944 934
q20 714 333 324 324
q21 4974 3101 3176 3101
q22 350 296 284 284
Total cold run time: 115953 ms
Total hot run time: 39223 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4495 4247 4269 4247
q2 380 251 254 251
q3 3035 2760 2902 2760
q4 1943 1726 1650 1650
q5 5683 5596 5579 5579
q6 228 132 138 132
q7 2184 1797 1879 1797
q8 3297 3437 3430 3430
q9 8811 8778 8879 8778
q10 4123 3929 3798 3798
q11 569 503 492 492
q12 791 636 640 636
q13 16117 3192 3127 3127
q14 314 302 296 296
q15 532 508 510 508
q16 499 429 439 429
q17 1798 1529 1542 1529
q18 8072 7988 7804 7804
q19 1751 1644 1614 1614
q20 2171 1919 1870 1870
q21 5161 4887 4867 4867
q22 563 518 504 504
Total cold run time: 72517 ms
Total hot run time: 56098 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244211810
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244299366
> is it possible to add some test?
I will fix all test case error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244283376
is it possible to add some test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2255593933
<details>
<summary>TPC-H: <b>Total hot run time: 41712 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a009a163f2dacca36efbf95476750a5a9c9cfe57, data reload: false
------ Round 1 ----------------------------------
q1 18686 4240 4102 4102
q2 2042 206 213 206
q3 10438 1408 1324 1324
q4 10188 860 912 860
q5 7631 2938 2937 2937
q6 221 138 135 135
q7 1030 611 607 607
q8 9452 1903 1935 1903
q9 8469 6566 6636 6566
q10 8703 3838 3833 3833
q11 427 252 248 248
q12 412 228 228 228
q13 17753 2970 2965 2965
q14 271 242 244 242
q15 531 477 503 477
q16 497 407 386 386
q17 957 925 933 925
q18 8010 7396 7230 7230
q19 1382 1212 1210 1210
q20 582 319 346 319
q21 5355 4764 4727 4727
q22 357 282 286 282
Total cold run time: 113394 ms
Total hot run time: 41712 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4039 4022 4057 4022
q2 326 229 228 228
q3 3003 2982 2957 2957
q4 1878 1861 1876 1861
q5 5237 5220 5221 5220
q6 217 129 128 128
q7 2072 1689 1713 1689
q8 3205 3282 3278 3278
q9 8310 8327 8390 8327
q10 3743 3822 3840 3822
q11 545 459 450 450
q12 712 605 549 549
q13 14075 2949 2940 2940
q14 302 259 262 259
q15 519 479 478 478
q16 443 395 407 395
q17 1717 1675 1671 1671
q18 7724 7238 7295 7238
q19 1661 1661 1654 1654
q20 1959 1747 1750 1747
q21 5480 5174 5203 5174
q22 511 433 447 433
Total cold run time: 67678 ms
Total hot run time: 54520 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2244180471
<details>
<summary>TPC-H: <b>Total hot run time: 40048 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4dcc56cfe21badfeb9e3ca09cd89181ab325dd30, data reload: false
------ Round 1 ----------------------------------
q1 18427 4781 4368 4368
q2 2340 197 190 190
q3 11090 1145 1099 1099
q4 10646 833 814 814
q5 7619 2764 2707 2707
q6 226 142 140 140
q7 962 620 618 618
q8 9437 2147 2140 2140
q9 8808 6580 6600 6580
q10 8652 3768 3796 3768
q11 470 237 235 235
q12 391 229 220 220
q13 18755 2945 3017 2945
q14 262 235 235 235
q15 521 469 486 469
q16 515 394 373 373
q17 981 621 727 621
q18 8079 7537 7405 7405
q19 7598 1491 1424 1424
q20 675 321 325 321
q21 4881 3096 3261 3096
q22 340 280 283 280
Total cold run time: 121675 ms
Total hot run time: 40048 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4370 4199 4224 4199
q2 369 257 282 257
q3 3018 2746 2775 2746
q4 1899 1627 1577 1577
q5 5304 5317 5314 5314
q6 221 129 132 129
q7 2175 1778 1749 1749
q8 3200 3413 3347 3347
q9 8481 8448 8399 8399
q10 3937 3747 3775 3747
q11 606 478 489 478
q12 760 614 602 602
q13 17648 3004 2984 2984
q14 310 275 268 268
q15 519 489 484 484
q16 477 423 411 411
q17 1776 1502 1484 1484
q18 7673 7588 7411 7411
q19 1669 1601 1543 1543
q20 1999 1790 1797 1790
q21 4956 4776 4681 4681
q22 562 506 531 506
Total cold run time: 71929 ms
Total hot run time: 54106 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2248300445
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2246721595
> better add some test
I will add test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2247750848
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](arrow) Fix time zone issues and accuracy issues [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38215:
URL: https://github.com/apache/doris/pull/38215#issuecomment-2247953821
<details>
<summary>TPC-H: <b>Total hot run time: 39972 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08756988fc15353c073672c1cb6efad285f5c8ba, data reload: false
------ Round 1 ----------------------------------
q1 17639 4453 4258 4258
q2 2002 198 202 198
q3 10435 1245 1019 1019
q4 10190 826 776 776
q5 7535 2739 2683 2683
q6 228 140 142 140
q7 1044 628 606 606
q8 9226 2105 2102 2102
q9 8640 6604 6600 6600
q10 8947 3880 3843 3843
q11 470 236 239 236
q12 431 233 230 230
q13 18936 2999 2991 2991
q14 293 232 242 232
q15 531 473 491 473
q16 512 412 384 384
q17 985 684 659 659
q18 8244 7696 7381 7381
q19 6493 1274 1384 1274
q20 700 323 320 320
q21 5046 3290 3317 3290
q22 340 277 284 277
Total cold run time: 118867 ms
Total hot run time: 39972 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4406 4277 4283 4277
q2 372 265 271 265
q3 3074 2957 3034 2957
q4 2041 1790 1793 1790
q5 5645 5566 5549 5549
q6 239 131 141 131
q7 2260 1856 1864 1856
q8 3300 3441 3425 3425
q9 8812 8942 8787 8787
q10 4205 3809 3834 3809
q11 603 501 529 501
q12 793 687 651 651
q13 17189 3142 3197 3142
q14 342 284 294 284
q15 547 486 504 486
q16 532 441 446 441
q17 1851 1519 1516 1516
q18 8153 7993 7930 7930
q19 1813 1593 1586 1586
q20 2283 1913 1870 1870
q21 8913 4938 4876 4876
q22 651 503 531 503
Total cold run time: 78024 ms
Total hot run time: 56632 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org