[GitHub] [doris] wangbo commented on a diff in pull request #18575: [improvement](resource-group) add test for resource group

["wangbo (via GitHub)" <gi...@apache.org>]

wangbo commented on code in PR #18575:
URL: https://github.com/apache/doris/pull/18575#discussion_r1168372325


##########
fe/fe-core/src/main/java/org/apache/doris/resource/resourcegroup/ResourceGroupMgr.java:
##########
@@ -127,8 +127,11 @@ private void checkAndCreateDefaultGroup() {
     }
 
     public void createResourceGroup(CreateResourceGroupStmt stmt) throws DdlException {
-        ResourceGroup resourceGroup = ResourceGroup.createResourceGroup(stmt.getResourceGroupName(),
-                stmt.getProperties());
+        if (!Config.enable_resource_group) {
+            throw new DdlException("Please add `enable_resource_group=true` in fe.conf to enable resource group.");

Review Comment:
   ```suggestion
               throw new DdlException("unsupported feature now,coming soon");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org